Add evaluation error reporting for expressions #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reports runtime evaluation error (like NPE) into snapshots in evaluationErrors attribute.
jpbempel
requested review from
a team and
ojung
and removed request for
a team
shatzi
approved these changes
Dec 1, 2022
| List<ProbeDetails> additionalProbes = probe.additionalProbes; | ||
| if (!additionalProbes.isEmpty()) { | ||
| for (ProbeDetails additionalProbe : additionalProbes) { | ||
| if (executeScript(additionalProbe.getScript(), capture, additionalProbe.id)) { | ||
| capturingProbeIds.add(additionalProbe.id); | ||
| } else if (capture.areEvalErrors()) { |
There was a problem hiding this comment.
maybe there is a bug here. if we have multiple probes and the first probe generate errors. so capture.areEvalErrors() will return true even if executeScript for the other probe return false without any errors.
We might need to clear errors before execute each script. Moreover, not sure if the errors for those probes are getting recorded
There was a problem hiding this comment.
Do we have tests for de-dup probes with different conditions working/failing?
There was a problem hiding this comment.
yeah I see. I will fix this in another PR. dup probes are still a special case, and not common right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Reports runtime evaluation error (like NPE) into snapshots in
evaluationErrorsattribute.Motivation
Additional Notes