Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lib-injection] Set the pre built artifact that is used to build the image as its own stage #4359

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

pawelchcki
Copy link
Contributor

  • ADD docker commands should be avoided as they can invoke shell scripts. - COPY is more cache friendly

Example use after this change (not requires latest docker - esp buildx and buildkit - to be installed)

mkdir build/
touch build/dd-java-agent.jar
docker buildx build https://github.com/DataDog/dd-trace-java.git#pawel/better_lib_injection_dockerfile:lib-injection/src/main/docker --build-context java_agent=./build/

@pawelchcki pawelchcki requested a review from a team as a code owner December 1, 2022 15:01
@pawelchcki
Copy link
Contributor Author

Thanks for the quick review @devinsba 🙇 !

@pawelchcki pawelchcki merged commit ebe1d4f into master Dec 1, 2022
@pawelchcki pawelchcki deleted the pawel/better_lib_injection_dockerfile branch December 1, 2022 15:29
@github-actions github-actions bot added this to the 1.2.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants