fix spring webflux route extraction + improve webflux tests #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
commented
Dec 6, 2022
| @@ -63,9 +63,9 @@ class SpringWebfluxTest extends AgentTestRunner { | |||
| "$Tags.HTTP_HOSTNAME" "localhost" | |||
| "$Tags.HTTP_METHOD" "GET" | |||
| "$Tags.HTTP_STATUS" 200 | |||
| "$Tags.HTTP_ROUTE" "$urlPathWithVariables" | |||
There was a problem hiding this comment.
actually this diff is not correctly displayed (because maybe the file has been moved). But basically before was commented out (with a BUG mention). Now is uncommented and correclty asserted
amarziali
force-pushed
the
andrea.marziali/webflux-path
branch
from
f2c3fe8 to
41b582b
Compare
amarziali
changed the title
amarziali
force-pushed
the
andrea.marziali/webflux-path
branch
from
41b582b to
ce1f653
Compare
bantonsson
reviewed
Dec 16, 2022
.../src/main/java/datadog/trace/instrumentation/springwebflux/server/RouteOnSuccessOrError.java
Outdated
Show resolved
Hide resolved
amarziali
force-pushed
the
andrea.marziali/webflux-path
branch
from
ce1f653 to
e6b8756
Compare
bantonsson
approved these changes
Dec 19, 2022
.../instrumentation/spring-webflux-5/src/bootTest/groovy/SingleThreadedSpringWebfluxTest.groovy
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
A couple of things:
@RequestMapping))Motivation
Additional Notes