Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report when we collect native stacks #4394

Merged
merged 1 commit into from
Dec 7, 2022
Merged

report when we collect native stacks #4394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...r-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/JfrProfilerSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public void publish() {
new ProfilerSettingEvent("Endpoints", String.valueOf(endpointsEnabled)).commit();
new ProfilerSettingEvent("Auxiliary Profiler", auxiliaryProfiler).commit();
new ProfilerSettingEvent("perf_events_paranoid", perfEventsParanoid).commit();
new ProfilerSettingEvent("Native Stacks", String.valueOf(hasNativeStacks)).commit();
}
}
}
8 changes: 8 additions & 0 deletions ...ng-controller/src/main/java/com/datadog/profiling/controller/ProfilerSettingsSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ public abstract class ProfilerSettingsSupport {
protected final String auxiliaryProfiler;
protected final String perfEventsParanoid;

protected final boolean hasNativeStacks;

protected ProfilerSettingsSupport() {
ConfigProvider configProvider = ConfigProvider.getInstance();
uploadPeriod =
Expand Down Expand Up @@ -73,6 +75,12 @@ protected ProfilerSettingsSupport() {
ProfilingConfig.PROFILING_AUXILIARY_TYPE,
ProfilingConfig.PROFILING_AUXILIARY_TYPE_DEFAULT);
perfEventsParanoid = readPerfEventsParanoidSetting();
hasNativeStacks =
!"no"
.equalsIgnoreCase(
configProvider.getString(
ProfilingConfig.PROFILING_ASYNC_CSTACK,
ProfilingConfig.PROFILING_ASYNC_CSTACK_DEFAULT));
}

/** To be defined in controller specific way. Eg. one could emit JFR events. */
Expand Down