Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce named presets for the resolver cache, to make it easier to configure #4408

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Dec 8, 2022

The following named presets are currently supported:

DEFAULT     # Pool sizes to fit the average sized app

LARGE       # Pool sizes to fit large enterprise apps

SMALL       # Pool sizes to fit small microservice apps

LEGACY      # Revert to the behaviour before 0.104.0

System property:

-Ddd.resolver.cache.config=LARGE

Environment variable:

DD_RESOLVER_CACHE_CONFIG=LARGE

I also adjusted the default sizes to allow for more outline types vs full types, by profiling how many outlines vs full-types were parsed for a selection of applications. (Recent changes mean we now use type outlines more than we did before.)

@mcculls mcculls added the tag: performance Performance related changes label Dec 8, 2022
@mcculls mcculls requested a review from a team as a code owner December 8, 2022 23:28
@mcculls mcculls force-pushed the mcculls/type-resolver-cache-presets branch from 7297d87 to 25837ae Compare December 9, 2022 00:31
@richardstartin
Copy link
Member

Since this will be linked to by the release notes, it might be worth adding all the options in the description.

Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 on adding the options to the PR text

@mcculls mcculls merged commit 014c630 into master Dec 9, 2022
@mcculls mcculls deleted the mcculls/type-resolver-cache-presets branch December 9, 2022 12:27
@github-actions github-actions bot added this to the 1.3.0 milestone Dec 9, 2022
@mcculls mcculls mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: performance Performance related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants