Add flag to disable sending dependencies to telemetry #4497
Conversation
dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java
Outdated
Show resolved
Hide resolved
telemetry/src/test/groovy/datadog/telemetry/DisabledDependencyServiceTest.groovy
Outdated
Show resolved
Hide resolved
DDJavierSantos
force-pushed
the
jsantos/disable_sending_dependencies
branch
from
1fe1458 to
86735fa
Compare
|
Maybe it would be good to give the customer the freedom to configure a set of artifact group IDs that they don't want to send? I agree that a flag to turn it off completely is good but a more fine grained approach might do enough to ease fears |
| Instrumentation inst = Mock() | ||
|
|
||
| void setup(){ | ||
| injectSysConfig("dd.telemetry.send.dependencies", "false") |
There was a problem hiding this comment.
Maybe dd.telemetry.dependency-collection.enabled would be better aligned with other feature enable/disable configs
There was a problem hiding this comment.
Wait a sec. This setting comes from a spec that will be the same across languages. So I would rather not diverge from it. Bringing it up with the spec authors.
There was a problem hiding this comment.
@smola I can't find anything resembling that setting when searching through our documents. Naming is hard, and it would be good if external facing user configuration followed some convention going forward.
There was a problem hiding this comment.
The spec was updated to use DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED.
@DDJavierSantos We're good to update the PR to DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED / dd.telemetry.dependency-collection.enabled.
Good point. I'll bring this up with the telemetry team. |
smola
changed the title
What Does This Do
Separating Dependencies from Telemetry Events, by disabling the DependencyService using a configuration flag.
Motivation
Currently, dependencies are sent if telemetry is enabled. The only way to stop sending dependencies was to fully disable telemetry. Introducing the
DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLED(environment variable) ordd.telemetry.dependency-collection.enabled(system property) makes it possible to disable sending dependency metadata while keeping the rest of telemetry enabled.Requirements:
DD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLEDflag is enabledDD_TELEMETRY_DEPENDENCY_COLLECTION_ENABLEDis enabled by defaultAdditional Notes