Fix log template evaluation #4623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValueScript is storing result value in a field which can be overwritten by another execution. Now the execute method returns directly the result value and ValueScript became effectively stateless regarding execution.
shatzi
approved these changes
Jan 30, 2023
| @@ -47,26 +48,10 @@ public void addStack(List<CapturedStackFrame> stack) {} | |||
|
|
|||
| @Override | |||
| public String build() { | |||
There was a problem hiding this comment.
find this method name now confusing... with this is not getMessage and executeExpressions is build?
There was a problem hiding this comment.
This is one implementation of SummaryBuilder with the original idea that we need to gather all infos about the snapshot before building the summary, hence the builder.
With LogTemplate we move the building of the summary at context adding.
If we get rid of the SnapshotSummaryBuilder we can revisit it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
ValueScript is storing result value in a field which can be overwritten by another execution. Now the execute method returns directly the result value and ValueScript became effectively stateless regarding execution.
Motivation
Bug in log template evaluation for concurrent requests
Additional Notes