-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation for Kotlin coroutines 1.5.0+ #4624
Instrumentation for Kotlin coroutines 1.5.0+ #4624
Conversation
@bantonsson would you mind to have a look since you reviewed the last one? Thanks! |
5025b6a
to
826bace
Compare
84aac35
to
b196d54
Compare
Hey @bantonsson , sorry for pinging, but I'd appreciate it a lot if we can get this merged before the next release. |
Thanks for the contribution @monosoul. I was on vacation last week, but will give this a review today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @monosoul. Would you mind squashing this as well?
Only minor nitpick. Going forward we want to try to group related instrumentations in this fashion:
:dd-java-agent:instrumentation:kotlin-coroutines
:dd-java-agent:instrumentation:kotlin-coroutines:coroutines-1.3
:dd-java-agent:instrumentation:kotlin-coroutines:coroutines-1.5
...trumentation/kotlin-coroutines-1.5/src/test/groovy/KotlinCoroutineInstrumentationTest.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: monosoul <Kloz.Klaud@gmail.com>
2489951
to
41306a3
Compare
@bantonsson squashed and refactored the submodules structure 👍 |
What Does This Do
Introduces support for coroutines 1.5.0+.
Solves #931 , Solves #1123 .
Motivation
The instrumentation I introduced in #4405 only supports Kotlin coroutines up to 1.4.3.
Additional Notes
Updates project-wide Kotlin dependency version to 1.6.21 because latest versions of coroutines require higher API level version (unfortunately Kotlin plugin for Gradle has some breaking changes in version 1.7.0, so I didn't use it here).
Introduces 3 new Gradle modules:
kotlin-coroutines-common
,kotlin-coroutines-1.3
andkotlin-coroutines-1.5
.Also configures
lastDep
test (was missing before).