activate grpc.client span in ClientCall.request and ClientCall.halfClose #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
rgs/grpc-request-context
branch
from
d4da0da to
e9962a1
Compare
richardstartin
changed the title
| named("request") | ||
| .and(isMethod()) | ||
| .and(takesArguments(int.class)) | ||
| .or(named("halfClose").and(takesArguments(0))), |
There was a problem hiding this comment.
Does the 2nd matcher also need isMethod() like the first one?
There was a problem hiding this comment.
Probably, I don't think it actually matters but I'll add it in for the sake of being thorough
richardstartin
force-pushed
the
rgs/grpc-request-context
branch
from
d76b36a to
df8e123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Activates the client span in the request method, which ensures context propagation throughout the call.
Motivation
Better profiler integration for code hotspots.
Additional Notes