Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for this as object reference in Expression Language #4641

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Feb 2, 2023

What Does This Do

Capture this object as arguments for instance method. Then can be resolved as normal object reference and be used in EL

Motivation

Be able to use this as real object reference instead of string field prefix in Expression Language

Additional Notes

@jpbempel jpbempel requested a review from a team as a code owner February 2, 2023 15:29
@jpbempel jpbempel requested review from cimi and removed request for a team February 2, 2023 15:29
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Feb 2, 2023
@jpbempel jpbempel changed the title Add support for this as object reference Add support for this as object reference in Expression Language Feb 2, 2023
@jpbempel jpbempel force-pushed the jpbempel/fix-this-handling branch 2 times, most recently from 3740391 to a5cadc3 Compare February 2, 2023 18:02
Copy link
Contributor

@cimi cimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

Assert.assertEquals(42, result);
Snapshot snapshot = assertOneSnapshot(listener);
assertEquals(
"this is log line for this={STATIC_STR=strStatic, intValue=48, doubleValue=3.14, strValue=done, strList=..., ...}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Capture `this` object as arguments for instance method.
Then can be resolved as normal object reference and be used in EL
@jpbempel jpbempel force-pushed the jpbempel/fix-this-handling branch from a5cadc3 to f5d65df Compare February 2, 2023 21:13
@jpbempel jpbempel merged commit 04b2319 into master Feb 3, 2023
@jpbempel jpbempel deleted the jpbempel/fix-this-handling branch February 3, 2023 07:55
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants