Ensure context propagation to gRPC pending calls to improve Code Hotspots for gRPC client #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
rgs/grpc-pending-calls
branch
from
ce349ef to
937a637
Compare
richardstartin
changed the title
richardstartin
force-pushed
the
rgs/grpc-pending-calls
branch
from
937a637 to
34768f0
Compare
jbachorik
approved these changes
Feb 6, 2023
richardstartin
changed the title
richardstartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This moves starting the span to
ManagedChannelImpl#newCall, which ensures there is an active span whenPendingCalls are created and reprocessed (where the real call is created) within a synchronization context, which requires whitelisting one of grpc's executors.Motivation
Better code hotspots for grpc client
Additional Notes