Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track gRPC scheduling time in SynchronizationContext #4677

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

richardstartin
Copy link
Member

What Does This Do

Tells the profiler how long gRPC requests spend scheduled in the SynchronizationContext. This work is temporary and will eventually be superseded by a generic implementation that will support any kind of asynchronous scheduling.

Motivation

Additional Notes

@richardstartin richardstartin requested a review from a team as a code owner February 7, 2023 14:32
@richardstartin richardstartin added comp: profiling Profiling inst: grpc gRPC instrumentation labels Feb 7, 2023
@richardstartin richardstartin force-pushed the rgs/grpc-sync-context branch 2 times, most recently from fc9b563 to 257f3bd Compare February 7, 2023 15:10
*/
public final class TimedRunnable implements Runnable {

private final long creationTime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we will find a better solution soon™️

Base automatically changed from rgs/queueing-time to master February 7, 2023 16:48
@richardstartin richardstartin merged commit b4d2c64 into master Feb 7, 2023
@richardstartin richardstartin deleted the rgs/grpc-sync-context branch February 7, 2023 19:10
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 7, 2023
@richardstartin richardstartin added the tag: no release notes Changes to exclude from release notes label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: profiling Profiling inst: grpc gRPC instrumentation tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants