-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC disable tracing via remote-config #6731
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing span creation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 14 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~eafff70116, baseline=1.31.0-SNAPSHOT~6167d5efc0
dateFormat X
axisFormat %s
section baseline
no_agent (374.238 µs) : 353, 395
. : milestone, 374,
iast (479.522 µs) : 459, 500
. : milestone, 480,
iast_FULL (550.415 µs) : 530, 571
. : milestone, 550,
iast_GLOBAL (498.578 µs) : 477, 520
. : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (484.385 µs) : 463, 506
. : milestone, 484,
iast_INACTIVE (459.915 µs) : 439, 481
. : milestone, 460,
iast_TELEMETRY_OFF (473.74 µs) : 453, 494
. : milestone, 474,
tracing (452.096 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (366.548 µs) : 347, 386
. : milestone, 367,
iast (486.562 µs) : 466, 508
. : milestone, 487,
iast_FULL (544.36 µs) : 524, 565
. : milestone, 544,
iast_GLOBAL (506.195 µs) : 484, 528
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (485.474 µs) : 465, 506
. : milestone, 485,
iast_INACTIVE (458.94 µs) : 438, 480
. : milestone, 459,
iast_TELEMETRY_OFF (477.911 µs) : 457, 499
. : milestone, 478,
tracing (451.462 µs) : 431, 472
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~eafff70116, baseline=1.31.0-SNAPSHOT~6167d5efc0
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1342, 1380
. : milestone, 1361,
appsec (1.775 ms) : 1751, 1798
. : milestone, 1775,
iast (1.543 ms) : 1520, 1567
. : milestone, 1543,
profiling (1.516 ms) : 1491, 1540
. : milestone, 1516,
tracing (1.53 ms) : 1507, 1553
. : milestone, 1530,
section candidate
no_agent (1.367 ms) : 1348, 1386
. : milestone, 1367,
appsec (1.795 ms) : 1771, 1819
. : milestone, 1795,
iast (1.554 ms) : 1531, 1578
. : milestone, 1554,
profiling (1.59 ms) : 1565, 1614
. : milestone, 1590,
tracing (1.511 ms) : 1488, 1535
. : milestone, 1511,
|
These changes have been implemented in #6827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR implements tracing disabling by stopping trace publishing but keeping span creation.
This change satisfies one of the `TestDynamicConfigTracingEnabled' system test scenarios where tracing is initially enabled and then disabled via remote config.
Motivation
In-app APM Service Disablement RFC
Additional Notes
Jira ticket: APMJAVA-1248