Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log file if size is not too big #6993

Merged
merged 5 commits into from
May 13, 2024
Merged

Add log file if size is not too big #6993

merged 5 commits into from
May 13, 2024

Conversation

cecile75
Copy link
Collaborator

@cecile75 cecile75 commented May 6, 2024 •
edited by jira bot
Loading

What Does This Do

Add tracer log file to tracer flare, requested by the UI or by Triage mode:

  • if a tracer log file has been defined with datadog.slf4j.simpleLogger.logFile
  • and if the size of the tracer log file is < 15MB

Motivation

Getting tracer logs in tracer flare to get as much information as possible to better troubleshoot issues

Additional Notes

This is only a Draft

Jira ticket: APMAPI-32

@pr-commenter
Copy link

pr-commenter bot commented May 7, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/tracer_debugfile
git_commit_date 1715279552 1715339869
git_commit_sha 6df14c1 47112ba
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.35.0-SNAPSHOT~47112bab0b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715342471 1715342471
ci_job_id 508709148 508709148
ci_pipeline_id 34022425 34022425
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078175
Total [baseline] (10.543 s) : 0, 10542593
Agent [candidate] (1.078 s) : 0, 1077737
Total [candidate] (10.485 s) : 0, 10484861
section appsec
Agent [baseline] (1.195 s) : 0, 1195170
Total [baseline] (10.457 s) : 0, 10456576
Agent [candidate] (1.201 s) : 0, 1200697
Total [candidate] (10.508 s) : 0, 10507771
section iast
Agent [baseline] (1.202 s) : 0, 1201926
Total [baseline] (10.754 s) : 0, 10754134
Agent [candidate] (1.211 s) : 0, 1211434
Total [candidate] (10.82 s) : 0, 10819924
section profiling
Agent [baseline] (1.276 s) : 0, 1276429
Total [baseline] (10.68 s) : 0, 10680244
Agent [candidate] (1.273 s) : 0, 1272914
Total [candidate] (10.603 s) : 0, 10602845
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.195 s 116.995 ms (10.9%)
Agent iast 1.202 s 123.751 ms (11.5%)
Agent profiling 1.276 s 198.254 ms (18.4%)
Total tracing 10.543 s -
Total appsec 10.457 s -86.017 ms (-0.8%)
Total iast 10.754 s 211.542 ms (2.0%)
Total profiling 10.68 s 137.651 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.201 s 122.961 ms (11.4%)
Agent iast 1.211 s 133.697 ms (12.4%)
Agent profiling 1.273 s 195.178 ms (18.1%)
Total tracing 10.485 s -
Total appsec 10.508 s 22.91 ms (0.2%)
Total iast 10.82 s 335.063 ms (3.2%)
Total profiling 10.603 s 117.983 ms (1.1%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.25 ms) : 0, 675250
BytebuddyAgent [candidate] (673.909 ms) : 0, 673909
GlobalTracer [baseline] (310.684 ms) : 0, 310684
GlobalTracer [candidate] (311.646 ms) : 0, 311646
AppSec [baseline] (49.414 ms) : 0, 49414
AppSec [candidate] (49.535 ms) : 0, 49535
Remote Config [baseline] (664.154 µs) : 0, 664
Remote Config [candidate] (659.784 µs) : 0, 660
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.611 ms) : 0, 7611
section appsec
BytebuddyAgent [baseline] (697.906 ms) : 0, 697906
BytebuddyAgent [candidate] (701.463 ms) : 0, 701463
GlobalTracer [baseline] (294.641 ms) : 0, 294641
GlobalTracer [candidate] (295.905 ms) : 0, 295905
AppSec [baseline] (149.48 ms) : 0, 149480
AppSec [candidate] (150.08 ms) : 0, 150080
IAST [baseline] (19.341 ms) : 0, 19341
IAST [candidate] (19.561 ms) : 0, 19561
Remote Config [baseline] (617.325 µs) : 0, 617
Remote Config [candidate] (622.408 µs) : 0, 622
Telemetry [baseline] (8.464 ms) : 0, 8464
Telemetry [candidate] (8.188 ms) : 0, 8188
section iast
BytebuddyAgent [baseline] (795.397 ms) : 0, 795397
BytebuddyAgent [candidate] (800.602 ms) : 0, 800602
GlobalTracer [baseline] (290.86 ms) : 0, 290860
GlobalTracer [candidate] (293.074 ms) : 0, 293074
AppSec [baseline] (50.834 ms) : 0, 50834
AppSec [candidate] (49.876 ms) : 0, 49876
IAST [baseline] (23.308 ms) : 0, 23308
IAST [candidate] (26.133 ms) : 0, 26133
Remote Config [baseline] (582.567 µs) : 0, 583
Remote Config [candidate] (596.422 µs) : 0, 596
Telemetry [baseline] (6.616 ms) : 0, 6616
Telemetry [candidate] (6.601 ms) : 0, 6601
section profiling
BytebuddyAgent [baseline] (682.191 ms) : 0, 682191
BytebuddyAgent [candidate] (679.606 ms) : 0, 679606
GlobalTracer [baseline] (382.28 ms) : 0, 382280
GlobalTracer [candidate] (382.223 ms) : 0, 382223
AppSec [baseline] (50.474 ms) : 0, 50474
AppSec [candidate] (50.1 ms) : 0, 50100
Remote Config [baseline] (709.887 µs) : 0, 710
Remote Config [candidate] (711.006 µs) : 0, 711
Telemetry [baseline] (7.57 ms) : 0, 7570
Telemetry [candidate] (7.51 ms) : 0, 7510
ProfilingAgent [baseline] (96.372 ms) : 0, 96372
ProfilingAgent [candidate] (96.196 ms) : 0, 96196
Profiling [baseline] (96.396 ms) : 0, 96396
Profiling [candidate] (96.221 ms) : 0, 96221
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085192
Total [baseline] (8.543 s) : 0, 8543443
Agent [candidate] (1.084 s) : 0, 1084291
Total [candidate] (8.563 s) : 0, 8562903
section iast
Agent [baseline] (1.212 s) : 0, 1212264
Total [baseline] (9.017 s) : 0, 9016695
Agent [candidate] (1.203 s) : 0, 1203257
Total [candidate] (9.02 s) : 0, 9019620
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1201672
Total [baseline] (8.979 s) : 0, 8978877
Agent [candidate] (1.204 s) : 0, 1203871
Total [candidate] (8.981 s) : 0, 8981003
section iast_TELEMETRY_OFF
Agent [baseline] (1.219 s) : 0, 1218546
Total [baseline] (9.025 s) : 0, 9024636
Agent [candidate] (1.208 s) : 0, 1208281
Total [candidate] (9.066 s) : 0, 9065807
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.212 s 127.072 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 116.48 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.219 s 133.354 ms (12.3%)
Total tracing 8.543 s -
Total iast 9.017 s 473.252 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.979 s 435.434 ms (5.1%)
Total iast_TELEMETRY_OFF 9.025 s 481.193 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.203 s 118.967 ms (11.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 119.58 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.208 s 123.991 ms (11.4%)
Total tracing 8.563 s -
Total iast 9.02 s 456.717 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.981 s 418.099 ms (4.9%)
Total iast_TELEMETRY_OFF 9.066 s 502.903 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.545 ms) : 0, 679545
BytebuddyAgent [candidate] (678.405 ms) : 0, 678405
GlobalTracer [baseline] (312.921 ms) : 0, 312921
GlobalTracer [candidate] (313.03 ms) : 0, 313030
AppSec [baseline] (49.768 ms) : 0, 49768
AppSec [candidate] (49.987 ms) : 0, 49987
Remote Config [baseline] (659.869 µs) : 0, 660
Remote Config [candidate] (680.977 µs) : 0, 681
Telemetry [baseline] (7.636 ms) : 0, 7636
Telemetry [candidate] (7.641 ms) : 0, 7641
section iast
BytebuddyAgent [baseline] (802.231 ms) : 0, 802231
BytebuddyAgent [candidate] (795.052 ms) : 0, 795052
GlobalTracer [baseline] (293.219 ms) : 0, 293219
GlobalTracer [candidate] (291.359 ms) : 0, 291359
AppSec [baseline] (50.533 ms) : 0, 50533
AppSec [candidate] (49.558 ms) : 0, 49558
Remote Config [baseline] (587.506 µs) : 0, 588
Remote Config [candidate] (606.797 µs) : 0, 607
Telemetry [baseline] (6.62 ms) : 0, 6620
Telemetry [candidate] (6.596 ms) : 0, 6596
IAST [baseline] (24.475 ms) : 0, 24475
IAST [candidate] (25.852 ms) : 0, 25852
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.938 ms) : 0, 793938
BytebuddyAgent [candidate] (794.816 ms) : 0, 794816
GlobalTracer [baseline] (290.821 ms) : 0, 290821
GlobalTracer [candidate] (291.206 ms) : 0, 291206
AppSec [baseline] (50.323 ms) : 0, 50323
AppSec [candidate] (50.712 ms) : 0, 50712
Remote Config [baseline] (2.066 ms) : 0, 2066
Remote Config [candidate] (596.916 µs) : 0, 597
Telemetry [baseline] (6.665 ms) : 0, 6665
Telemetry [candidate] (6.558 ms) : 0, 6558
IAST [baseline] (23.561 ms) : 0, 23561
IAST [candidate] (25.415 ms) : 0, 25415
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.749 ms) : 0, 804749
BytebuddyAgent [candidate] (798.498 ms) : 0, 798498
GlobalTracer [baseline] (295.081 ms) : 0, 295081
GlobalTracer [candidate] (292.895 ms) : 0, 292895
AppSec [baseline] (49.769 ms) : 0, 49769
AppSec [candidate] (49.97 ms) : 0, 49970
Remote Config [baseline] (632.673 µs) : 0, 633
Remote Config [candidate] (606.641 µs) : 0, 607
Telemetry [baseline] (7.435 ms) : 0, 7435
Telemetry [candidate] (7.417 ms) : 0, 7417
IAST [baseline] (25.995 ms) : 0, 25995
IAST [candidate] (24.366 ms) : 0, 24366
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-10T11:29:58 2024-05-10T11:36:42
git_branch master cecile/tracer_debugfile
git_commit_date 1715279552 1715339869
git_commit_sha 6df14c1 47112ba
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.35.0-SNAPSHOT~47112bab0b
start_time 2024-05-10T11:29:45 2024-05-10T11:36:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715341345 1715341345
ci_job_id 508709149 508709149
ci_pipeline_id 34022425 34022425
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+46.340µs; +99.829µs] or [+3.127%; +6.737%]		 unstable
[-722.258op/s; +494.338op/s] or [-23.473%; +16.066%]		 1.555ms 2962.963op/s 1.482ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.936 µs) : 346, 386
.   : milestone, 366,
iast (465.768 µs) : 445, 487
.   : milestone, 466,
iast_FULL (535.908 µs) : 515, 557
.   : milestone, 536,
iast_GLOBAL (493.523 µs) : 472, 515
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (462.819 µs) : 442, 483
.   : milestone, 463,
iast_INACTIVE (437.976 µs) : 418, 458
.   : milestone, 438,
iast_TELEMETRY_OFF (465.158 µs) : 444, 486
.   : milestone, 465,
tracing (439.074 µs) : 418, 460
.   : milestone, 439,
section candidate
no_agent (364.093 µs) : 344, 384
.   : milestone, 364,
iast (471.036 µs) : 450, 492
.   : milestone, 471,
iast_FULL (530.247 µs) : 509, 551
.   : milestone, 530,
iast_GLOBAL (494.777 µs) : 473, 516
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (465.304 µs) : 445, 485
.   : milestone, 465,
iast_INACTIVE (443.508 µs) : 423, 464
.   : milestone, 444,
iast_TELEMETRY_OFF (464.354 µs) : 443, 486
.   : milestone, 464,
tracing (441.61 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.936 µs [345.849 µs, 386.023 µs] -
iast 465.768 µs [444.755 µs, 486.781 µs] 99.832 µs (27.3%)
iast_FULL 535.908 µs [515.287 µs, 556.53 µs] 169.972 µs (46.4%)
iast_GLOBAL 493.523 µs [471.649 µs, 515.396 µs] 127.587 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED 462.819 µs [442.373 µs, 483.265 µs] 96.883 µs (26.5%)
iast_INACTIVE 437.976 µs [417.589 µs, 458.363 µs] 72.04 µs (19.7%)
iast_TELEMETRY_OFF 465.158 µs [444.197 µs, 486.12 µs] 99.222 µs (27.1%)
tracing 439.074 µs [418.49 µs, 459.658 µs] 73.138 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.093 µs [344.065 µs, 384.12 µs] -
iast 471.036 µs [449.655 µs, 492.417 µs] 106.943 µs (29.4%)
iast_FULL 530.247 µs [509.349 µs, 551.145 µs] 166.154 µs (45.6%)
iast_GLOBAL 494.777 µs [473.238 µs, 516.316 µs] 130.684 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 465.304 µs [445.127 µs, 485.481 µs] 101.211 µs (27.8%)
iast_INACTIVE 443.508 µs [422.95 µs, 464.065 µs] 79.415 µs (21.8%)
iast_TELEMETRY_OFF 464.354 µs [442.734 µs, 485.974 µs] 100.261 µs (27.5%)
tracing 441.61 µs [420.904 µs, 462.316 µs] 77.517 µs (21.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.336 ms) : 1316, 1356
.   : milestone, 1336,
appsec (1.712 ms) : 1688, 1735
.   : milestone, 1712,
appsec_no_iast (1.693 ms) : 1668, 1718
.   : milestone, 1693,
iast (1.461 ms) : 1438, 1484
.   : milestone, 1461,
profiling (1.482 ms) : 1458, 1505
.   : milestone, 1482,
tracing (1.465 ms) : 1442, 1489
.   : milestone, 1465,
section candidate
no_agent (1.354 ms) : 1333, 1374
.   : milestone, 1354,
appsec (1.704 ms) : 1680, 1727
.   : milestone, 1704,
appsec_no_iast (1.694 ms) : 1669, 1719
.   : milestone, 1694,
iast (1.471 ms) : 1447, 1494
.   : milestone, 1471,
profiling (1.555 ms) : 1529, 1581
.   : milestone, 1555,
tracing (1.473 ms) : 1449, 1496
.   : milestone, 1473,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.316 ms, 1.356 ms] -
appsec 1.712 ms [1.688 ms, 1.735 ms] 375.861 µs (28.1%)
appsec_no_iast 1.693 ms [1.668 ms, 1.718 ms] 357.243 µs (26.7%)
iast 1.461 ms [1.438 ms, 1.484 ms] 125.653 µs (9.4%)
profiling 1.482 ms [1.458 ms, 1.505 ms] 146.006 µs (10.9%)
tracing 1.465 ms [1.442 ms, 1.489 ms] 129.279 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.333 ms, 1.374 ms] -
appsec 1.704 ms [1.68 ms, 1.727 ms] 350.373 µs (25.9%)
appsec_no_iast 1.694 ms [1.669 ms, 1.719 ms] 340.38 µs (25.1%)
iast 1.471 ms [1.447 ms, 1.494 ms] 117.09 µs (8.7%)
profiling 1.555 ms [1.529 ms, 1.581 ms] 201.267 µs (14.9%)
tracing 1.473 ms [1.449 ms, 1.496 ms] 119.194 µs (8.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/tracer_debugfile
git_commit_date 1715279552 1715339869
git_commit_sha 6df14c1 47112ba
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.35.0-SNAPSHOT~47112bab0b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715341843 1715341843
ci_job_id 508709150 508709150
ci_pipeline_id 34022425 34022425
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.419 s) : 15419000, 15419000
.   : milestone, 15419000,
appsec (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
iast (18.983 s) : 18983000, 18983000
.   : milestone, 18983000,
iast_GLOBAL (17.761 s) : 17761000, 17761000
.   : milestone, 17761000,
profiling (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
tracing (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
section candidate
no_agent (15.342 s) : 15342000, 15342000
.   : milestone, 15342000,
appsec (14.76 s) : 14760000, 14760000
.   : milestone, 14760000,
iast (18.747 s) : 18747000, 18747000
.   : milestone, 18747000,
iast_GLOBAL (17.787 s) : 17787000, 17787000
.   : milestone, 17787000,
profiling (15.376 s) : 15376000, 15376000
.   : milestone, 15376000,
tracing (14.791 s) : 14791000, 14791000
.   : milestone, 14791000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.419 s [15.419 s, 15.419 s] -
appsec 14.999 s [14.999 s, 14.999 s] -420.0 ms (-2.7%)
iast 18.983 s [18.983 s, 18.983 s] 3.564 s (23.1%)
iast_GLOBAL 17.761 s [17.761 s, 17.761 s] 2.342 s (15.2%)
profiling 15.279 s [15.279 s, 15.279 s] -140.0 ms (-0.9%)
tracing 14.963 s [14.963 s, 14.963 s] -456.0 ms (-3.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.342 s [15.342 s, 15.342 s] -
appsec 14.76 s [14.76 s, 14.76 s] -582.0 ms (-3.8%)
iast 18.747 s [18.747 s, 18.747 s] 3.405 s (22.2%)
iast_GLOBAL 17.787 s [17.787 s, 17.787 s] 2.445 s (15.9%)
profiling 15.376 s [15.376 s, 15.376 s] 34.0 ms (0.2%)
tracing 14.791 s [14.791 s, 14.791 s] -551.0 ms (-3.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~47112bab0b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1481
.   : milestone, 1469,
appsec (2.192 ms) : 2157, 2226
.   : milestone, 2192,
iast (1.873 ms) : 1838, 1907
.   : milestone, 1873,
iast_GLOBAL (1.912 ms) : 1877, 1947
.   : milestone, 1912,
profiling (1.852 ms) : 1818, 1885
.   : milestone, 1852,
tracing (1.835 ms) : 1803, 1867
.   : milestone, 1835,
section candidate
no_agent (1.461 ms) : 1450, 1472
.   : milestone, 1461,
appsec (2.199 ms) : 2165, 2233
.   : milestone, 2199,
iast (1.887 ms) : 1851, 1923
.   : milestone, 1887,
iast_GLOBAL (1.924 ms) : 1889, 1960
.   : milestone, 1924,
profiling (1.842 ms) : 1810, 1874
.   : milestone, 1842,
tracing (1.825 ms) : 1794, 1857
.   : milestone, 1825,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.481 ms] -
appsec 2.192 ms [2.157 ms, 2.226 ms] 722.653 µs (49.2%)
iast 1.873 ms [1.838 ms, 1.907 ms] 403.667 µs (27.5%)
iast_GLOBAL 1.912 ms [1.877 ms, 1.947 ms] 442.845 µs (30.1%)
profiling 1.852 ms [1.818 ms, 1.885 ms] 382.621 µs (26.0%)
tracing 1.835 ms [1.803 ms, 1.867 ms] 366.02 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.45 ms, 1.472 ms] -
appsec 2.199 ms [2.165 ms, 2.233 ms] 737.699 µs (50.5%)
iast 1.887 ms [1.851 ms, 1.923 ms] 426.242 µs (29.2%)
iast_GLOBAL 1.924 ms [1.889 ms, 1.96 ms] 463.164 µs (31.7%)
profiling 1.842 ms [1.81 ms, 1.874 ms] 381.004 µs (26.1%)
tracing 1.825 ms [1.794 ms, 1.857 ms] 364.491 µs (24.9%)

@cecile75 cecile75 force-pushed the cecile/tracer_debugfile branch from 8e3ea7e to 47112ba Compare May 10, 2024 11:17
@cecile75 cecile75 marked this pull request as ready for review May 10, 2024 11:18
@cecile75 cecile75 requested a review from a team as a code owner May 10, 2024 11:18
@cecile75 cecile75 requested review from dougqh and nayeem-kamal May 10, 2024 11:18
@PerfectSlayer
Copy link
Contributor

This is only a Draft

image

If you need to iterate on development (including running the CI) while not triggering review requests, there is a button in GitHub for it 👍

@smola smola changed the title Add log file if size is not to big Add log file if size is not too big May 13, 2024
@cecile75 cecile75 merged commit 0946fa5 into master May 13, 2024
80 checks passed
@cecile75 cecile75 deleted the cecile/tracer_debugfile branch May 13, 2024 09:38
@github-actions github-actions bot added this to the 1.35.0 milestone May 13, 2024
@cecile75 cecile75 mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougqh dougqh dougqh approved these changes

@mcculls mcculls mcculls approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: telemetry Telemetry type: enhancement
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cecile75 @PerfectSlayer @mcculls @dougqh