Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ddprof to 1.7.0 #7033

Merged
merged 1 commit into from
May 15, 2024
Merged

Upgrade ddprof to 1.7.0 #7033

merged 1 commit into from
May 15, 2024

Conversation

richardstartin
Copy link
Member

What Does This Do

Upgrades profiler to 1.7.0, details here

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@richardstartin richardstartin requested a review from a team as a code owner May 15, 2024 13:00
@richardstartin richardstartin requested review from mcculls, ygree and jbachorik and removed request for a team, mcculls and ygree May 15, 2024 13:00
@pr-commenter
Copy link

pr-commenter bot commented May 15, 2024

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-15T13:17:18 2024-05-15T13:24:06
git_branch master rgs/upgrade-ddprof-1.7.0
git_commit_date 1715767906 1715777948
git_commit_sha 4402123 7fa33a5
release_version 1.35.0-SNAPSHOT~440212338d 1.35.0-SNAPSHOT~7fa33a5101
start_time 2024-05-15T13:17:05 2024-05-15T13:23:53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715779791 1715779791
ci_job_id 512799546 512799546
ci_pipeline_id 34352763 34352763
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~7fa33a5101, baseline=1.35.0-SNAPSHOT~440212338d
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.421 µs) : 346, 385
.   : milestone, 365,
iast (479.814 µs) : 458, 501
.   : milestone, 480,
iast_FULL (542.668 µs) : 522, 564
.   : milestone, 543,
iast_GLOBAL (495.789 µs) : 475, 517
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (474.45 µs) : 453, 496
.   : milestone, 474,
iast_INACTIVE (452.37 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (470.534 µs) : 449, 492
.   : milestone, 471,
tracing (440.738 µs) : 420, 462
.   : milestone, 441,
section candidate
no_agent (358.955 µs) : 339, 379
.   : milestone, 359,
iast (475.587 µs) : 455, 497
.   : milestone, 476,
iast_FULL (547.597 µs) : 526, 569
.   : milestone, 548,
iast_GLOBAL (507.869 µs) : 486, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (475.322 µs) : 454, 497
.   : milestone, 475,
iast_INACTIVE (455.175 µs) : 433, 478
.   : milestone, 455,
iast_TELEMETRY_OFF (468.156 µs) : 447, 489
.   : milestone, 468,
tracing (442.966 µs) : 422, 464
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.421 µs [346.243 µs, 384.599 µs] -
iast 479.814 µs [458.327 µs, 501.302 µs] 114.394 µs (31.3%)
iast_FULL 542.668 µs [521.556 µs, 563.781 µs] 177.248 µs (48.5%)
iast_GLOBAL 495.789 µs [474.983 µs, 516.596 µs] 130.368 µs (35.7%)
iast_HARDCODED_SECRET_DISABLED 474.45 µs [453.395 µs, 495.505 µs] 109.03 µs (29.8%)
iast_INACTIVE 452.37 µs [431.416 µs, 473.324 µs] 86.949 µs (23.8%)
iast_TELEMETRY_OFF 470.534 µs [449.081 µs, 491.987 µs] 105.114 µs (28.8%)
tracing 440.738 µs [419.756 µs, 461.72 µs] 75.317 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.955 µs [339.325 µs, 378.585 µs] -
iast 475.587 µs [454.598 µs, 496.575 µs] 116.632 µs (32.5%)
iast_FULL 547.597 µs [526.469 µs, 568.725 µs] 188.642 µs (52.6%)
iast_GLOBAL 507.869 µs [485.793 µs, 529.945 µs] 148.914 µs (41.5%)
iast_HARDCODED_SECRET_DISABLED 475.322 µs [453.995 µs, 496.648 µs] 116.367 µs (32.4%)
iast_INACTIVE 455.175 µs [432.652 µs, 477.698 µs] 96.22 µs (26.8%)
iast_TELEMETRY_OFF 468.156 µs [446.864 µs, 489.448 µs] 109.201 µs (30.4%)
tracing 442.966 µs [421.622 µs, 464.31 µs] 84.011 µs (23.4%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~7fa33a5101, baseline=1.35.0-SNAPSHOT~440212338d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1318, 1358
.   : milestone, 1338,
appsec (1.722 ms) : 1699, 1746
.   : milestone, 1722,
appsec_no_iast (1.727 ms) : 1703, 1750
.   : milestone, 1727,
iast (1.476 ms) : 1453, 1499
.   : milestone, 1476,
profiling (1.496 ms) : 1469, 1522
.   : milestone, 1496,
tracing (1.484 ms) : 1460, 1508
.   : milestone, 1484,
section candidate
no_agent (1.346 ms) : 1327, 1366
.   : milestone, 1346,
appsec (1.724 ms) : 1700, 1748
.   : milestone, 1724,
appsec_no_iast (1.737 ms) : 1713, 1761
.   : milestone, 1737,
iast (1.471 ms) : 1448, 1493
.   : milestone, 1471,
profiling (1.462 ms) : 1437, 1487
.   : milestone, 1462,
tracing (1.452 ms) : 1427, 1476
.   : milestone, 1452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.358 ms] -
appsec 1.722 ms [1.699 ms, 1.746 ms] 384.141 µs (28.7%)
appsec_no_iast 1.727 ms [1.703 ms, 1.75 ms] 388.582 µs (29.0%)
iast 1.476 ms [1.453 ms, 1.499 ms] 137.809 µs (10.3%)
profiling 1.496 ms [1.469 ms, 1.522 ms] 157.369 µs (11.8%)
tracing 1.484 ms [1.46 ms, 1.508 ms] 145.564 µs (10.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.366 ms] -
appsec 1.724 ms [1.7 ms, 1.748 ms] 377.631 µs (28.0%)
appsec_no_iast 1.737 ms [1.713 ms, 1.761 ms] 390.445 µs (29.0%)
iast 1.471 ms [1.448 ms, 1.493 ms] 124.212 µs (9.2%)
profiling 1.462 ms [1.437 ms, 1.487 ms] 115.545 µs (8.6%)
tracing 1.452 ms [1.427 ms, 1.476 ms] 105.485 µs (7.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master rgs/upgrade-ddprof-1.7.0
git_commit_date 1715767906 1715777948
git_commit_sha 4402123 7fa33a5
release_version 1.35.0-SNAPSHOT~440212338d 1.35.0-SNAPSHOT~7fa33a5101
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715780307 1715780307
ci_job_id 512799547 512799547
ci_pipeline_id 34352763 34352763
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~7fa33a5101, baseline=1.35.0-SNAPSHOT~440212338d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.145 s) : 15145000, 15145000
.   : milestone, 15145000,
appsec (14.924 s) : 14924000, 14924000
.   : milestone, 14924000,
iast (18.615 s) : 18615000, 18615000
.   : milestone, 18615000,
iast_GLOBAL (17.841 s) : 17841000, 17841000
.   : milestone, 17841000,
profiling (15.238 s) : 15238000, 15238000
.   : milestone, 15238000,
tracing (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
section candidate
no_agent (15.445 s) : 15445000, 15445000
.   : milestone, 15445000,
appsec (14.753 s) : 14753000, 14753000
.   : milestone, 14753000,
iast (18.974 s) : 18974000, 18974000
.   : milestone, 18974000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
.   : milestone, 17877000,
profiling (15.943 s) : 15943000, 15943000
.   : milestone, 15943000,
tracing (14.956 s) : 14956000, 14956000
.   : milestone, 14956000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.145 s [15.145 s, 15.145 s] -
appsec 14.924 s [14.924 s, 14.924 s] -221.0 ms (-1.5%)
iast 18.615 s [18.615 s, 18.615 s] 3.47 s (22.9%)
iast_GLOBAL 17.841 s [17.841 s, 17.841 s] 2.696 s (17.8%)
profiling 15.238 s [15.238 s, 15.238 s] 93.0 ms (0.6%)
tracing 14.957 s [14.957 s, 14.957 s] -188.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.445 s [15.445 s, 15.445 s] -
appsec 14.753 s [14.753 s, 14.753 s] -692.0 ms (-4.5%)
iast 18.974 s [18.974 s, 18.974 s] 3.529 s (22.8%)
iast_GLOBAL 17.877 s [17.877 s, 17.877 s] 2.432 s (15.7%)
profiling 15.943 s [15.943 s, 15.943 s] 498.0 ms (3.2%)
tracing 14.956 s [14.956 s, 14.956 s] -489.0 ms (-3.2%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~7fa33a5101, baseline=1.35.0-SNAPSHOT~440212338d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.198 ms) : 2164, 2232
.   : milestone, 2198,
iast (1.958 ms) : 1917, 1998
.   : milestone, 1958,
iast_GLOBAL (2.002 ms) : 1961, 2043
.   : milestone, 2002,
profiling (1.864 ms) : 1831, 1897
.   : milestone, 1864,
tracing (1.831 ms) : 1799, 1864
.   : milestone, 1831,
section candidate
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.214 ms) : 2180, 2248
.   : milestone, 2214,
iast (1.978 ms) : 1936, 2019
.   : milestone, 1978,
iast_GLOBAL (1.992 ms) : 1952, 2033
.   : milestone, 1992,
profiling (1.848 ms) : 1814, 1882
.   : milestone, 1848,
tracing (1.829 ms) : 1797, 1860
.   : milestone, 1829,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.198 ms [2.164 ms, 2.232 ms] 731.983 µs (49.9%)
iast 1.958 ms [1.917 ms, 1.998 ms] 491.784 µs (33.5%)
iast_GLOBAL 2.002 ms [1.961 ms, 2.043 ms] 536.129 µs (36.6%)
profiling 1.864 ms [1.831 ms, 1.897 ms] 398.362 µs (27.2%)
tracing 1.831 ms [1.799 ms, 1.864 ms] 365.267 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.214 ms [2.18 ms, 2.248 ms] 750.612 µs (51.3%)
iast 1.978 ms [1.936 ms, 2.019 ms] 514.452 µs (35.2%)
iast_GLOBAL 1.992 ms [1.952 ms, 2.033 ms] 528.824 µs (36.1%)
profiling 1.848 ms [1.814 ms, 1.882 ms] 384.637 µs (26.3%)
tracing 1.829 ms [1.797 ms, 1.86 ms] 365.276 µs (25.0%)

@richardstartin richardstartin merged commit 6e42055 into master May 15, 2024
82 checks passed
@richardstartin richardstartin deleted the rgs/upgrade-ddprof-1.7.0 branch May 15, 2024 15:27
@github-actions github-actions bot added this to the 1.35.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants