Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support micronaut 4.x #7035

Merged
merged 1 commit into from
May 17, 2024
Merged

Support micronaut 4.x #7035

merged 1 commit into from
May 17, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Add support for micronaut 4.x

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added the inst: others All other instrumentations label May 15, 2024
@amarziali amarziali requested review from a team as code owners May 15, 2024 14:58
@amarziali amarziali requested review from dougqh and nayeem-kamal May 15, 2024 14:58
@pr-commenter
Copy link

pr-commenter bot commented May 15, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/micronaut-4
git_commit_date 1715851940 1715852272
git_commit_sha 2edfc5e 3244c4c
release_version 1.35.0-SNAPSHOT~2edfc5eeb1 1.35.0-SNAPSHOT~3244c4c489
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715854867 1715854867
ci_job_id 513807942 513807942
ci_pipeline_id 34433122 34433122
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076412
Total [baseline] (8.557 s) : 0, 8557076
Agent [candidate] (1.076 s) : 0, 1075796
Total [candidate] (8.598 s) : 0, 8597609
section iast
Agent [baseline] (1.206 s) : 0, 1206076
Total [baseline] (9.036 s) : 0, 9035608
Agent [candidate] (1.205 s) : 0, 1204503
Total [candidate] (9.035 s) : 0, 9035323
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1207210
Total [baseline] (9.049 s) : 0, 9048926
Agent [candidate] (1.212 s) : 0, 1212391
Total [candidate] (9.024 s) : 0, 9024074
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1200272
Total [baseline] (9.006 s) : 0, 9006289
Agent [candidate] (1.203 s) : 0, 1203180
Total [candidate] (9.015 s) : 0, 9014648
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.206 s 129.664 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.207 s 130.797 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.2 s 123.86 ms (11.5%)
Total tracing 8.557 s -
Total iast 9.036 s 478.532 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.049 s 491.85 ms (5.7%)
Total iast_TELEMETRY_OFF 9.006 s 449.213 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.205 s 128.707 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.212 s 136.595 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.203 s 127.384 ms (11.8%)
Total tracing 8.598 s -
Total iast 9.035 s 437.713 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.024 s 426.464 ms (5.0%)
Total iast_TELEMETRY_OFF 9.015 s 417.039 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.011 ms) : 0, 674011
BytebuddyAgent [candidate] (673.457 ms) : 0, 673457
GlobalTracer [baseline] (310.175 ms) : 0, 310175
GlobalTracer [candidate] (310.478 ms) : 0, 310478
AppSec [baseline] (49.729 ms) : 0, 49729
AppSec [candidate] (49.39 ms) : 0, 49390
Remote Config [baseline] (657.74 µs) : 0, 658
Remote Config [candidate] (658.709 µs) : 0, 659
Telemetry [baseline] (7.564 ms) : 0, 7564
Telemetry [candidate] (7.589 ms) : 0, 7589
section iast
BytebuddyAgent [baseline] (798.042 ms) : 0, 798042
BytebuddyAgent [candidate] (796.971 ms) : 0, 796971
GlobalTracer [baseline] (291.149 ms) : 0, 291149
GlobalTracer [candidate] (291.151 ms) : 0, 291151
AppSec [baseline] (48.086 ms) : 0, 48086
AppSec [candidate] (50.485 ms) : 0, 50485
IAST [baseline] (27.127 ms) : 0, 27127
IAST [candidate] (23.607 ms) : 0, 23607
Remote Config [baseline] (643.286 µs) : 0, 643
Remote Config [candidate] (585.562 µs) : 0, 586
Telemetry [baseline] (6.637 ms) : 0, 6637
Telemetry [candidate] (7.378 ms) : 0, 7378
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.235 ms) : 0, 799235
BytebuddyAgent [candidate] (802.725 ms) : 0, 802725
GlobalTracer [baseline] (291.551 ms) : 0, 291551
GlobalTracer [candidate] (293.07 ms) : 0, 293070
AppSec [baseline] (51.513 ms) : 0, 51513
AppSec [candidate] (50.351 ms) : 0, 50351
IAST [baseline] (23.091 ms) : 0, 23091
IAST [candidate] (24.384 ms) : 0, 24384
Remote Config [baseline] (594.066 µs) : 0, 594
Remote Config [candidate] (614.936 µs) : 0, 615
Telemetry [baseline] (6.688 ms) : 0, 6688
Telemetry [candidate] (6.62 ms) : 0, 6620
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.439 ms) : 0, 793439
BytebuddyAgent [candidate] (795.123 ms) : 0, 795123
GlobalTracer [baseline] (291.022 ms) : 0, 291022
GlobalTracer [candidate] (292.025 ms) : 0, 292025
AppSec [baseline] (51.647 ms) : 0, 51647
AppSec [candidate] (52.53 ms) : 0, 52530
IAST [baseline] (22.674 ms) : 0, 22674
IAST [candidate] (21.11 ms) : 0, 21110
Remote Config [baseline] (606.443 µs) : 0, 606
Remote Config [candidate] (587.297 µs) : 0, 587
Telemetry [baseline] (6.554 ms) : 0, 6554
Telemetry [candidate] (7.312 ms) : 0, 7312
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079563
Total [baseline] (10.469 s) : 0, 10469168
Agent [candidate] (1.08 s) : 0, 1079500
Total [candidate] (10.391 s) : 0, 10390828
section appsec
Agent [baseline] (1.198 s) : 0, 1198340
Total [baseline] (10.516 s) : 0, 10515803
Agent [candidate] (1.207 s) : 0, 1207469
Total [candidate] (10.633 s) : 0, 10633301
section iast
Agent [baseline] (1.212 s) : 0, 1212374
Total [baseline] (10.796 s) : 0, 10795769
Agent [candidate] (1.205 s) : 0, 1205366
Total [candidate] (10.77 s) : 0, 10769650
section profiling
Agent [baseline] (1.273 s) : 0, 1272667
Total [baseline] (10.602 s) : 0, 10602231
Agent [candidate] (1.275 s) : 0, 1275408
Total [candidate] (10.646 s) : 0, 10645557
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.198 s 118.778 ms (11.0%)
Agent iast 1.212 s 132.811 ms (12.3%)
Agent profiling 1.273 s 193.104 ms (17.9%)
Total tracing 10.469 s -
Total appsec 10.516 s 46.636 ms (0.4%)
Total iast 10.796 s 326.601 ms (3.1%)
Total profiling 10.602 s 133.063 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.207 s 127.969 ms (11.9%)
Agent iast 1.205 s 125.866 ms (11.7%)
Agent profiling 1.275 s 195.908 ms (18.1%)
Total tracing 10.391 s -
Total appsec 10.633 s 242.473 ms (2.3%)
Total iast 10.77 s 378.822 ms (3.6%)
Total profiling 10.646 s 254.729 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.84 ms) : 0, 675840
BytebuddyAgent [candidate] (675.707 ms) : 0, 675707
GlobalTracer [baseline] (311.238 ms) : 0, 311238
GlobalTracer [candidate] (311.561 ms) : 0, 311561
AppSec [baseline] (49.659 ms) : 0, 49659
AppSec [candidate] (49.559 ms) : 0, 49559
Remote Config [baseline] (662.617 µs) : 0, 663
Remote Config [candidate] (656.355 µs) : 0, 656
Telemetry [baseline] (7.616 ms) : 0, 7616
Telemetry [candidate] (7.549 ms) : 0, 7549
section appsec
BytebuddyAgent [baseline] (697.925 ms) : 0, 697925
BytebuddyAgent [candidate] (704.174 ms) : 0, 704174
GlobalTracer [baseline] (294.153 ms) : 0, 294153
GlobalTracer [candidate] (296.807 ms) : 0, 296807
AppSec [baseline] (152.493 ms) : 0, 152493
AppSec [candidate] (153.34 ms) : 0, 153340
Remote Config [baseline] (620.957 µs) : 0, 621
Remote Config [candidate] (625.298 µs) : 0, 625
Telemetry [baseline] (9.15 ms) : 0, 9150
Telemetry [candidate] (8.146 ms) : 0, 8146
IAST [baseline] (19.102 ms) : 0, 19102
IAST [candidate] (19.175 ms) : 0, 19175
section iast
BytebuddyAgent [baseline] (803.371 ms) : 0, 803371
BytebuddyAgent [candidate] (797.961 ms) : 0, 797961
GlobalTracer [baseline] (292.503 ms) : 0, 292503
GlobalTracer [candidate] (290.978 ms) : 0, 290978
AppSec [baseline] (49.689 ms) : 0, 49689
AppSec [candidate] (49.442 ms) : 0, 49442
Remote Config [baseline] (578.963 µs) : 0, 579
Remote Config [candidate] (678.039 µs) : 0, 678
Telemetry [baseline] (7.34 ms) : 0, 7340
Telemetry [candidate] (6.593 ms) : 0, 6593
IAST [baseline] (24.323 ms) : 0, 24323
IAST [candidate] (25.187 ms) : 0, 25187
section profiling
BytebuddyAgent [baseline] (678.445 ms) : 0, 678445
BytebuddyAgent [candidate] (679.181 ms) : 0, 679181
GlobalTracer [baseline] (383.26 ms) : 0, 383260
GlobalTracer [candidate] (384.193 ms) : 0, 384193
AppSec [baseline] (50.214 ms) : 0, 50214
AppSec [candidate] (50.799 ms) : 0, 50799
Remote Config [baseline] (697.379 µs) : 0, 697
Remote Config [candidate] (717.329 µs) : 0, 717
Telemetry [baseline] (7.492 ms) : 0, 7492
Telemetry [candidate] (7.494 ms) : 0, 7494
ProfilingAgent [baseline] (96.117 ms) : 0, 96117
ProfilingAgent [candidate] (96.485 ms) : 0, 96485
Profiling [baseline] (96.141 ms) : 0, 96141
Profiling [candidate] (96.509 ms) : 0, 96509
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-16T09:51:45 2024-05-16T09:58:35
git_branch master andrea.marziali/micronaut-4
git_commit_date 1715851940 1715852272
git_commit_sha 2edfc5e 3244c4c
release_version 1.35.0-SNAPSHOT~2edfc5eeb1 1.35.0-SNAPSHOT~3244c4c489
start_time 2024-05-16T09:51:31 2024-05-16T09:58:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715853864 1715853864
ci_job_id 513807944 513807944
ci_pipeline_id 34433122 34433122
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+39.404µs; +94.838µs] or [+2.651%; +6.380%]		 unstable
[-544.283op/s; +544.283op/s] or [-17.689%; +17.689%]		 1.554ms 3076.923op/s 1.487ms 3076.923op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.103 µs) : 357, 396
.   : milestone, 376,
iast (483.836 µs) : 463, 505
.   : milestone, 484,
iast_FULL (562.176 µs) : 541, 584
.   : milestone, 562,
iast_GLOBAL (518.381 µs) : 496, 540
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (481.993 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (454.076 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (473.544 µs) : 453, 494
.   : milestone, 474,
tracing (445.047 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (369.64 µs) : 349, 390
.   : milestone, 370,
iast (488.684 µs) : 467, 510
.   : milestone, 489,
iast_FULL (568.349 µs) : 546, 590
.   : milestone, 568,
iast_GLOBAL (516.519 µs) : 494, 539
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (484.989 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (458.535 µs) : 437, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (476.117 µs) : 455, 497
.   : milestone, 476,
tracing (449.411 µs) : 428, 471
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.103 µs [356.69 µs, 395.516 µs] -
iast 483.836 µs [462.797 µs, 504.874 µs] 107.733 µs (28.6%)
iast_FULL 562.176 µs [540.728 µs, 583.623 µs] 186.073 µs (49.5%)
iast_GLOBAL 518.381 µs [496.315 µs, 540.447 µs] 142.278 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 481.993 µs [461.257 µs, 502.728 µs] 105.89 µs (28.2%)
iast_INACTIVE 454.076 µs [432.849 µs, 475.303 µs] 77.973 µs (20.7%)
iast_TELEMETRY_OFF 473.544 µs [452.62 µs, 494.468 µs] 97.441 µs (25.9%)
tracing 445.047 µs [424.014 µs, 466.081 µs] 68.944 µs (18.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.64 µs [349.359 µs, 389.92 µs] -
iast 488.684 µs [467.292 µs, 510.076 µs] 119.044 µs (32.2%)
iast_FULL 568.349 µs [546.417 µs, 590.281 µs] 198.709 µs (53.8%)
iast_GLOBAL 516.519 µs [493.955 µs, 539.083 µs] 146.88 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED 484.989 µs [463.724 µs, 506.254 µs] 115.35 µs (31.2%)
iast_INACTIVE 458.535 µs [437.093 µs, 479.976 µs] 88.895 µs (24.0%)
iast_TELEMETRY_OFF 476.117 µs [454.827 µs, 497.407 µs] 106.477 µs (28.8%)
tracing 449.411 µs [428.255 µs, 470.566 µs] 79.771 µs (21.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.715 ms) : 1692, 1737
.   : milestone, 1715,
appsec_no_iast (1.744 ms) : 1719, 1768
.   : milestone, 1744,
iast (1.479 ms) : 1456, 1502
.   : milestone, 1479,
profiling (1.487 ms) : 1461, 1512
.   : milestone, 1487,
tracing (1.463 ms) : 1439, 1487
.   : milestone, 1463,
section candidate
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.746 ms) : 1723, 1769
.   : milestone, 1746,
appsec_no_iast (1.723 ms) : 1699, 1747
.   : milestone, 1723,
iast (1.495 ms) : 1473, 1517
.   : milestone, 1495,
profiling (1.554 ms) : 1528, 1580
.   : milestone, 1554,
tracing (1.485 ms) : 1460, 1510
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.715 ms [1.692 ms, 1.737 ms] 361.008 µs (26.7%)
appsec_no_iast 1.744 ms [1.719 ms, 1.768 ms] 389.976 µs (28.8%)
iast 1.479 ms [1.456 ms, 1.502 ms] 125.539 µs (9.3%)
profiling 1.487 ms [1.461 ms, 1.512 ms] 132.795 µs (9.8%)
tracing 1.463 ms [1.439 ms, 1.487 ms] 109.266 µs (8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.38 ms] -
appsec 1.746 ms [1.723 ms, 1.769 ms] 386.239 µs (28.4%)
appsec_no_iast 1.723 ms [1.699 ms, 1.747 ms] 363.294 µs (26.7%)
iast 1.495 ms [1.473 ms, 1.517 ms] 135.14 µs (9.9%)
profiling 1.554 ms [1.528 ms, 1.58 ms] 193.71 µs (14.2%)
tracing 1.485 ms [1.46 ms, 1.51 ms] 124.823 µs (9.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/micronaut-4
git_commit_date 1715851940 1715852272
git_commit_sha 2edfc5e 3244c4c
release_version 1.35.0-SNAPSHOT~2edfc5eeb1 1.35.0-SNAPSHOT~3244c4c489
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715854476 1715854476
ci_job_id 513807947 513807947
ci_pipeline_id 34433122 34433122
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.201 ms) : 2167, 2236
.   : milestone, 2201,
iast (1.961 ms) : 1921, 2002
.   : milestone, 1961,
iast_GLOBAL (2.0 ms) : 1960, 2040
.   : milestone, 2000,
profiling (1.848 ms) : 1816, 1881
.   : milestone, 1848,
tracing (1.825 ms) : 1793, 1857
.   : milestone, 1825,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.201 ms) : 2167, 2235
.   : milestone, 2201,
iast (1.953 ms) : 1913, 1994
.   : milestone, 1953,
iast_GLOBAL (2.0 ms) : 1959, 2040
.   : milestone, 2000,
profiling (1.847 ms) : 1814, 1879
.   : milestone, 1847,
tracing (1.831 ms) : 1799, 1863
.   : milestone, 1831,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.201 ms [2.167 ms, 2.236 ms] 739.863 µs (50.6%)
iast 1.961 ms [1.921 ms, 2.002 ms] 499.661 µs (34.2%)
iast_GLOBAL 2.0 ms [1.96 ms, 2.04 ms] 538.526 µs (36.8%)
profiling 1.848 ms [1.816 ms, 1.881 ms] 386.918 µs (26.5%)
tracing 1.825 ms [1.793 ms, 1.857 ms] 363.481 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.201 ms [2.167 ms, 2.235 ms] 733.625 µs (50.0%)
iast 1.953 ms [1.913 ms, 1.994 ms] 485.547 µs (33.1%)
iast_GLOBAL 2.0 ms [1.959 ms, 2.04 ms] 532.25 µs (36.3%)
profiling 1.847 ms [1.814 ms, 1.879 ms] 379.085 µs (25.8%)
tracing 1.831 ms [1.799 ms, 1.863 ms] 363.413 µs (24.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~3244c4c489, baseline=1.35.0-SNAPSHOT~2edfc5eeb1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.128 s) : 15128000, 15128000
.   : milestone, 15128000,
appsec (14.822 s) : 14822000, 14822000
.   : milestone, 14822000,
iast (18.58 s) : 18580000, 18580000
.   : milestone, 18580000,
iast_GLOBAL (17.734 s) : 17734000, 17734000
.   : milestone, 17734000,
profiling (15.401 s) : 15401000, 15401000
.   : milestone, 15401000,
tracing (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
section candidate
no_agent (15.251 s) : 15251000, 15251000
.   : milestone, 15251000,
appsec (14.857 s) : 14857000, 14857000
.   : milestone, 14857000,
iast (18.871 s) : 18871000, 18871000
.   : milestone, 18871000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
.   : milestone, 17904000,
profiling (14.867 s) : 14867000, 14867000
.   : milestone, 14867000,
tracing (15.269 s) : 15269000, 15269000
.   : milestone, 15269000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.128 s [15.128 s, 15.128 s] -
appsec 14.822 s [14.822 s, 14.822 s] -306.0 ms (-2.0%)
iast 18.58 s [18.58 s, 18.58 s] 3.452 s (22.8%)
iast_GLOBAL 17.734 s [17.734 s, 17.734 s] 2.606 s (17.2%)
profiling 15.401 s [15.401 s, 15.401 s] 273.0 ms (1.8%)
tracing 14.889 s [14.889 s, 14.889 s] -239.0 ms (-1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.251 s [15.251 s, 15.251 s] -
appsec 14.857 s [14.857 s, 14.857 s] -394.0 ms (-2.6%)
iast 18.871 s [18.871 s, 18.871 s] 3.62 s (23.7%)
iast_GLOBAL 17.904 s [17.904 s, 17.904 s] 2.653 s (17.4%)
profiling 14.867 s [14.867 s, 14.867 s] -384.0 ms (-2.5%)
tracing 15.269 s [15.269 s, 15.269 s] 18.0 ms (0.1%)

@amarziali amarziali force-pushed the andrea.marziali/micronaut-4 branch from cae449c to 3244c4c Compare May 16, 2024 09:38
ygree
ygree approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali merged commit 96faef0 into master May 17, 2024
80 checks passed
@amarziali amarziali deleted the andrea.marziali/micronaut-4 branch May 17, 2024 07:01
@github-actions github-actions bot added this to the 1.35.0 milestone May 17, 2024
@amarziali amarziali added inst: micronaut Micronaut instrumentation and removed inst: others All other instrumentations labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

@ygree ygree ygree approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: micronaut Micronaut instrumentation
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amarziali @ygree @jpbempel