Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expensive folding only in debug level #7042

Merged
merged 1 commit into from
May 17, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented May 16, 2024

What Does This Do

foldExceptionStackTrace can be expensive and must be called only in debug level log.
This happens when a field is not accessible (cross module since JDK16)

Motivation

undesirable overhead

Additional Notes

Jira ticket: DEBUG-2388

foldExceptionStackTrace can be expensive and must be called only in
debug level log.
This happens when a field is not accessible (cross module since JDK16)
@jpbempel jpbempel requested a review from a team as a code owner May 16, 2024 12:51
@jpbempel jpbempel requested review from shatzi and removed request for a team May 16, 2024 12:51
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label May 16, 2024
@jpbempel jpbempel merged commit f5e26a8 into master May 17, 2024
82 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-foldException-debug branch May 17, 2024 05:48
@github-actions github-actions bot added this to the 1.35.0 milestone May 17, 2024
@jpbempel jpbempel added type: bug tag: performance Performance related changes labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: debugger Dynamic Instrumentation tag: performance Performance related changes type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants