Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve loom features support #7045

Merged
merged 3 commits into from
May 30, 2024
Merged

Improve loom features support #7045

merged 3 commits into from
May 30, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented May 16, 2024 •
edited
Loading

What Does This Do

This PR brings support for the Java structured concurrency API (currently in preview) and refactors the java concurrent instrumentations:

  • Introduce a new Java module for JDK21 :java-concurrent-21,
    • Introduce a dedicated test suite for preview APIs: previewTest,
  • Move instrumentation classes per features into dedicated packages,
  • Improve virtual threads tests to no more use latestDep and be part of the check Gradle goal,
  • Fix test cases where thread pool is null.
  • Update instrumentation documentation about helper classes for bootstrap instrumentation.

Motivation

The goal is to improve our support for (current and incoming) Loom features.

Additional Notes

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added type: refactoring inst: java Core Java language instrumentation labels May 16, 2024
@PerfectSlayer PerfectSlayer force-pushed the bbujon/loom branch 2 times, most recently from 7c018ba to fce932c Compare May 21, 2024 09:53
@PerfectSlayer PerfectSlayer changed the title DRAFT - Loom support Improve loom features support May 24, 2024
@PerfectSlayer PerfectSlayer force-pushed the bbujon/loom branch 4 times, most recently from d6a4d3e to 1b74c15 Compare May 29, 2024 12:14
@pr-commenter
Copy link

pr-commenter bot commented May 29, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/loom
git_commit_date 1716998220 1717050537
git_commit_sha e2a66df 065b73e
release_version 1.35.0-SNAPSHOT~e2a66dfea5 1.35.0-SNAPSHOT~065b73e818
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717053644 1717053644
ci_job_id 526804397 526804397
ci_pipeline_id 35426264 35426264
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052318
Total [baseline] (10.272 s) : 0, 10272229
Agent [candidate] (1.056 s) : 0, 1055558
Total [candidate] (10.29 s) : 0, 10290078
section appsec
Agent [baseline] (1.175 s) : 0, 1174825
Total [baseline] (10.494 s) : 0, 10493918
Agent [candidate] (1.18 s) : 0, 1180165
Total [candidate] (10.432 s) : 0, 10431975
section iast
Agent [baseline] (1.182 s) : 0, 1181605
Total [baseline] (10.787 s) : 0, 10787307
Agent [candidate] (1.186 s) : 0, 1185626
Total [candidate] (10.773 s) : 0, 10772954
section profiling
Agent [baseline] (1.264 s) : 0, 1263920
Total [baseline] (10.637 s) : 0, 10636914
Agent [candidate] (1.263 s) : 0, 1263211
Total [candidate] (10.613 s) : 0, 10612713
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.175 s 122.508 ms (11.6%)
Agent iast 1.182 s 129.287 ms (12.3%)
Agent profiling 1.264 s 211.602 ms (20.1%)
Total tracing 10.272 s -
Total appsec 10.494 s 221.688 ms (2.2%)
Total iast 10.787 s 515.077 ms (5.0%)
Total profiling 10.637 s 364.684 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.18 s 124.608 ms (11.8%)
Agent iast 1.186 s 130.068 ms (12.3%)
Agent profiling 1.263 s 207.653 ms (19.7%)
Total tracing 10.29 s -
Total appsec 10.432 s 141.897 ms (1.4%)
Total iast 10.773 s 482.876 ms (4.7%)
Total profiling 10.613 s 322.636 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (649.293 ms) : 0, 649293
BytebuddyAgent [candidate] (651.749 ms) : 0, 651749
GlobalTracer [baseline] (311.091 ms) : 0, 311091
GlobalTracer [candidate] (311.401 ms) : 0, 311401
AppSec [baseline] (49.533 ms) : 0, 49533
AppSec [candidate] (49.845 ms) : 0, 49845
Remote Config [baseline] (647.827 µs) : 0, 648
Remote Config [candidate] (657.292 µs) : 0, 657
Telemetry [baseline] (7.551 ms) : 0, 7551
Telemetry [candidate] (7.51 ms) : 0, 7510
section appsec
BytebuddyAgent [baseline] (674.217 ms) : 0, 674217
BytebuddyAgent [candidate] (677.219 ms) : 0, 677219
GlobalTracer [baseline] (295.264 ms) : 0, 295264
GlobalTracer [candidate] (296.667 ms) : 0, 296667
AppSec [baseline] (152.632 ms) : 0, 152632
AppSec [candidate] (153.256 ms) : 0, 153256
IAST [baseline] (18.704 ms) : 0, 18704
IAST [candidate] (18.862 ms) : 0, 18862
Remote Config [baseline] (634.855 µs) : 0, 635
Remote Config [candidate] (635.983 µs) : 0, 636
Telemetry [baseline] (8.39 ms) : 0, 8390
Telemetry [candidate] (8.445 ms) : 0, 8445
section iast
BytebuddyAgent [baseline] (774.951 ms) : 0, 774951
BytebuddyAgent [candidate] (777.212 ms) : 0, 777212
GlobalTracer [baseline] (292.185 ms) : 0, 292185
GlobalTracer [candidate] (292.609 ms) : 0, 292609
AppSec [baseline] (48.75 ms) : 0, 48750
AppSec [candidate] (48.895 ms) : 0, 48895
IAST [baseline] (23.337 ms) : 0, 23337
IAST [candidate] (24.658 ms) : 0, 24658
Remote Config [baseline] (601.372 µs) : 0, 601
Remote Config [candidate] (580.668 µs) : 0, 581
Telemetry [baseline] (7.428 ms) : 0, 7428
Telemetry [candidate] (7.326 ms) : 0, 7326
section profiling
BytebuddyAgent [baseline] (665.017 ms) : 0, 665017
BytebuddyAgent [candidate] (664.748 ms) : 0, 664748
GlobalTracer [baseline] (386.357 ms) : 0, 386357
GlobalTracer [candidate] (386.871 ms) : 0, 386871
AppSec [baseline] (50.454 ms) : 0, 50454
AppSec [candidate] (50.957 ms) : 0, 50957
Remote Config [baseline] (824.956 µs) : 0, 825
Remote Config [candidate] (810.138 µs) : 0, 810
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (7.5 ms) : 0, 7500
ProfilingAgent [baseline] (96.924 ms) : 0, 96924
ProfilingAgent [candidate] (95.405 ms) : 0, 95405
Profiling [baseline] (96.948 ms) : 0, 96948
Profiling [candidate] (95.43 ms) : 0, 95430
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054190
Total [baseline] (8.539 s) : 0, 8538751
Agent [candidate] (1.054 s) : 0, 1053576
Total [candidate] (8.526 s) : 0, 8525640
section iast
Agent [baseline] (1.183 s) : 0, 1182514
Total [baseline] (8.985 s) : 0, 8984957
Agent [candidate] (1.195 s) : 0, 1195431
Total [candidate] (9.056 s) : 0, 9056018
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1200205
Total [baseline] (9.018 s) : 0, 9018093
Agent [candidate] (1.195 s) : 0, 1195359
Total [candidate] (9.007 s) : 0, 9007442
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1178527
Total [baseline] (8.999 s) : 0, 8999461
Agent [candidate] (1.192 s) : 0, 1192117
Total [candidate] (9.025 s) : 0, 9024869
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.183 s 128.324 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 146.015 ms (13.9%)
Agent iast_TELEMETRY_OFF 1.179 s 124.338 ms (11.8%)
Total tracing 8.539 s -
Total iast 8.985 s 446.206 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.018 s 479.342 ms (5.6%)
Total iast_TELEMETRY_OFF 8.999 s 460.709 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.195 s 141.854 ms (13.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 141.783 ms (13.5%)
Agent iast_TELEMETRY_OFF 1.192 s 138.541 ms (13.1%)
Total tracing 8.526 s -
Total iast 9.056 s 530.378 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.007 s 481.802 ms (5.7%)
Total iast_TELEMETRY_OFF 9.025 s 499.229 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (650.688 ms) : 0, 650688
BytebuddyAgent [candidate] (649.992 ms) : 0, 649992
GlobalTracer [baseline] (311.32 ms) : 0, 311320
GlobalTracer [candidate] (311.572 ms) : 0, 311572
AppSec [baseline] (49.621 ms) : 0, 49621
AppSec [candidate] (49.501 ms) : 0, 49501
Remote Config [baseline] (658.416 µs) : 0, 658
Remote Config [candidate] (655.248 µs) : 0, 655
Telemetry [baseline] (7.54 ms) : 0, 7540
Telemetry [candidate] (7.541 ms) : 0, 7541
section iast
BytebuddyAgent [baseline] (775.506 ms) : 0, 775506
BytebuddyAgent [candidate] (782.68 ms) : 0, 782680
GlobalTracer [baseline] (291.454 ms) : 0, 291454
GlobalTracer [candidate] (295.04 ms) : 0, 295040
AppSec [baseline] (49.619 ms) : 0, 49619
AppSec [candidate] (48.743 ms) : 0, 48743
Remote Config [baseline] (596.39 µs) : 0, 596
Remote Config [candidate] (613.213 µs) : 0, 613
Telemetry [baseline] (6.581 ms) : 0, 6581
Telemetry [candidate] (7.54 ms) : 0, 7540
IAST [baseline] (24.463 ms) : 0, 24463
IAST [candidate] (26.191 ms) : 0, 26191
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.971 ms) : 0, 786971
BytebuddyAgent [candidate] (782.689 ms) : 0, 782689
GlobalTracer [baseline] (296.013 ms) : 0, 296013
GlobalTracer [candidate] (294.472 ms) : 0, 294472
AppSec [baseline] (50.247 ms) : 0, 50247
AppSec [candidate] (47.791 ms) : 0, 47791
Remote Config [baseline] (599.016 µs) : 0, 599
Remote Config [candidate] (609.26 µs) : 0, 609
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (8.206 ms) : 0, 8206
IAST [baseline] (23.97 ms) : 0, 23970
IAST [candidate] (26.838 ms) : 0, 26838
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (771.052 ms) : 0, 771052
BytebuddyAgent [candidate] (778.995 ms) : 0, 778995
GlobalTracer [baseline] (291.087 ms) : 0, 291087
GlobalTracer [candidate] (295.597 ms) : 0, 295597
AppSec [baseline] (50.545 ms) : 0, 50545
AppSec [candidate] (51.847 ms) : 0, 51847
Remote Config [baseline] (633.7 µs) : 0, 634
Remote Config [candidate] (628.756 µs) : 0, 629
Telemetry [baseline] (7.154 ms) : 0, 7154
Telemetry [candidate] (6.549 ms) : 0, 6549
IAST [baseline] (23.692 ms) : 0, 23692
IAST [candidate] (23.848 ms) : 0, 23848
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-30T06:51:38 2024-05-30T06:58:29
git_branch master bbujon/loom
git_commit_date 1716998220 1717050537
git_commit_sha e2a66df 065b73e
release_version 1.35.0-SNAPSHOT~e2a66dfea5 1.35.0-SNAPSHOT~065b73e818
start_time 2024-05-30T06:51:25 2024-05-30T06:58:16
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717052657 1717052657
ci_job_id 526804398 526804398
ci_pipeline_id 35426264 35426264
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.367 µs) : 351, 390
.   : milestone, 370,
iast (484.429 µs) : 463, 505
.   : milestone, 484,
iast_FULL (562.606 µs) : 542, 584
.   : milestone, 563,
iast_GLOBAL (510.724 µs) : 490, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (484.853 µs) : 463, 507
.   : milestone, 485,
iast_INACTIVE (459.982 µs) : 439, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (475.09 µs) : 453, 497
.   : milestone, 475,
tracing (453.497 µs) : 433, 474
.   : milestone, 453,
section candidate
no_agent (370.383 µs) : 350, 390
.   : milestone, 370,
iast (487.396 µs) : 466, 509
.   : milestone, 487,
iast_FULL (558.844 µs) : 538, 580
.   : milestone, 559,
iast_GLOBAL (510.427 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (486.837 µs) : 466, 508
.   : milestone, 487,
iast_INACTIVE (461.819 µs) : 440, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (478.133 µs) : 457, 500
.   : milestone, 478,
tracing (449.046 µs) : 428, 470
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.367 µs [351.022 µs, 389.711 µs] -
iast 484.429 µs [463.437 µs, 505.421 µs] 114.062 µs (30.8%)
iast_FULL 562.606 µs [541.546 µs, 583.667 µs] 192.239 µs (51.9%)
iast_GLOBAL 510.724 µs [489.686 µs, 531.762 µs] 140.357 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 484.853 µs [462.938 µs, 506.768 µs] 114.486 µs (30.9%)
iast_INACTIVE 459.982 µs [438.674 µs, 481.291 µs] 89.616 µs (24.2%)
iast_TELEMETRY_OFF 475.09 µs [453.411 µs, 496.77 µs] 104.723 µs (28.3%)
tracing 453.497 µs [432.574 µs, 474.421 µs] 83.13 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.383 µs [350.498 µs, 390.269 µs] -
iast 487.396 µs [466.139 µs, 508.653 µs] 117.013 µs (31.6%)
iast_FULL 558.844 µs [537.737 µs, 579.951 µs] 188.461 µs (50.9%)
iast_GLOBAL 510.427 µs [489.386 µs, 531.468 µs] 140.043 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 486.837 µs [466.098 µs, 507.575 µs] 116.453 µs (31.4%)
iast_INACTIVE 461.819 µs [440.077 µs, 483.562 µs] 91.436 µs (24.7%)
iast_TELEMETRY_OFF 478.133 µs [456.586 µs, 499.681 µs] 107.75 µs (29.1%)
tracing 449.046 µs [427.799 µs, 470.293 µs] 78.663 µs (21.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.726 ms) : 1701, 1750
.   : milestone, 1726,
appsec_no_iast (1.727 ms) : 1703, 1751
.   : milestone, 1727,
iast (1.489 ms) : 1466, 1511
.   : milestone, 1489,
profiling (1.509 ms) : 1485, 1532
.   : milestone, 1509,
tracing (1.459 ms) : 1435, 1483
.   : milestone, 1459,
section candidate
no_agent (1.36 ms) : 1341, 1379
.   : milestone, 1360,
appsec (1.714 ms) : 1689, 1740
.   : milestone, 1714,
appsec_no_iast (1.731 ms) : 1707, 1756
.   : milestone, 1731,
iast (1.499 ms) : 1476, 1523
.   : milestone, 1499,
profiling (1.494 ms) : 1469, 1518
.   : milestone, 1494,
tracing (1.5 ms) : 1476, 1524
.   : milestone, 1500,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.726 ms [1.701 ms, 1.75 ms] 375.846 µs (27.8%)
appsec_no_iast 1.727 ms [1.703 ms, 1.751 ms] 376.945 µs (27.9%)
iast 1.489 ms [1.466 ms, 1.511 ms] 138.653 µs (10.3%)
profiling 1.509 ms [1.485 ms, 1.532 ms] 159.017 µs (11.8%)
tracing 1.459 ms [1.435 ms, 1.483 ms] 109.215 µs (8.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.341 ms, 1.379 ms] -
appsec 1.714 ms [1.689 ms, 1.74 ms] 354.281 µs (26.0%)
appsec_no_iast 1.731 ms [1.707 ms, 1.756 ms] 371.192 µs (27.3%)
iast 1.499 ms [1.476 ms, 1.523 ms] 139.135 µs (10.2%)
profiling 1.494 ms [1.469 ms, 1.518 ms] 133.373 µs (9.8%)
tracing 1.5 ms [1.476 ms, 1.524 ms] 140.275 µs (10.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/loom
git_commit_date 1716998220 1717050537
git_commit_sha e2a66df 065b73e
release_version 1.35.0-SNAPSHOT~e2a66dfea5 1.35.0-SNAPSHOT~065b73e818
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717053164 1717053164
ci_job_id 526804399 526804399
ci_pipeline_id 35426264 35426264
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
appsec (15.055 s) : 15055000, 15055000
.   : milestone, 15055000,
iast (18.88 s) : 18880000, 18880000
.   : milestone, 18880000,
iast_GLOBAL (17.91 s) : 17910000, 17910000
.   : milestone, 17910000,
profiling (15.211 s) : 15211000, 15211000
.   : milestone, 15211000,
tracing (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,
section candidate
no_agent (15.35 s) : 15350000, 15350000
.   : milestone, 15350000,
appsec (15.092 s) : 15092000, 15092000
.   : milestone, 15092000,
iast (18.739 s) : 18739000, 18739000
.   : milestone, 18739000,
iast_GLOBAL (18.011 s) : 18011000, 18011000
.   : milestone, 18011000,
profiling (15.348 s) : 15348000, 15348000
.   : milestone, 15348000,
tracing (14.918 s) : 14918000, 14918000
.   : milestone, 14918000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.013 s [15.013 s, 15.013 s] -
appsec 15.055 s [15.055 s, 15.055 s] 42.0 ms (0.3%)
iast 18.88 s [18.88 s, 18.88 s] 3.867 s (25.8%)
iast_GLOBAL 17.91 s [17.91 s, 17.91 s] 2.897 s (19.3%)
profiling 15.211 s [15.211 s, 15.211 s] 198.0 ms (1.3%)
tracing 14.954 s [14.954 s, 14.954 s] -59.0 ms (-0.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.35 s [15.35 s, 15.35 s] -
appsec 15.092 s [15.092 s, 15.092 s] -258.0 ms (-1.7%)
iast 18.739 s [18.739 s, 18.739 s] 3.389 s (22.1%)
iast_GLOBAL 18.011 s [18.011 s, 18.011 s] 2.661 s (17.3%)
profiling 15.348 s [15.348 s, 15.348 s] -2.0 ms (-0.0%)
tracing 14.918 s [14.918 s, 14.918 s] -432.0 ms (-2.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~065b73e818, baseline=1.35.0-SNAPSHOT~e2a66dfea5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.455 ms) : 1444, 1466
.   : milestone, 1455,
appsec (2.181 ms) : 2147, 2214
.   : milestone, 2181,
iast (1.958 ms) : 1917, 1999
.   : milestone, 1958,
iast_GLOBAL (1.995 ms) : 1955, 2036
.   : milestone, 1995,
profiling (1.832 ms) : 1799, 1864
.   : milestone, 1832,
tracing (1.824 ms) : 1792, 1856
.   : milestone, 1824,
section candidate
no_agent (1.457 ms) : 1446, 1468
.   : milestone, 1457,
appsec (2.201 ms) : 2167, 2236
.   : milestone, 2201,
iast (1.966 ms) : 1925, 2008
.   : milestone, 1966,
iast_GLOBAL (1.995 ms) : 1955, 2036
.   : milestone, 1995,
profiling (1.825 ms) : 1792, 1858
.   : milestone, 1825,
tracing (1.827 ms) : 1794, 1859
.   : milestone, 1827,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.466 ms] -
appsec 2.181 ms [2.147 ms, 2.214 ms] 725.486 µs (49.9%)
iast 1.958 ms [1.917 ms, 1.999 ms] 502.595 µs (34.5%)
iast_GLOBAL 1.995 ms [1.955 ms, 2.036 ms] 540.289 µs (37.1%)
profiling 1.832 ms [1.799 ms, 1.864 ms] 376.643 µs (25.9%)
tracing 1.824 ms [1.792 ms, 1.856 ms] 369.006 µs (25.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.468 ms] -
appsec 2.201 ms [2.167 ms, 2.236 ms] 744.419 µs (51.1%)
iast 1.966 ms [1.925 ms, 2.008 ms] 509.472 µs (35.0%)
iast_GLOBAL 1.995 ms [1.955 ms, 2.036 ms] 538.437 µs (37.0%)
profiling 1.825 ms [1.792 ms, 1.858 ms] 368.012 µs (25.3%)
tracing 1.827 ms [1.794 ms, 1.859 ms] 369.553 µs (25.4%)

@PerfectSlayer PerfectSlayer marked this pull request as ready for review May 29, 2024 13:19
@PerfectSlayer PerfectSlayer requested review from a team as code owners May 29, 2024 13:19
@PerfectSlayer PerfectSlayer requested review from mcculls and ygree May 29, 2024 13:19
amarziali
amarziali approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PerfectSlayer PerfectSlayer merged commit 4b5cad9 into master May 30, 2024
81 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/loom branch May 30, 2024 09:24
@github-actions github-actions bot added this to the 1.35.0 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: java Core Java language instrumentation type: enhancement type: refactoring
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerfectSlayer @amarziali