Support mapping extensions from different providers into a form that can be used by the Datadog tracer #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
comp: core
mcculls
force-pushed
the
mcculls/support-other-extension-formats
branch
2 times, most recently
from
b963a32 to
51a1fa3
Compare
…can be used by the Datadog tracer.
mcculls
force-pushed
the
mcculls/support-other-extension-formats
branch
from
51a1fa3 to
222a95d
Compare
dougqh
reviewed
May 20, 2024
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/ExtensionHandler.java
Outdated
Show resolved
Hide resolved
dougqh
approved these changes
May 20, 2024
| /** Maps logging references in the extension to use the tracer's embedded logger. */ | ||
| protected static final Function<String, String> SHADE_LOGGING = | ||
| new Function<String, String>() { | ||
| // substring stops string literal from being changed by shadow plugin |
There was a problem hiding this comment.
Thanks for adding clarification!
mcculls
added a commit
that referenced
this pull request
May 24, 2024
Avoids creating unnecessary spans when exceptions occur during custom non-HTTP connections, like the custom Jar connection recently added in #7049. Note the respective instrumentation in OpenTelemetry was also removed for the same reason. Exceptions during HTTP connections are already captured by HttpUrlConnectionInstrumentation. The URL instrumentation can be re-enabled with `DD_INTEGRATION_URLCONNECTION_ENABLED=true`
mcculls
added a commit
that referenced
this pull request
May 24, 2024
Avoids creating unnecessary spans when exceptions occur during custom non-HTTP connections, like the custom Jar connection recently added in #7049. Note the respective instrumentation in OpenTelemetry was also removed for the same reason. Exceptions during HTTP connections are already captured by HttpUrlConnectionInstrumentation. The URL instrumentation can be re-enabled with `DD_INTEGRATION_URLCONNECTION_ENABLED=true`
mcculls
added a commit
that referenced
this pull request
May 24, 2024
Avoids creating unnecessary spans when exceptions occur during custom non-HTTP connections, like the custom Jar connection recently added in #7049. Note the respective instrumentation in OpenTelemetry was also removed for the same reason. Exceptions during HTTP connections are already captured by HttpUrlConnectionInstrumentation. The URL instrumentation can be re-enabled with `DD_INTEGRATION_URLCONNECTION_ENABLED=true`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Provide a way to apply alternative mappings when loading extensions, such as from OpenTelemetry.
Jira ticket: APMAPI-69