Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix short circuiting of boolean expressions #7060

Merged
merged 1 commit into from
May 22, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented May 22, 2024

What Does This Do

We are just delegating to the operator evaluation the evaluation of the left and right instead of evaluating operands before the operator.

Motivation

Boolean expressions with AND (&&) or OR (||) should short circuit as expected for any languages. It helps to support correctly expressions like
isDefined(@exception) && contains(@exception.detailMessage, 'closed')

Additional Notes

Jira ticket: DEBUG-2232

Boolean expressions with AND (&&) or OR (||) should short circuit
as expected for any languages. It helps to support correctly
expressions like
`isDefined(@exception) && contains(@exception.detailMessage, 'closed')`
We are just delegating to the operator evaluation the evaluation of
the left and right instead of evaluating operands before the operator.
@jpbempel jpbempel added type: bug comp: debugger Dynamic Instrumentation labels May 22, 2024
@jpbempel jpbempel requested a review from a team as a code owner May 22, 2024 11:16
@jpbempel jpbempel requested review from ojung and removed request for a team May 22, 2024 11:16
Copy link
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpbempel jpbempel merged commit 187601c into master May 22, 2024
78 of 81 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-short-circuit-bool-expr branch May 22, 2024 15:29
@github-actions github-actions bot added this to the 1.35.0 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants