Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump byte-buddy to 1.14.16 #7077

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Bump byte-buddy to 1.14.16 #7077

merged 2 commits into from
Jun 3, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented May 24, 2024 •
edited
Loading

Supports transforming Java 23 bytecode

Changes since last update:

  • Update ASM and introduce support for Java 23.
  • Allow attaching from root on J9.
  • Adjust type validation to accept additional names that are legal in the class file format.
  • Fix dynamic attach on Windows when a service user is active.
  • Avoid failure when using Android's strict mode.

Also updates the ASM dependencies in our build to 9.7 to match

@mcculls mcculls added the tag: dependencies Dependencies related changes label May 24, 2024
PerfectSlayer
PerfectSlayer reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently tried to relaunch CI but build_inst keeps failing in timeout.

@mcculls mcculls force-pushed the mcculls/byte-buddy-1.14.16 branch 2 times, most recently from be6555a to dfc6572 Compare May 29, 2024 23:44
@pr-commenter
Copy link

pr-commenter bot commented May 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/byte-buddy-1.14.16
git_commit_date 1717158264 1717179692
git_commit_sha dadbd53 cb8ac15
release_version 1.35.0-SNAPSHOT~dadbd53b67 1.35.0-SNAPSHOT~cb8ac1530c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717182458 1717182458
ci_job_id 529265634 529265634
ci_pipeline_id 35611208 35611208
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083560
Total [baseline] (8.657 s) : 0, 8657389
Agent [candidate] (1.066 s) : 0, 1065973
Total [candidate] (8.541 s) : 0, 8541232
section iast
Agent [baseline] (1.161 s) : 0, 1161337
Total [baseline] (8.975 s) : 0, 8975143
Agent [candidate] (1.164 s) : 0, 1164264
Total [candidate] (8.98 s) : 0, 8980265
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171714
Total [baseline] (8.97 s) : 0, 8970169
Agent [candidate] (1.162 s) : 0, 1161646
Total [candidate] (8.951 s) : 0, 8951188
section iast_TELEMETRY_OFF
Agent [baseline] (1.161 s) : 0, 1160649
Total [baseline] (8.961 s) : 0, 8961461
Agent [candidate] (1.161 s) : 0, 1161494
Total [candidate] (8.956 s) : 0, 8955731
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.161 s 77.778 ms (7.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 88.155 ms (8.1%)
Agent iast_TELEMETRY_OFF 1.161 s 77.089 ms (7.1%)
Total tracing 8.657 s -
Total iast 8.975 s 317.754 ms (3.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.97 s 312.78 ms (3.6%)
Total iast_TELEMETRY_OFF 8.961 s 304.071 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.164 s 98.29 ms (9.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.162 s 95.672 ms (9.0%)
Agent iast_TELEMETRY_OFF 1.161 s 95.52 ms (9.0%)
Total tracing 8.541 s -
Total iast 8.98 s 439.032 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.951 s 409.956 ms (4.8%)
Total iast_TELEMETRY_OFF 8.956 s 414.499 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.484 ms) : 0, 669484
BytebuddyAgent [candidate] (658.103 ms) : 0, 658103
GlobalTracer [baseline] (319.401 ms) : 0, 319401
GlobalTracer [candidate] (314.596 ms) : 0, 314596
AppSec [baseline] (50.865 ms) : 0, 50865
AppSec [candidate] (50.343 ms) : 0, 50343
Remote Config [baseline] (693.379 µs) : 0, 693
Remote Config [candidate] (664.775 µs) : 0, 665
Telemetry [baseline] (7.794 ms) : 0, 7794
Telemetry [candidate] (7.496 ms) : 0, 7496
section iast
BytebuddyAgent [baseline] (776.032 ms) : 0, 776032
BytebuddyAgent [candidate] (777.702 ms) : 0, 777702
GlobalTracer [baseline] (290.737 ms) : 0, 290737
GlobalTracer [candidate] (291.213 ms) : 0, 291213
AppSec [baseline] (49.337 ms) : 0, 49337
AppSec [candidate] (47.659 ms) : 0, 47659
IAST [baseline] (23.092 ms) : 0, 23092
IAST [candidate] (24.739 ms) : 0, 24739
Remote Config [baseline] (596.137 µs) : 0, 596
Remote Config [candidate] (590.226 µs) : 0, 590
Telemetry [baseline] (8.337 ms) : 0, 8337
Telemetry [candidate] (9.115 ms) : 0, 9115
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.999 ms) : 0, 781999
BytebuddyAgent [candidate] (775.891 ms) : 0, 775891
GlobalTracer [baseline] (293.419 ms) : 0, 293419
GlobalTracer [candidate] (291.173 ms) : 0, 291173
AppSec [baseline] (49.859 ms) : 0, 49859
AppSec [candidate] (50.694 ms) : 0, 50694
IAST [baseline] (24.832 ms) : 0, 24832
IAST [candidate] (22.307 ms) : 0, 22307
Remote Config [baseline] (587.329 µs) : 0, 587
Remote Config [candidate] (592.851 µs) : 0, 593
Telemetry [baseline] (7.625 ms) : 0, 7625
Telemetry [candidate] (7.71 ms) : 0, 7710
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.881 ms) : 0, 774881
BytebuddyAgent [candidate] (775.587 ms) : 0, 775587
GlobalTracer [baseline] (291.549 ms) : 0, 291549
GlobalTracer [candidate] (291.988 ms) : 0, 291988
AppSec [baseline] (49.852 ms) : 0, 49852
AppSec [candidate] (51.738 ms) : 0, 51738
IAST [baseline] (22.118 ms) : 0, 22118
IAST [candidate] (21.667 ms) : 0, 21667
Remote Config [baseline] (600.037 µs) : 0, 600
Remote Config [candidate] (573.913 µs) : 0, 574
Telemetry [baseline] (8.339 ms) : 0, 8339
Telemetry [candidate] (6.63 ms) : 0, 6630
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071429
Total [baseline] (10.316 s) : 0, 10316088
Agent [candidate] (1.056 s) : 0, 1055783
Total [candidate] (10.269 s) : 0, 10269400
section appsec
Agent [baseline] (1.18 s) : 0, 1179693
Total [baseline] (10.442 s) : 0, 10441821
Agent [candidate] (1.178 s) : 0, 1177704
Total [candidate] (10.462 s) : 0, 10461962
section iast
Agent [baseline] (1.181 s) : 0, 1181348
Total [baseline] (10.775 s) : 0, 10775195
Agent [candidate] (1.168 s) : 0, 1167616
Total [candidate] (10.738 s) : 0, 10738359
section profiling
Agent [baseline] (1.259 s) : 0, 1259236
Total [baseline] (10.558 s) : 0, 10557747
Agent [candidate] (1.256 s) : 0, 1256361
Total [candidate] (10.62 s) : 0, 10620425
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.18 s 108.265 ms (10.1%)
Agent iast 1.181 s 109.919 ms (10.3%)
Agent profiling 1.259 s 187.807 ms (17.5%)
Total tracing 10.316 s -
Total appsec 10.442 s 125.733 ms (1.2%)
Total iast 10.775 s 459.107 ms (4.5%)
Total profiling 10.558 s 241.659 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.178 s 121.921 ms (11.5%)
Agent iast 1.168 s 111.833 ms (10.6%)
Agent profiling 1.256 s 200.577 ms (19.0%)
Total tracing 10.269 s -
Total appsec 10.462 s 192.563 ms (1.9%)
Total iast 10.738 s 468.96 ms (4.6%)
Total profiling 10.62 s 351.025 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (661.387 ms) : 0, 661387
BytebuddyAgent [candidate] (652.037 ms) : 0, 652037
GlobalTracer [baseline] (316.422 ms) : 0, 316422
GlobalTracer [candidate] (311.523 ms) : 0, 311523
AppSec [baseline] (50.46 ms) : 0, 50460
AppSec [candidate] (49.788 ms) : 0, 49788
Remote Config [baseline] (677.891 µs) : 0, 678
Remote Config [candidate] (651.783 µs) : 0, 652
Telemetry [baseline] (7.703 ms) : 0, 7703
Telemetry [candidate] (7.455 ms) : 0, 7455
section appsec
BytebuddyAgent [baseline] (678.322 ms) : 0, 678322
BytebuddyAgent [candidate] (676.343 ms) : 0, 676343
GlobalTracer [baseline] (295.866 ms) : 0, 295866
GlobalTracer [candidate] (295.709 ms) : 0, 295709
AppSec [baseline] (152.776 ms) : 0, 152776
AppSec [candidate] (153.053 ms) : 0, 153053
IAST [baseline] (18.91 ms) : 0, 18910
IAST [candidate] (18.678 ms) : 0, 18678
Remote Config [baseline] (621.723 µs) : 0, 622
Remote Config [candidate] (615.745 µs) : 0, 616
Telemetry [baseline] (8.138 ms) : 0, 8138
Telemetry [candidate] (8.173 ms) : 0, 8173
section iast
BytebuddyAgent [baseline] (790.079 ms) : 0, 790079
BytebuddyAgent [candidate] (780.448 ms) : 0, 780448
GlobalTracer [baseline] (296.135 ms) : 0, 296135
GlobalTracer [candidate] (292.418 ms) : 0, 292418
AppSec [baseline] (49.244 ms) : 0, 49244
AppSec [candidate] (49.49 ms) : 0, 49490
IAST [baseline] (24.146 ms) : 0, 24146
IAST [candidate] (23.049 ms) : 0, 23049
Remote Config [baseline] (607.161 µs) : 0, 607
Remote Config [candidate] (586.43 µs) : 0, 586
Telemetry [baseline] (7.747 ms) : 0, 7747
Telemetry [candidate] (8.329 ms) : 0, 8329
section profiling
BytebuddyAgent [baseline] (662.58 ms) : 0, 662580
BytebuddyAgent [candidate] (661.242 ms) : 0, 661242
GlobalTracer [baseline] (384.929 ms) : 0, 384929
GlobalTracer [candidate] (384.232 ms) : 0, 384232
AppSec [baseline] (50.635 ms) : 0, 50635
AppSec [candidate] (50.083 ms) : 0, 50083
Remote Config [baseline] (853.915 µs) : 0, 854
Remote Config [candidate] (848.09 µs) : 0, 848
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.424 ms) : 0, 7424
ProfilingAgent [baseline] (96.266 ms) : 0, 96266
ProfilingAgent [candidate] (96.156 ms) : 0, 96156
Profiling [baseline] (96.291 ms) : 0, 96291
Profiling [candidate] (96.18 ms) : 0, 96180
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-31T18:38:30 2024-05-31T18:45:20
git_branch master mcculls/byte-buddy-1.14.16
git_commit_date 1717158264 1717179692
git_commit_sha dadbd53 cb8ac15
release_version 1.35.0-SNAPSHOT~dadbd53b67 1.35.0-SNAPSHOT~cb8ac1530c
start_time 2024-05-31T18:38:17 2024-05-31T18:45:06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717181466 1717181466
ci_job_id 529265635 529265635
ci_pipeline_id 35611208 35611208
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.288 µs) : 352, 392
.   : milestone, 372,
iast (478.887 µs) : 458, 500
.   : milestone, 479,
iast_FULL (550.731 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (515.736 µs) : 493, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (482.736 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (460.064 µs) : 438, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (477.429 µs) : 456, 499
.   : milestone, 477,
tracing (455.576 µs) : 434, 477
.   : milestone, 456,
section candidate
no_agent (366.303 µs) : 346, 386
.   : milestone, 366,
iast (489.292 µs) : 468, 510
.   : milestone, 489,
iast_FULL (548.814 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (510.811 µs) : 490, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (483.285 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (455.379 µs) : 434, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (482.86 µs) : 461, 505
.   : milestone, 483,
tracing (443.448 µs) : 423, 464
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.288 µs [352.458 µs, 392.117 µs] -
iast 478.887 µs [458.024 µs, 499.749 µs] 106.599 µs (28.6%)
iast_FULL 550.731 µs [529.767 µs, 571.695 µs] 178.443 µs (47.9%)
iast_GLOBAL 515.736 µs [493.033 µs, 538.439 µs] 143.449 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 482.736 µs [461.94 µs, 503.533 µs] 110.449 µs (29.7%)
iast_INACTIVE 460.064 µs [438.417 µs, 481.71 µs] 87.776 µs (23.6%)
iast_TELEMETRY_OFF 477.429 µs [456.071 µs, 498.786 µs] 105.141 µs (28.2%)
tracing 455.576 µs [434.303 µs, 476.849 µs] 83.289 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.303 µs [346.395 µs, 386.211 µs] -
iast 489.292 µs [468.287 µs, 510.298 µs] 122.99 µs (33.6%)
iast_FULL 548.814 µs [527.643 µs, 569.984 µs] 182.511 µs (49.8%)
iast_GLOBAL 510.811 µs [489.844 µs, 531.778 µs] 144.508 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED 483.285 µs [462.104 µs, 504.466 µs] 116.982 µs (31.9%)
iast_INACTIVE 455.379 µs [433.721 µs, 477.038 µs] 89.077 µs (24.3%)
iast_TELEMETRY_OFF 482.86 µs [461.181 µs, 504.539 µs] 116.558 µs (31.8%)
tracing 443.448 µs [423.156 µs, 463.74 µs] 77.145 µs (21.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.368 ms) : 1348, 1387
.   : milestone, 1368,
appsec (1.71 ms) : 1685, 1734
.   : milestone, 1710,
appsec_no_iast (1.715 ms) : 1690, 1739
.   : milestone, 1715,
iast (1.486 ms) : 1462, 1510
.   : milestone, 1486,
profiling (1.51 ms) : 1485, 1535
.   : milestone, 1510,
tracing (1.467 ms) : 1443, 1490
.   : milestone, 1467,
section candidate
no_agent (1.347 ms) : 1327, 1367
.   : milestone, 1347,
appsec (1.701 ms) : 1676, 1726
.   : milestone, 1701,
appsec_no_iast (1.723 ms) : 1698, 1748
.   : milestone, 1723,
iast (1.472 ms) : 1450, 1495
.   : milestone, 1472,
profiling (1.532 ms) : 1506, 1558
.   : milestone, 1532,
tracing (1.481 ms) : 1456, 1506
.   : milestone, 1481,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.368 ms [1.348 ms, 1.387 ms] -
appsec 1.71 ms [1.685 ms, 1.734 ms] 342.041 µs (25.0%)
appsec_no_iast 1.715 ms [1.69 ms, 1.739 ms] 346.876 µs (25.4%)
iast 1.486 ms [1.462 ms, 1.51 ms] 118.244 µs (8.6%)
profiling 1.51 ms [1.485 ms, 1.535 ms] 142.312 µs (10.4%)
tracing 1.467 ms [1.443 ms, 1.49 ms] 98.984 µs (7.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.367 ms] -
appsec 1.701 ms [1.676 ms, 1.726 ms] 353.972 µs (26.3%)
appsec_no_iast 1.723 ms [1.698 ms, 1.748 ms] 376.382 µs (27.9%)
iast 1.472 ms [1.45 ms, 1.495 ms] 125.264 µs (9.3%)
profiling 1.532 ms [1.506 ms, 1.558 ms] 185.371 µs (13.8%)
tracing 1.481 ms [1.456 ms, 1.506 ms] 134.226 µs (10.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/byte-buddy-1.14.16
git_commit_date 1717158264 1717179692
git_commit_sha dadbd53 cb8ac15
release_version 1.35.0-SNAPSHOT~dadbd53b67 1.35.0-SNAPSHOT~cb8ac1530c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717181967 1717181967
ci_job_id 529265636 529265636
ci_pipeline_id 35611208 35611208
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.205 ms) : 2171, 2238
.   : milestone, 2205,
iast (1.97 ms) : 1929, 2011
.   : milestone, 1970,
iast_GLOBAL (2.009 ms) : 1968, 2050
.   : milestone, 2009,
profiling (1.846 ms) : 1814, 1879
.   : milestone, 1846,
tracing (1.833 ms) : 1802, 1865
.   : milestone, 1833,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.2 ms) : 2166, 2233
.   : milestone, 2200,
iast (1.972 ms) : 1931, 2013
.   : milestone, 1972,
iast_GLOBAL (2.013 ms) : 1972, 2054
.   : milestone, 2013,
profiling (1.853 ms) : 1820, 1886
.   : milestone, 1853,
tracing (1.827 ms) : 1796, 1859
.   : milestone, 1827,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.205 ms [2.171 ms, 2.238 ms] 737.013 µs (50.2%)
iast 1.97 ms [1.929 ms, 2.011 ms] 502.271 µs (34.2%)
iast_GLOBAL 2.009 ms [1.968 ms, 2.05 ms] 541.282 µs (36.9%)
profiling 1.846 ms [1.814 ms, 1.879 ms] 378.628 µs (25.8%)
tracing 1.833 ms [1.802 ms, 1.865 ms] 365.565 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.2 ms [2.166 ms, 2.233 ms] 732.345 µs (49.9%)
iast 1.972 ms [1.931 ms, 2.013 ms] 504.497 µs (34.4%)
iast_GLOBAL 2.013 ms [1.972 ms, 2.054 ms] 545.503 µs (37.2%)
profiling 1.853 ms [1.82 ms, 1.886 ms] 385.868 µs (26.3%)
tracing 1.827 ms [1.796 ms, 1.859 ms] 359.726 µs (24.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~cb8ac1530c, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.034 s) : 15034000, 15034000
.   : milestone, 15034000,
appsec (14.805 s) : 14805000, 14805000
.   : milestone, 14805000,
iast (18.648 s) : 18648000, 18648000
.   : milestone, 18648000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
.   : milestone, 17905000,
profiling (15.385 s) : 15385000, 15385000
.   : milestone, 15385000,
tracing (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
section candidate
no_agent (15.714 s) : 15714000, 15714000
.   : milestone, 15714000,
appsec (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
iast (18.705 s) : 18705000, 18705000
.   : milestone, 18705000,
iast_GLOBAL (17.976 s) : 17976000, 17976000
.   : milestone, 17976000,
profiling (15.79 s) : 15790000, 15790000
.   : milestone, 15790000,
tracing (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.034 s [15.034 s, 15.034 s] -
appsec 14.805 s [14.805 s, 14.805 s] -229.0 ms (-1.5%)
iast 18.648 s [18.648 s, 18.648 s] 3.614 s (24.0%)
iast_GLOBAL 17.905 s [17.905 s, 17.905 s] 2.871 s (19.1%)
profiling 15.385 s [15.385 s, 15.385 s] 351.0 ms (2.3%)
tracing 15.037 s [15.037 s, 15.037 s] 3.0 ms (0.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.714 s [15.714 s, 15.714 s] -
appsec 15.059 s [15.059 s, 15.059 s] -655.0 ms (-4.2%)
iast 18.705 s [18.705 s, 18.705 s] 2.991 s (19.0%)
iast_GLOBAL 17.976 s [17.976 s, 17.976 s] 2.262 s (14.4%)
profiling 15.79 s [15.79 s, 15.79 s] 76.0 ms (0.5%)
tracing 15.077 s [15.077 s, 15.077 s] -637.0 ms (-4.1%)

@mcculls mcculls force-pushed the mcculls/byte-buddy-1.14.16 branch from dfc6572 to cb8ac15 Compare May 31, 2024 18:21
@mcculls mcculls marked this pull request as ready for review May 31, 2024 19:27
@mcculls mcculls requested a review from a team as a code owner May 31, 2024 19:27
@mcculls mcculls requested review from dougqh and PerfectSlayer May 31, 2024 19:27
@mcculls
Copy link
Contributor Author

mcculls commented May 31, 2024

@PerfectSlayer CI seems to be behaving better now, no GC failures in the last run

@PerfectSlayer PerfectSlayer changed the title byte-buddy 1.14.16 Bump byte-buddy to 1.14.16 Jun 3, 2024
@mcculls mcculls merged commit f6c5dd3 into master Jun 3, 2024
81 checks passed
@mcculls mcculls deleted the mcculls/byte-buddy-1.14.16 branch June 3, 2024 09:04
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 3, 2024
@mcculls mcculls added the comp: core Tracer core label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@smola smola smola approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: dependencies Dependencies related changes
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @smola @PerfectSlayer