Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report updated trace.sampling.rules to telemetry #7106

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Report updated trace.sampling.rules to telemetry #7106

merged 6 commits into from
Jun 3, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented May 31, 2024 •
edited by jira bot
Loading

Additional Notes

The approach take here is to cache the original JSON that was parsed into the rules, for both the original static config and any updates to the dynamic config. This required a custom Moshi adapter to capture the raw JSON before it was parsed, but it was simpler than trying to reconstruct the JSON from the rule objects and more consistent with what we were sent.

Jira ticket: APMAPI-78

@mcculls mcculls added the comp: telemetry Telemetry label May 31, 2024
@mcculls mcculls marked this pull request as ready for review May 31, 2024 14:54
@mcculls mcculls requested a review from a team as a code owner May 31, 2024 14:54
@mcculls mcculls requested review from dougqh and PerfectSlayer May 31, 2024 14:54
@pr-commenter
Copy link

pr-commenter bot commented May 31, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/report-dynamic-sampling-change-to-telemetry
git_commit_date 1717412897 1717416568
git_commit_sha b2807ad 718e512
release_version 1.35.0-SNAPSHOT~b2807adfa7 1.35.0-SNAPSHOT~718e512043
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717420003 1717420003
ci_job_id 530193511 530193511
ci_pipeline_id 35683347 35683347
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069056
Total [baseline] (8.561 s) : 0, 8560607
Agent [candidate] (1.066 s) : 0, 1065805
Total [candidate] (8.584 s) : 0, 8583693
section iast
Agent [baseline] (1.162 s) : 0, 1162471
Total [baseline] (8.973 s) : 0, 8973329
Agent [candidate] (1.168 s) : 0, 1167609
Total [candidate] (9.042 s) : 0, 9041942
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.166 s) : 0, 1166472
Total [baseline] (8.981 s) : 0, 8981183
Agent [candidate] (1.183 s) : 0, 1183469
Total [candidate] (9.031 s) : 0, 9030764
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1162933
Total [baseline] (9.021 s) : 0, 9021192
Agent [candidate] (1.163 s) : 0, 1162749
Total [candidate] (9.05 s) : 0, 9049790
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.162 s 93.415 ms (8.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.166 s 97.416 ms (9.1%)
Agent iast_TELEMETRY_OFF 1.163 s 93.877 ms (8.8%)
Total tracing 8.561 s -
Total iast 8.973 s 412.722 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.981 s 420.576 ms (4.9%)
Total iast_TELEMETRY_OFF 9.021 s 460.585 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.168 s 101.804 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 117.664 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.163 s 96.944 ms (9.1%)
Total tracing 8.584 s -
Total iast 9.042 s 458.249 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.031 s 447.07 ms (5.2%)
Total iast_TELEMETRY_OFF 9.05 s 466.096 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (659.843 ms) : 0, 659843
BytebuddyAgent [candidate] (657.328 ms) : 0, 657328
GlobalTracer [baseline] (315.536 ms) : 0, 315536
GlobalTracer [candidate] (315.322 ms) : 0, 315322
AppSec [baseline] (50.283 ms) : 0, 50283
AppSec [candidate] (50.302 ms) : 0, 50302
Remote Config [baseline] (680.284 µs) : 0, 680
Remote Config [candidate] (667.652 µs) : 0, 668
Telemetry [baseline] (7.689 ms) : 0, 7689
Telemetry [candidate] (7.593 ms) : 0, 7593
section iast
BytebuddyAgent [baseline] (776.854 ms) : 0, 776854
BytebuddyAgent [candidate] (779.154 ms) : 0, 779154
GlobalTracer [baseline] (290.852 ms) : 0, 290852
GlobalTracer [candidate] (292.614 ms) : 0, 292614
AppSec [baseline] (49.655 ms) : 0, 49655
AppSec [candidate] (48.163 ms) : 0, 48163
Remote Config [baseline] (584.545 µs) : 0, 585
Remote Config [candidate] (618.289 µs) : 0, 618
Telemetry [baseline] (6.79 ms) : 0, 6790
Telemetry [candidate] (10.129 ms) : 0, 10129
IAST [baseline] (24.515 ms) : 0, 24515
IAST [candidate] (23.663 ms) : 0, 23663
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.088 ms) : 0, 779088
BytebuddyAgent [candidate] (789.221 ms) : 0, 789221
GlobalTracer [baseline] (292.094 ms) : 0, 292094
GlobalTracer [candidate] (296.832 ms) : 0, 296832
AppSec [baseline] (48.151 ms) : 0, 48151
AppSec [candidate] (48.824 ms) : 0, 48824
Remote Config [baseline] (596.441 µs) : 0, 596
Remote Config [candidate] (607.71 µs) : 0, 608
Telemetry [baseline] (7.681 ms) : 0, 7681
Telemetry [candidate] (9.398 ms) : 0, 9398
IAST [baseline] (25.582 ms) : 0, 25582
IAST [candidate] (25.127 ms) : 0, 25127
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.891 ms) : 0, 775891
BytebuddyAgent [candidate] (775.69 ms) : 0, 775690
GlobalTracer [baseline] (291.395 ms) : 0, 291395
GlobalTracer [candidate] (292.671 ms) : 0, 292671
AppSec [baseline] (51.194 ms) : 0, 51194
AppSec [candidate] (49.672 ms) : 0, 49672
Remote Config [baseline] (614.149 µs) : 0, 614
Remote Config [candidate] (616.053 µs) : 0, 616
Telemetry [baseline] (8.352 ms) : 0, 8352
Telemetry [candidate] (8.254 ms) : 0, 8254
IAST [baseline] (22.199 ms) : 0, 22199
IAST [candidate] (22.591 ms) : 0, 22591
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059509
Total [baseline] (10.318 s) : 0, 10318486
Agent [candidate] (1.056 s) : 0, 1056397
Total [candidate] (10.289 s) : 0, 10289117
section appsec
Agent [baseline] (1.176 s) : 0, 1175851
Total [baseline] (10.491 s) : 0, 10491310
Agent [candidate] (1.177 s) : 0, 1176621
Total [candidate] (10.457 s) : 0, 10456976
section iast
Agent [baseline] (1.17 s) : 0, 1170483
Total [baseline] (10.811 s) : 0, 10810672
Agent [candidate] (1.167 s) : 0, 1166832
Total [candidate] (10.718 s) : 0, 10718456
section profiling
Agent [baseline] (1.256 s) : 0, 1256469
Total [baseline] (10.594 s) : 0, 10593583
Agent [candidate] (1.255 s) : 0, 1255074
Total [candidate] (10.614 s) : 0, 10613813
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.176 s 116.342 ms (11.0%)
Agent iast 1.17 s 110.974 ms (10.5%)
Agent profiling 1.256 s 196.959 ms (18.6%)
Total tracing 10.318 s -
Total appsec 10.491 s 172.824 ms (1.7%)
Total iast 10.811 s 492.185 ms (4.8%)
Total profiling 10.594 s 275.097 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.177 s 120.224 ms (11.4%)
Agent iast 1.167 s 110.435 ms (10.5%)
Agent profiling 1.255 s 198.677 ms (18.8%)
Total tracing 10.289 s -
Total appsec 10.457 s 167.859 ms (1.6%)
Total iast 10.718 s 429.339 ms (4.2%)
Total profiling 10.614 s 324.696 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (655.342 ms) : 0, 655342
BytebuddyAgent [candidate] (651.808 ms) : 0, 651808
GlobalTracer [baseline] (311.83 ms) : 0, 311830
GlobalTracer [candidate] (312.659 ms) : 0, 312659
AppSec [baseline] (49.604 ms) : 0, 49604
AppSec [candidate] (49.491 ms) : 0, 49491
Remote Config [baseline] (657.85 µs) : 0, 658
Remote Config [candidate] (660.035 µs) : 0, 660
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.54 ms) : 0, 7540
section appsec
BytebuddyAgent [baseline] (674.965 ms) : 0, 674965
BytebuddyAgent [candidate] (674.564 ms) : 0, 674564
GlobalTracer [baseline] (295.491 ms) : 0, 295491
GlobalTracer [candidate] (296.373 ms) : 0, 296373
AppSec [baseline] (152.872 ms) : 0, 152872
AppSec [candidate] (152.836 ms) : 0, 152836
Remote Config [baseline] (618.598 µs) : 0, 619
Remote Config [candidate] (621.564 µs) : 0, 622
Telemetry [baseline] (8.095 ms) : 0, 8095
Telemetry [candidate] (8.413 ms) : 0, 8413
IAST [baseline] (18.775 ms) : 0, 18775
IAST [candidate] (18.748 ms) : 0, 18748
section iast
BytebuddyAgent [baseline] (782.11 ms) : 0, 782110
BytebuddyAgent [candidate] (779.35 ms) : 0, 779350
GlobalTracer [baseline] (292.897 ms) : 0, 292897
GlobalTracer [candidate] (292.653 ms) : 0, 292653
AppSec [baseline] (49.868 ms) : 0, 49868
AppSec [candidate] (48.562 ms) : 0, 48562
Remote Config [baseline] (595.353 µs) : 0, 595
Remote Config [candidate] (593.569 µs) : 0, 594
Telemetry [baseline] (8.523 ms) : 0, 8523
Telemetry [candidate] (8.444 ms) : 0, 8444
IAST [baseline] (23.229 ms) : 0, 23229
IAST [candidate] (23.991 ms) : 0, 23991
section profiling
BytebuddyAgent [baseline] (661.129 ms) : 0, 661129
BytebuddyAgent [candidate] (660.142 ms) : 0, 660142
GlobalTracer [baseline] (384.636 ms) : 0, 384636
GlobalTracer [candidate] (384.576 ms) : 0, 384576
AppSec [baseline] (50.5 ms) : 0, 50500
AppSec [candidate] (50.229 ms) : 0, 50229
Remote Config [baseline] (784.439 µs) : 0, 784
Remote Config [candidate] (892.448 µs) : 0, 892
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (7.488 ms) : 0, 7488
ProfilingAgent [baseline] (95.526 ms) : 0, 95526
ProfilingAgent [candidate] (95.405 ms) : 0, 95405
Profiling [baseline] (95.55 ms) : 0, 95550
Profiling [candidate] (95.429 ms) : 0, 95429
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-03T12:37:40 2024-06-03T12:44:31
git_branch master mcculls/report-dynamic-sampling-change-to-telemetry
git_commit_date 1717412897 1717416568
git_commit_sha b2807ad 718e512
release_version 1.35.0-SNAPSHOT~b2807adfa7 1.35.0-SNAPSHOT~718e512043
start_time 2024-06-03T12:37:27 2024-06-03T12:44:17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717419016 1717419016
ci_job_id 530193512 530193512
ci_pipeline_id 35683347 35683347
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.748 µs) : 358, 399
.   : milestone, 379,
iast (485.554 µs) : 464, 507
.   : milestone, 486,
iast_FULL (553.441 µs) : 532, 575
.   : milestone, 553,
iast_GLOBAL (502.95 µs) : 482, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (488.4 µs) : 467, 510
.   : milestone, 488,
iast_INACTIVE (452.106 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (480.338 µs) : 458, 502
.   : milestone, 480,
tracing (446.871 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (369.839 µs) : 350, 390
.   : milestone, 370,
iast (485.932 µs) : 465, 507
.   : milestone, 486,
iast_FULL (554.615 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (515.616 µs) : 494, 537
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (486.531 µs) : 465, 508
.   : milestone, 487,
iast_INACTIVE (458.945 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (478.717 µs) : 457, 500
.   : milestone, 479,
tracing (444.528 µs) : 424, 465
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.748 µs [358.366 µs, 399.131 µs] -
iast 485.554 µs [464.406 µs, 506.702 µs] 106.806 µs (28.2%)
iast_FULL 553.441 µs [532.273 µs, 574.608 µs] 174.693 µs (46.1%)
iast_GLOBAL 502.95 µs [482.022 µs, 523.878 µs] 124.201 µs (32.8%)
iast_HARDCODED_SECRET_DISABLED 488.4 µs [467.171 µs, 509.63 µs] 109.652 µs (29.0%)
iast_INACTIVE 452.106 µs [431.294 µs, 472.918 µs] 73.358 µs (19.4%)
iast_TELEMETRY_OFF 480.338 µs [458.264 µs, 502.413 µs] 101.59 µs (26.8%)
tracing 446.871 µs [425.95 µs, 467.792 µs] 68.123 µs (18.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.839 µs [349.792 µs, 389.887 µs] -
iast 485.932 µs [464.792 µs, 507.073 µs] 116.093 µs (31.4%)
iast_FULL 554.615 µs [533.546 µs, 575.684 µs] 184.776 µs (50.0%)
iast_GLOBAL 515.616 µs [494.109 µs, 537.122 µs] 145.776 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 486.531 µs [465.225 µs, 507.836 µs] 116.691 µs (31.6%)
iast_INACTIVE 458.945 µs [437.823 µs, 480.068 µs] 89.106 µs (24.1%)
iast_TELEMETRY_OFF 478.717 µs [457.197 µs, 500.238 µs] 108.878 µs (29.4%)
tracing 444.528 µs [424.222 µs, 464.835 µs] 74.689 µs (20.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1389
.   : milestone, 1369,
appsec (1.734 ms) : 1710, 1758
.   : milestone, 1734,
appsec_no_iast (1.726 ms) : 1701, 1751
.   : milestone, 1726,
iast (1.493 ms) : 1470, 1517
.   : milestone, 1493,
profiling (1.505 ms) : 1480, 1531
.   : milestone, 1505,
tracing (1.479 ms) : 1454, 1503
.   : milestone, 1479,
section candidate
no_agent (1.354 ms) : 1335, 1372
.   : milestone, 1354,
appsec (1.729 ms) : 1704, 1754
.   : milestone, 1729,
appsec_no_iast (1.722 ms) : 1697, 1747
.   : milestone, 1722,
iast (1.484 ms) : 1459, 1508
.   : milestone, 1484,
profiling (1.48 ms) : 1455, 1505
.   : milestone, 1480,
tracing (1.47 ms) : 1445, 1495
.   : milestone, 1470,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.35 ms, 1.389 ms] -
appsec 1.734 ms [1.71 ms, 1.758 ms] 364.231 µs (26.6%)
appsec_no_iast 1.726 ms [1.701 ms, 1.751 ms] 356.502 µs (26.0%)
iast 1.493 ms [1.47 ms, 1.517 ms] 123.774 µs (9.0%)
profiling 1.505 ms [1.48 ms, 1.531 ms] 135.706 µs (9.9%)
tracing 1.479 ms [1.454 ms, 1.503 ms] 109.217 µs (8.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.372 ms] -
appsec 1.729 ms [1.704 ms, 1.754 ms] 374.962 µs (27.7%)
appsec_no_iast 1.722 ms [1.697 ms, 1.747 ms] 368.118 µs (27.2%)
iast 1.484 ms [1.459 ms, 1.508 ms] 129.818 µs (9.6%)
profiling 1.48 ms [1.455 ms, 1.505 ms] 125.951 µs (9.3%)
tracing 1.47 ms [1.445 ms, 1.495 ms] 115.936 µs (8.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/report-dynamic-sampling-change-to-telemetry
git_commit_date 1717412897 1717416568
git_commit_sha b2807ad 718e512
release_version 1.35.0-SNAPSHOT~b2807adfa7 1.35.0-SNAPSHOT~718e512043
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717419504 1717419504
ci_job_id 530193514 530193514
ci_pipeline_id 35683347 35683347
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
appsec (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,
iast (18.774 s) : 18774000, 18774000
.   : milestone, 18774000,
iast_GLOBAL (17.836 s) : 17836000, 17836000
.   : milestone, 17836000,
profiling (15.655 s) : 15655000, 15655000
.   : milestone, 15655000,
tracing (14.885 s) : 14885000, 14885000
.   : milestone, 14885000,
section candidate
no_agent (15.585 s) : 15585000, 15585000
.   : milestone, 15585000,
appsec (15.135 s) : 15135000, 15135000
.   : milestone, 15135000,
iast (18.895 s) : 18895000, 18895000
.   : milestone, 18895000,
iast_GLOBAL (17.988 s) : 17988000, 17988000
.   : milestone, 17988000,
profiling (14.977 s) : 14977000, 14977000
.   : milestone, 14977000,
tracing (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.113 s [15.113 s, 15.113 s] -
appsec 15.133 s [15.133 s, 15.133 s] 20.0 ms (0.1%)
iast 18.774 s [18.774 s, 18.774 s] 3.661 s (24.2%)
iast_GLOBAL 17.836 s [17.836 s, 17.836 s] 2.723 s (18.0%)
profiling 15.655 s [15.655 s, 15.655 s] 542.0 ms (3.6%)
tracing 14.885 s [14.885 s, 14.885 s] -228.0 ms (-1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.585 s [15.585 s, 15.585 s] -
appsec 15.135 s [15.135 s, 15.135 s] -450.0 ms (-2.9%)
iast 18.895 s [18.895 s, 18.895 s] 3.31 s (21.2%)
iast_GLOBAL 17.988 s [17.988 s, 17.988 s] 2.403 s (15.4%)
profiling 14.977 s [14.977 s, 14.977 s] -608.0 ms (-3.9%)
tracing 14.993 s [14.993 s, 14.993 s] -592.0 ms (-3.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~718e512043, baseline=1.35.0-SNAPSHOT~b2807adfa7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.204 ms) : 2170, 2239
.   : milestone, 2204,
iast (1.969 ms) : 1928, 2010
.   : milestone, 1969,
iast_GLOBAL (1.987 ms) : 1946, 2028
.   : milestone, 1987,
profiling (1.835 ms) : 1803, 1868
.   : milestone, 1835,
tracing (1.835 ms) : 1802, 1867
.   : milestone, 1835,
section candidate
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.202 ms) : 2168, 2237
.   : milestone, 2202,
iast (1.963 ms) : 1922, 2004
.   : milestone, 1963,
iast_GLOBAL (2.003 ms) : 1962, 2045
.   : milestone, 2003,
profiling (1.847 ms) : 1814, 1879
.   : milestone, 1847,
tracing (1.825 ms) : 1792, 1857
.   : milestone, 1825,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.204 ms [2.17 ms, 2.239 ms] 739.98 µs (50.5%)
iast 1.969 ms [1.928 ms, 2.01 ms] 504.468 µs (34.5%)
iast_GLOBAL 1.987 ms [1.946 ms, 2.028 ms] 522.623 µs (35.7%)
profiling 1.835 ms [1.803 ms, 1.868 ms] 370.961 µs (25.3%)
tracing 1.835 ms [1.802 ms, 1.867 ms] 370.512 µs (25.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.202 ms [2.168 ms, 2.237 ms] 745.025 µs (51.1%)
iast 1.963 ms [1.922 ms, 2.004 ms] 505.821 µs (34.7%)
iast_GLOBAL 2.003 ms [1.962 ms, 2.045 ms] 545.986 µs (37.5%)
profiling 1.847 ms [1.814 ms, 1.879 ms] 389.236 µs (26.7%)
tracing 1.825 ms [1.792 ms, 1.857 ms] 367.425 µs (25.2%)

PerfectSlayer
PerfectSlayer approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor nitpicks

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java Outdated Show resolved Hide resolved
dd-trace-core/src/main/java/datadog/trace/core/TracingConfigPoller.java Show resolved Hide resolved
@mcculls mcculls force-pushed the mcculls/report-dynamic-sampling-change-to-telemetry branch from c1b4533 to 836f422 Compare June 3, 2024 09:05
@mcculls mcculls force-pushed the mcculls/report-dynamic-sampling-change-to-telemetry branch from 836f422 to 718e512 Compare June 3, 2024 12:09
@mcculls mcculls merged commit fc48681 into master Jun 3, 2024
79 of 81 checks passed
@mcculls mcculls deleted the mcculls/report-dynamic-sampling-change-to-telemetry branch June 3, 2024 13:17
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: telemetry Telemetry
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @PerfectSlayer