Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🍒 7404] Fix ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor when instrumenting Kafka 3.7 with Quarkus native #7422

Merged

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Aug 13, 2024

What Does This Do

Relocate embedded jpountz classes to avoid conflict with flat class-path when using GraalVM native-images.

In this case both the Java tracer and Kafka 3.7 contained net.jpountz LZ4 classes at slightly different versions.

Jira ticket: APMS-12871

@mcculls mcculls added the comp: native-image GraalVM native-image label Aug 13, 2024
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as #7404

@mcculls mcculls marked this pull request as ready for review August 13, 2024 17:48
@mcculls mcculls requested a review from a team as a code owner August 13, 2024 17:48
@mcculls mcculls requested review from dougqh and nayeem-kamal August 13, 2024 17:48
@mcculls mcculls merged commit 67e3325 into release/v1.38.x Aug 13, 2024
79 checks passed
@mcculls mcculls deleted the mcculls/relocate-embedded-jpountz-classes-backport branch August 13, 2024 17:48
@smola smola added this to the 1.38.1 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants