Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍒 7388] Add _dd.tracer_host to local root spans #7426

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[🍒 7388] Add _dd.tracer_host to local root spans #7426

merged 2 commits into from
Aug 13, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Cherry picked from https://github.com/DataDog/dd-trace-java/pull/7388/files

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner August 13, 2024 15:25
@amarziali amarziali added the comp: core Tracer core label Aug 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 13, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/backport-dd-hostname
git_commit_date 1723559987 1723564468
git_commit_sha d81dc14 55b50d8
release_version 1.39.0-SNAPSHOT~d81dc1416e 1.39.0-SNAPSHOT~55b50d8136
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723566656 1723566656
ci_job_id 603644809 603644809
ci_pipeline_id 41625190 41625190
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045060
Total [baseline] (8.491 s) : 0, 8490668
Agent [candidate] (1.048 s) : 0, 1047513
Total [candidate] (8.48 s) : 0, 8479818
section iast
Agent [baseline] (1.183 s) : 0, 1182581
Total [baseline] (8.992 s) : 0, 8991798
Agent [candidate] (1.172 s) : 0, 1171730
Total [candidate] (8.998 s) : 0, 8998192
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173961
Total [baseline] (8.964 s) : 0, 8963595
Agent [candidate] (1.175 s) : 0, 1174852
Total [candidate] (8.951 s) : 0, 8950744
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170487
Total [baseline] (8.959 s) : 0, 8958967
Agent [candidate] (1.171 s) : 0, 1170817
Total [candidate] (8.962 s) : 0, 8962113
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.183 s 137.521 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 128.901 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.17 s 125.427 ms (12.0%)
Total tracing 8.491 s -
Total iast 8.992 s 501.13 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.964 s 472.927 ms (5.6%)
Total iast_TELEMETRY_OFF 8.959 s 468.298 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.172 s 124.217 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 127.338 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.171 s 123.304 ms (11.8%)
Total tracing 8.48 s -
Total iast 8.998 s 518.373 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.951 s 470.926 ms (5.6%)
Total iast_TELEMETRY_OFF 8.962 s 482.295 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.311 ms) : 0, 666311
BytebuddyAgent [candidate] (670.677 ms) : 0, 670677
GlobalTracer [baseline] (306.255 ms) : 0, 306255
GlobalTracer [candidate] (305.183 ms) : 0, 305183
AppSec [baseline] (50.993 ms) : 0, 50993
AppSec [candidate] (50.156 ms) : 0, 50156
Remote Config [baseline] (677.878 µs) : 0, 678
Remote Config [candidate] (677.795 µs) : 0, 678
Telemetry [baseline] (7.443 ms) : 0, 7443
Telemetry [candidate] (7.343 ms) : 0, 7343
section iast
BytebuddyAgent [baseline] (787.585 ms) : 0, 787585
BytebuddyAgent [candidate] (781.511 ms) : 0, 781511
GlobalTracer [baseline] (298.135 ms) : 0, 298135
GlobalTracer [candidate] (294.619 ms) : 0, 294619
AppSec [baseline] (51.235 ms) : 0, 51235
AppSec [candidate] (52.431 ms) : 0, 52431
IAST [baseline] (24.344 ms) : 0, 24344
IAST [candidate] (21.164 ms) : 0, 21164
Remote Config [baseline] (598.633 µs) : 0, 599
Remote Config [candidate] (590.466 µs) : 0, 590
Telemetry [baseline] (7.154 ms) : 0, 7154
Telemetry [candidate] (7.936 ms) : 0, 7936
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.372 ms) : 0, 781372
BytebuddyAgent [candidate] (782.336 ms) : 0, 782336
GlobalTracer [baseline] (296.637 ms) : 0, 296637
GlobalTracer [candidate] (295.763 ms) : 0, 295763
AppSec [baseline] (48.737 ms) : 0, 48737
AppSec [candidate] (51.547 ms) : 0, 51547
IAST [baseline] (24.355 ms) : 0, 24355
IAST [candidate] (23.35 ms) : 0, 23350
Remote Config [baseline] (579.86 µs) : 0, 580
Remote Config [candidate] (564.393 µs) : 0, 564
Telemetry [baseline] (8.781 ms) : 0, 8781
Telemetry [candidate] (7.728 ms) : 0, 7728
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.903 ms) : 0, 777903
BytebuddyAgent [candidate] (779.396 ms) : 0, 779396
GlobalTracer [baseline] (296.547 ms) : 0, 296547
GlobalTracer [candidate] (295.442 ms) : 0, 295442
AppSec [baseline] (49.882 ms) : 0, 49882
AppSec [candidate] (47.516 ms) : 0, 47516
IAST [baseline] (24.381 ms) : 0, 24381
IAST [candidate] (26.749 ms) : 0, 26749
Remote Config [baseline] (607.173 µs) : 0, 607
Remote Config [candidate] (602.542 µs) : 0, 603
Telemetry [baseline] (7.743 ms) : 0, 7743
Telemetry [candidate] (7.623 ms) : 0, 7623
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045528
Total [baseline] (10.379 s) : 0, 10379227
Agent [candidate] (1.055 s) : 0, 1055190
Total [candidate] (10.35 s) : 0, 10349665
section appsec
Agent [baseline] (1.169 s) : 0, 1169066
Total [baseline] (10.512 s) : 0, 10511543
Agent [candidate] (1.163 s) : 0, 1162977
Total [candidate] (10.439 s) : 0, 10439427
section iast
Agent [baseline] (1.176 s) : 0, 1175606
Total [baseline] (10.793 s) : 0, 10792815
Agent [candidate] (1.172 s) : 0, 1172195
Total [candidate] (10.821 s) : 0, 10821407
section profiling
Agent [baseline] (1.253 s) : 0, 1252519
Total [baseline] (10.591 s) : 0, 10590832
Agent [candidate] (1.244 s) : 0, 1243589
Total [candidate] (10.656 s) : 0, 10655732
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.169 s 123.538 ms (11.8%)
Agent iast 1.176 s 130.078 ms (12.4%)
Agent profiling 1.253 s 206.991 ms (19.8%)
Total tracing 10.379 s -
Total appsec 10.512 s 132.316 ms (1.3%)
Total iast 10.793 s 413.588 ms (4.0%)
Total profiling 10.591 s 211.606 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.163 s 107.788 ms (10.2%)
Agent iast 1.172 s 117.005 ms (11.1%)
Agent profiling 1.244 s 188.399 ms (17.9%)
Total tracing 10.35 s -
Total appsec 10.439 s 89.762 ms (0.9%)
Total iast 10.821 s 471.742 ms (4.6%)
Total profiling 10.656 s 306.067 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.686 ms) : 0, 666686
BytebuddyAgent [candidate] (673.345 ms) : 0, 673345
GlobalTracer [baseline] (306.346 ms) : 0, 306346
GlobalTracer [candidate] (309.098 ms) : 0, 309098
AppSec [baseline] (50.909 ms) : 0, 50909
AppSec [candidate] (50.952 ms) : 0, 50952
Remote Config [baseline] (680.589 µs) : 0, 681
Remote Config [candidate] (707.431 µs) : 0, 707
Telemetry [baseline] (7.481 ms) : 0, 7481
Telemetry [candidate] (7.545 ms) : 0, 7545
section appsec
BytebuddyAgent [baseline] (677.417 ms) : 0, 677417
BytebuddyAgent [candidate] (676.839 ms) : 0, 676839
GlobalTracer [baseline] (300.213 ms) : 0, 300213
GlobalTracer [candidate] (298.08 ms) : 0, 298080
AppSec [baseline] (156.352 ms) : 0, 156352
AppSec [candidate] (155.003 ms) : 0, 155003
IAST [baseline] (22.176 ms) : 0, 22176
IAST [candidate] (22.113 ms) : 0, 22113
Remote Config [baseline] (600.592 µs) : 0, 601
Remote Config [candidate] (600.48 µs) : 0, 600
Telemetry [baseline] (9.918 ms) : 0, 9918
Telemetry [candidate] (7.938 ms) : 0, 7938
section iast
BytebuddyAgent [baseline] (783.058 ms) : 0, 783058
BytebuddyAgent [candidate] (780.955 ms) : 0, 780955
GlobalTracer [baseline] (295.931 ms) : 0, 295931
GlobalTracer [candidate] (294.664 ms) : 0, 294664
AppSec [baseline] (50.582 ms) : 0, 50582
AppSec [candidate] (50.689 ms) : 0, 50689
IAST [baseline] (23.208 ms) : 0, 23208
IAST [candidate] (23.382 ms) : 0, 23382
Remote Config [baseline] (599.86 µs) : 0, 600
Remote Config [candidate] (2.071 ms) : 0, 2071
Telemetry [baseline] (8.703 ms) : 0, 8703
Telemetry [candidate] (6.948 ms) : 0, 6948
section profiling
BytebuddyAgent [baseline] (666.572 ms) : 0, 666572
BytebuddyAgent [candidate] (663.435 ms) : 0, 663435
GlobalTracer [baseline] (392.775 ms) : 0, 392775
GlobalTracer [candidate] (389.376 ms) : 0, 389376
AppSec [baseline] (52.433 ms) : 0, 52433
AppSec [candidate] (51.319 ms) : 0, 51319
Remote Config [baseline] (702.107 µs) : 0, 702
Remote Config [candidate] (692.319 µs) : 0, 692
Telemetry [baseline] (7.454 ms) : 0, 7454
Telemetry [candidate] (7.236 ms) : 0, 7236
ProfilingAgent [baseline] (95.134 ms) : 0, 95134
ProfilingAgent [candidate] (94.408 ms) : 0, 94408
Profiling [baseline] (95.159 ms) : 0, 95159
Profiling [candidate] (94.433 ms) : 0, 94433
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-13T16:01:42 2024-08-13T16:08:28
git_branch master andrea.marziali/backport-dd-hostname
git_commit_date 1723559987 1723564468
git_commit_sha d81dc14 55b50d8
release_version 1.39.0-SNAPSHOT~d81dc1416e 1.39.0-SNAPSHOT~55b50d8136
start_time 2024-08-13T16:01:29 2024-08-13T16:08:15
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723565651 1723565651
ci_job_id 603644810 603644810
ci_pipeline_id 41625190 41625190
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.039 µs) : 341, 381
.   : milestone, 361,
iast (472.286 µs) : 451, 493
.   : milestone, 472,
iast_FULL (544.46 µs) : 522, 567
.   : milestone, 544,
iast_GLOBAL (495.098 µs) : 473, 517
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (477.286 µs) : 456, 499
.   : milestone, 477,
iast_INACTIVE (454.017 µs) : 432, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (467.989 µs) : 447, 489
.   : milestone, 468,
tracing (430.67 µs) : 410, 451
.   : milestone, 431,
section candidate
no_agent (368.066 µs) : 349, 388
.   : milestone, 368,
iast (475.087 µs) : 454, 497
.   : milestone, 475,
iast_FULL (539.872 µs) : 519, 561
.   : milestone, 540,
iast_GLOBAL (502.243 µs) : 481, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (475.767 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (449.775 µs) : 428, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (468.615 µs) : 447, 490
.   : milestone, 469,
tracing (435.044 µs) : 414, 456
.   : milestone, 435,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.039 µs [341.485 µs, 380.592 µs] -
iast 472.286 µs [451.407 µs, 493.165 µs] 111.248 µs (30.8%)
iast_FULL 544.46 µs [521.796 µs, 567.124 µs] 183.421 µs (50.8%)
iast_GLOBAL 495.098 µs [473.225 µs, 516.97 µs] 134.059 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 477.286 µs [455.893 µs, 498.678 µs] 116.247 µs (32.2%)
iast_INACTIVE 454.017 µs [431.578 µs, 476.455 µs] 92.978 µs (25.8%)
iast_TELEMETRY_OFF 467.989 µs [446.884 µs, 489.093 µs] 106.95 µs (29.6%)
tracing 430.67 µs [410.45 µs, 450.89 µs] 69.632 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.066 µs [348.541 µs, 387.591 µs] -
iast 475.087 µs [453.525 µs, 496.65 µs] 107.021 µs (29.1%)
iast_FULL 539.872 µs [518.895 µs, 560.85 µs] 171.806 µs (46.7%)
iast_GLOBAL 502.243 µs [480.779 µs, 523.707 µs] 134.177 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED 475.767 µs [454.636 µs, 496.899 µs] 107.701 µs (29.3%)
iast_INACTIVE 449.775 µs [428.165 µs, 471.385 µs] 81.709 µs (22.2%)
iast_TELEMETRY_OFF 468.615 µs [446.916 µs, 490.313 µs] 100.549 µs (27.3%)
tracing 435.044 µs [414.397 µs, 455.691 µs] 66.978 µs (18.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1313, 1351
.   : milestone, 1332,
appsec (1.69 ms) : 1666, 1714
.   : milestone, 1690,
appsec_no_iast (1.711 ms) : 1687, 1735
.   : milestone, 1711,
iast (1.471 ms) : 1449, 1494
.   : milestone, 1471,
profiling (1.475 ms) : 1451, 1499
.   : milestone, 1475,
tracing (1.467 ms) : 1443, 1490
.   : milestone, 1467,
section candidate
no_agent (1.332 ms) : 1313, 1351
.   : milestone, 1332,
appsec (1.721 ms) : 1697, 1745
.   : milestone, 1721,
appsec_no_iast (1.708 ms) : 1684, 1732
.   : milestone, 1708,
iast (1.455 ms) : 1432, 1477
.   : milestone, 1455,
profiling (1.479 ms) : 1455, 1503
.   : milestone, 1479,
tracing (1.463 ms) : 1440, 1487
.   : milestone, 1463,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.351 ms] -
appsec 1.69 ms [1.666 ms, 1.714 ms] 358.168 µs (26.9%)
appsec_no_iast 1.711 ms [1.687 ms, 1.735 ms] 378.702 µs (28.4%)
iast 1.471 ms [1.449 ms, 1.494 ms] 139.249 µs (10.5%)
profiling 1.475 ms [1.451 ms, 1.499 ms] 143.173 µs (10.7%)
tracing 1.467 ms [1.443 ms, 1.49 ms] 134.478 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.351 ms] -
appsec 1.721 ms [1.697 ms, 1.745 ms] 388.933 µs (29.2%)
appsec_no_iast 1.708 ms [1.684 ms, 1.732 ms] 375.85 µs (28.2%)
iast 1.455 ms [1.432 ms, 1.477 ms] 122.326 µs (9.2%)
profiling 1.479 ms [1.455 ms, 1.503 ms] 146.914 µs (11.0%)
tracing 1.463 ms [1.44 ms, 1.487 ms] 130.825 µs (9.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/backport-dd-hostname
git_commit_date 1723559987 1723564468
git_commit_sha d81dc14 55b50d8
release_version 1.39.0-SNAPSHOT~d81dc1416e 1.39.0-SNAPSHOT~55b50d8136
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723566326 1723566326
ci_job_id 603644811 603644811
ci_pipeline_id 41625190 41625190
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.345 s) : 15345000, 15345000
.   : milestone, 15345000,
appsec (15.146 s) : 15146000, 15146000
.   : milestone, 15146000,
iast (18.799 s) : 18799000, 18799000
.   : milestone, 18799000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
.   : milestone, 17839000,
profiling (15.385 s) : 15385000, 15385000
.   : milestone, 15385000,
tracing (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
section candidate
no_agent (15.389 s) : 15389000, 15389000
.   : milestone, 15389000,
appsec (15.179 s) : 15179000, 15179000
.   : milestone, 15179000,
iast (18.713 s) : 18713000, 18713000
.   : milestone, 18713000,
iast_GLOBAL (17.807 s) : 17807000, 17807000
.   : milestone, 17807000,
profiling (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
tracing (14.893 s) : 14893000, 14893000
.   : milestone, 14893000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.345 s [15.345 s, 15.345 s] -
appsec 15.146 s [15.146 s, 15.146 s] -199.0 ms (-1.3%)
iast 18.799 s [18.799 s, 18.799 s] 3.454 s (22.5%)
iast_GLOBAL 17.839 s [17.839 s, 17.839 s] 2.494 s (16.3%)
profiling 15.385 s [15.385 s, 15.385 s] 40.0 ms (0.3%)
tracing 14.962 s [14.962 s, 14.962 s] -383.0 ms (-2.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.389 s [15.389 s, 15.389 s] -
appsec 15.179 s [15.179 s, 15.179 s] -210.0 ms (-1.4%)
iast 18.713 s [18.713 s, 18.713 s] 3.324 s (21.6%)
iast_GLOBAL 17.807 s [17.807 s, 17.807 s] 2.418 s (15.7%)
profiling 14.993 s [14.993 s, 14.993 s] -396.0 ms (-2.6%)
tracing 14.893 s [14.893 s, 14.893 s] -496.0 ms (-3.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~55b50d8136, baseline=1.39.0-SNAPSHOT~d81dc1416e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.222 ms) : 2188, 2257
.   : milestone, 2222,
iast (1.958 ms) : 1917, 2000
.   : milestone, 1958,
iast_GLOBAL (2.017 ms) : 1975, 2060
.   : milestone, 2017,
profiling (1.878 ms) : 1841, 1914
.   : milestone, 1878,
tracing (1.847 ms) : 1814, 1880
.   : milestone, 1847,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.225 ms) : 2190, 2260
.   : milestone, 2225,
iast (1.97 ms) : 1929, 2011
.   : milestone, 1970,
iast_GLOBAL (2.013 ms) : 1971, 2055
.   : milestone, 2013,
profiling (1.866 ms) : 1830, 1902
.   : milestone, 1866,
tracing (1.845 ms) : 1812, 1879
.   : milestone, 1845,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.222 ms [2.188 ms, 2.257 ms] 763.032 µs (52.3%)
iast 1.958 ms [1.917 ms, 2.0 ms] 499.093 µs (34.2%)
iast_GLOBAL 2.017 ms [1.975 ms, 2.06 ms] 557.893 µs (38.2%)
profiling 1.878 ms [1.841 ms, 1.914 ms] 418.493 µs (28.7%)
tracing 1.847 ms [1.814 ms, 1.88 ms] 387.454 µs (26.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.225 ms [2.19 ms, 2.26 ms] 760.031 µs (51.9%)
iast 1.97 ms [1.929 ms, 2.011 ms] 504.499 µs (34.4%)
iast_GLOBAL 2.013 ms [1.971 ms, 2.055 ms] 547.718 µs (37.4%)
profiling 1.866 ms [1.83 ms, 1.902 ms] 400.84 µs (27.4%)
tracing 1.845 ms [1.812 ms, 1.879 ms] 380.199 µs (25.9%)

@amarziali amarziali merged commit 35e8f3d into release/v1.38.x Aug 13, 2024
75 of 77 checks passed
@amarziali amarziali deleted the andrea.marziali/backport-dd-hostname branch August 13, 2024 16:42
@smola smola changed the title Add _dd.tracer_host to local root spans [🍒 7388] Add _dd.tracer_host to local root spans Aug 14, 2024
@smola smola added this to the 1.38.1 milestone Aug 14, 2024
@mcculls mcculls mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core
Projects
None yet
Milestone
1.38.1
Development

Successfully merging this pull request may close these issues.
3 participants
@amarziali @mcculls @smola