Fix Fingerprinter thread safety

[jpbempel]

What Does This Do

Create MessageDigest instance each time we are fingerprinting

Motivation

Fix thread safety issue

Additional Notes

Contributor Checklist

• Format the title according the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any usefull labels
• Squash your commits prior merging or merge using GitHub's Squash and merge
• Don't use close, fix or any linking keywords when referencing an issue.
  Use solves instead, and assign the PR milestone to the issue
• Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

[pr-commenter]

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1723629354	1723629746
end_time	2024-08-14T09:57:08	2024-08-14T10:03:38
git_branch	master	jpbempel/fix-fingerprinter-thread-safety
git_commit_sha	4c58087	43465be
start_time	2024-08-14T09:55:55	2024-08-14T10:02:26

See matching parameters

	Baseline	Candidate
ci_job_id	604651381	604651381
ci_pipeline_id	41739546	41739546
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1723628848	1723628848

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 8 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	better [-651.208µs; -531.815µs] or [-5.941%; -4.852%]	better [-670.585µs; -530.705µs] or [-6.018%; -4.763%]	better [-673.798µs; -503.252µs] or [-6.003%; -4.483%]	better [-841.317µs; -368.103µs] or [-7.233%; -3.165%]	better [+3.285op/s; +5.853op/s] or [+3.695%; +6.585%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-42.242µs; +59.658µs] or [-16.025%; +22.631%]	unstable [-58.103µs; +68.732µs] or [-19.181%; +22.690%]	unstable [-73.625µs; +85.555µs] or [-23.039%; +26.772%]	unstable [-367.789µs; +957.329µs] or [-55.728%; +145.057%]	unstable [-98.905op/s; +172.952op/s] or [-3.659%; +6.399%]
scenario:basic	same	same	unstable [-17.958µs; +15.202µs] or [-5.810%; +4.919%]	unstable [-51.952µs; +57.252µs] or [-8.555%; +9.428%]	unstable [-123.968op/s; +258.920op/s] or [-4.835%; +10.098%]

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (302.915 µs) : 254, 352
.   : milestone, 303,
basic (299.633 µs) : 290, 309
.   : milestone, 300,
loop (11.143 ms) : 11059, 11228
.   : milestone, 11143,
section candidate
noprobe (308.23 µs) : 238, 378
.   : milestone, 308,
basic (296.093 µs) : 281, 311
.   : milestone, 296,
loop (10.543 ms) : 10506, 10579
.   : milestone, 10543,

Loading

• baseline results

Scenario	Request median duration [CI 0.99]
noprobe	302.915 µs [253.966 µs, 351.864 µs]
basic	299.633 µs [289.965 µs, 309.301 µs]
loop	11.143 ms [11.059 ms, 11.228 ms]

• candidate results

Scenario	Request median duration [CI 0.99]
noprobe	308.23 µs [238.006 µs, 378.453 µs]
basic	296.093 µs [281.201 µs, 310.985 µs]
loop	10.543 ms [10.506 ms, 10.579 ms]