Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using stdout to report bootstrapping errors #7432

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Avoid using stdout to report bootstrapping errors #7432

merged 1 commit into from
Aug 14, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Aug 14, 2024 •
edited
Loading

What Does This Do

This PR removes usage of stdout for reporting agent bootrapping errors.

Motivation

Using stdout instead of stderr breaks CLI tools used in shell sub-commands if anything goes wrong.

Additional Notes

Solves #7413

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested a review from a team as a code owner August 14, 2024 10:08
@PerfectSlayer PerfectSlayer requested review from mcculls and ygree August 14, 2024 10:08
This was referenced Aug 14, 2024
Merged
Closed
@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/bootstrap-logging
git_commit_date 1723631065 1723632804
git_commit_sha a56a624 ca005cd
release_version 1.39.0-SNAPSHOT~a56a624469 1.39.0-SNAPSHOT~ca005cd40f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723635285 1723635285
ci_job_id 604729234 604729234
ci_pipeline_id 41744438 41744438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054901
Total [baseline] (8.507 s) : 0, 8506780
Agent [candidate] (1.047 s) : 0, 1046664
Total [candidate] (8.477 s) : 0, 8477431
section iast
Agent [baseline] (1.175 s) : 0, 1174737
Total [baseline] (8.968 s) : 0, 8968312
Agent [candidate] (1.183 s) : 0, 1182534
Total [candidate] (9.005 s) : 0, 9004994
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1184073
Total [baseline] (8.968 s) : 0, 8968100
Agent [candidate] (1.195 s) : 0, 1194717
Total [candidate] (9.016 s) : 0, 9016409
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172932
Total [baseline] (9.033 s) : 0, 9033465
Agent [candidate] (1.17 s) : 0, 1169822
Total [candidate] (8.97 s) : 0, 8969806
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.175 s 119.836 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 129.171 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.173 s 118.031 ms (11.2%)
Total tracing 8.507 s -
Total iast 8.968 s 461.532 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.968 s 461.321 ms (5.4%)
Total iast_TELEMETRY_OFF 9.033 s 526.686 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.183 s 135.871 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.195 s 148.053 ms (14.1%)
Agent iast_TELEMETRY_OFF 1.17 s 123.158 ms (11.8%)
Total tracing 8.477 s -
Total iast 9.005 s 527.563 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.016 s 538.978 ms (6.4%)
Total iast_TELEMETRY_OFF 8.97 s 492.375 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.236 ms) : 0, 673236
BytebuddyAgent [candidate] (667.557 ms) : 0, 667557
GlobalTracer [baseline] (308.681 ms) : 0, 308681
GlobalTracer [candidate] (306.495 ms) : 0, 306495
AppSec [baseline] (51.234 ms) : 0, 51234
AppSec [candidate] (51.064 ms) : 0, 51064
Remote Config [baseline] (683.509 µs) : 0, 684
Remote Config [candidate] (682.645 µs) : 0, 683
Telemetry [baseline] (7.552 ms) : 0, 7552
Telemetry [candidate] (7.471 ms) : 0, 7471
section iast
BytebuddyAgent [baseline] (781.72 ms) : 0, 781720
BytebuddyAgent [candidate] (787.061 ms) : 0, 787061
GlobalTracer [baseline] (295.924 ms) : 0, 295924
GlobalTracer [candidate] (297.966 ms) : 0, 297966
AppSec [baseline] (53.067 ms) : 0, 53067
AppSec [candidate] (50.893 ms) : 0, 50893
IAST [baseline] (22.967 ms) : 0, 22967
IAST [candidate] (23.851 ms) : 0, 23851
Remote Config [baseline] (559.934 µs) : 0, 560
Remote Config [candidate] (572.855 µs) : 0, 573
Telemetry [baseline] (7.057 ms) : 0, 7057
Telemetry [candidate] (8.687 ms) : 0, 8687
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.215 ms) : 0, 788215
BytebuddyAgent [candidate] (795.157 ms) : 0, 795157
GlobalTracer [baseline] (298.195 ms) : 0, 298195
GlobalTracer [candidate] (301.564 ms) : 0, 301564
AppSec [baseline] (49.531 ms) : 0, 49531
AppSec [candidate] (50.641 ms) : 0, 50641
IAST [baseline] (25.902 ms) : 0, 25902
IAST [candidate] (24.277 ms) : 0, 24277
Remote Config [baseline] (581.581 µs) : 0, 582
Remote Config [candidate] (580.663 µs) : 0, 581
Telemetry [baseline] (8.075 ms) : 0, 8075
Telemetry [candidate] (8.795 ms) : 0, 8795
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.724 ms) : 0, 779724
BytebuddyAgent [candidate] (777.74 ms) : 0, 777740
GlobalTracer [baseline] (297.228 ms) : 0, 297228
GlobalTracer [candidate] (296.232 ms) : 0, 296232
AppSec [baseline] (52.938 ms) : 0, 52938
AppSec [candidate] (50.691 ms) : 0, 50691
IAST [baseline] (20.877 ms) : 0, 20877
IAST [candidate] (24.009 ms) : 0, 24009
Remote Config [baseline] (1.392 ms) : 0, 1392
Remote Config [candidate] (613.967 µs) : 0, 614
Telemetry [baseline] (7.269 ms) : 0, 7269
Telemetry [candidate] (7.049 ms) : 0, 7049
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045768
Total [baseline] (10.483 s) : 0, 10482779
Agent [candidate] (1.048 s) : 0, 1047608
Total [candidate] (10.399 s) : 0, 10399138
section appsec
Agent [baseline] (1.167 s) : 0, 1166912
Total [baseline] (10.474 s) : 0, 10473979
Agent [candidate] (1.168 s) : 0, 1167579
Total [candidate] (10.448 s) : 0, 10448340
section iast
Agent [baseline] (1.183 s) : 0, 1182693
Total [baseline] (10.892 s) : 0, 10892009
Agent [candidate] (1.186 s) : 0, 1186123
Total [candidate] (10.805 s) : 0, 10804868
section profiling
Agent [baseline] (1.245 s) : 0, 1244882
Total [baseline] (10.587 s) : 0, 10586961
Agent [candidate] (1.244 s) : 0, 1244356
Total [candidate] (10.599 s) : 0, 10598952
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.167 s 121.144 ms (11.6%)
Agent iast 1.183 s 136.925 ms (13.1%)
Agent profiling 1.245 s 199.114 ms (19.0%)
Total tracing 10.483 s -
Total appsec 10.474 s -8.8 ms (-0.1%)
Total iast 10.892 s 409.23 ms (3.9%)
Total profiling 10.587 s 104.182 ms (1.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.168 s 119.972 ms (11.5%)
Agent iast 1.186 s 138.516 ms (13.2%)
Agent profiling 1.244 s 196.749 ms (18.8%)
Total tracing 10.399 s -
Total appsec 10.448 s 49.203 ms (0.5%)
Total iast 10.805 s 405.73 ms (3.9%)
Total profiling 10.599 s 199.814 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.008 ms) : 0, 667008
BytebuddyAgent [candidate] (668.555 ms) : 0, 668555
GlobalTracer [baseline] (306.288 ms) : 0, 306288
GlobalTracer [candidate] (306.51 ms) : 0, 306510
AppSec [baseline] (50.877 ms) : 0, 50877
AppSec [candidate] (50.886 ms) : 0, 50886
Remote Config [baseline] (681.123 µs) : 0, 681
Remote Config [candidate] (689.077 µs) : 0, 689
Telemetry [baseline] (7.496 ms) : 0, 7496
Telemetry [candidate] (7.516 ms) : 0, 7516
section appsec
BytebuddyAgent [baseline] (676.488 ms) : 0, 676488
BytebuddyAgent [candidate] (676.257 ms) : 0, 676257
GlobalTracer [baseline] (299.719 ms) : 0, 299719
GlobalTracer [candidate] (299.808 ms) : 0, 299808
AppSec [baseline] (157.147 ms) : 0, 157147
AppSec [candidate] (157.021 ms) : 0, 157021
Remote Config [baseline] (596.249 µs) : 0, 596
Remote Config [candidate] (595.155 µs) : 0, 595
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (9.961 ms) : 0, 9961
IAST [baseline] (21.48 ms) : 0, 21480
IAST [candidate] (20.93 ms) : 0, 20930
section iast
BytebuddyAgent [baseline] (787.136 ms) : 0, 787136
BytebuddyAgent [candidate] (788.863 ms) : 0, 788863
GlobalTracer [baseline] (298.129 ms) : 0, 298129
GlobalTracer [candidate] (298.578 ms) : 0, 298578
AppSec [baseline] (52.641 ms) : 0, 52641
AppSec [candidate] (52.825 ms) : 0, 52825
Remote Config [baseline] (595.428 µs) : 0, 595
Remote Config [candidate] (588.867 µs) : 0, 589
Telemetry [baseline] (7.909 ms) : 0, 7909
Telemetry [candidate] (9.67 ms) : 0, 9670
IAST [baseline] (22.723 ms) : 0, 22723
IAST [candidate] (21.999 ms) : 0, 21999
section profiling
BytebuddyAgent [baseline] (662.168 ms) : 0, 662168
BytebuddyAgent [candidate] (662.383 ms) : 0, 662383
GlobalTracer [baseline] (390.063 ms) : 0, 390063
GlobalTracer [candidate] (390.707 ms) : 0, 390707
AppSec [baseline] (52.352 ms) : 0, 52352
AppSec [candidate] (51.536 ms) : 0, 51536
Remote Config [baseline] (684.963 µs) : 0, 685
Remote Config [candidate] (702.563 µs) : 0, 703
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.397 ms) : 0, 7397
ProfilingAgent [baseline] (95.179 ms) : 0, 95179
ProfilingAgent [candidate] (94.496 ms) : 0, 94496
Profiling [baseline] (95.203 ms) : 0, 95203
Profiling [candidate] (94.52 ms) : 0, 94520
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-14T11:05:42 2024-08-14T11:12:31
git_branch master bbujon/bootstrap-logging
git_commit_date 1723631065 1723632804
git_commit_sha a56a624 ca005cd
release_version 1.39.0-SNAPSHOT~a56a624469 1.39.0-SNAPSHOT~ca005cd40f
start_time 2024-08-14T11:05:29 2024-08-14T11:12:18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723634296 1723634296
ci_job_id 604729235 604729235
ci_pipeline_id 41744438 41744438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.236 µs) : 350, 389
.   : milestone, 369,
iast (480.148 µs) : 459, 501
.   : milestone, 480,
iast_FULL (545.418 µs) : 524, 567
.   : milestone, 545,
iast_GLOBAL (505.654 µs) : 483, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (473.932 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (456.986 µs) : 434, 480
.   : milestone, 457,
iast_TELEMETRY_OFF (474.1 µs) : 452, 496
.   : milestone, 474,
tracing (438.814 µs) : 419, 459
.   : milestone, 439,
section candidate
no_agent (364.63 µs) : 345, 384
.   : milestone, 365,
iast (479.961 µs) : 459, 501
.   : milestone, 480,
iast_FULL (559.099 µs) : 535, 583
.   : milestone, 559,
iast_GLOBAL (501.738 µs) : 479, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (484.229 µs) : 463, 505
.   : milestone, 484,
iast_INACTIVE (456.976 µs) : 434, 480
.   : milestone, 457,
iast_TELEMETRY_OFF (470.886 µs) : 449, 493
.   : milestone, 471,
tracing (440.899 µs) : 420, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.236 µs [349.902 µs, 388.57 µs] -
iast 480.148 µs [459.055 µs, 501.241 µs] 110.912 µs (30.0%)
iast_FULL 545.418 µs [523.506 µs, 567.331 µs] 176.182 µs (47.7%)
iast_GLOBAL 505.654 µs [482.839 µs, 528.469 µs] 136.418 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 473.932 µs [453.297 µs, 494.566 µs] 104.695 µs (28.4%)
iast_INACTIVE 456.986 µs [433.717 µs, 480.254 µs] 87.749 µs (23.8%)
iast_TELEMETRY_OFF 474.1 µs [452.368 µs, 495.831 µs] 104.863 µs (28.4%)
tracing 438.814 µs [418.655 µs, 458.973 µs] 69.578 µs (18.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.63 µs [345.367 µs, 383.894 µs] -
iast 479.961 µs [458.706 µs, 501.216 µs] 115.331 µs (31.6%)
iast_FULL 559.099 µs [534.763 µs, 583.435 µs] 194.468 µs (53.3%)
iast_GLOBAL 501.738 µs [479.393 µs, 524.083 µs] 137.108 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED 484.229 µs [462.994 µs, 505.464 µs] 119.599 µs (32.8%)
iast_INACTIVE 456.976 µs [434.287 µs, 479.665 µs] 92.346 µs (25.3%)
iast_TELEMETRY_OFF 470.886 µs [449.229 µs, 492.543 µs] 106.255 µs (29.1%)
tracing 440.899 µs [420.111 µs, 461.687 µs] 76.268 µs (20.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.368 ms) : 1348, 1387
.   : milestone, 1368,
appsec (1.729 ms) : 1706, 1753
.   : milestone, 1729,
appsec_no_iast (1.727 ms) : 1703, 1750
.   : milestone, 1727,
iast (1.484 ms) : 1461, 1507
.   : milestone, 1484,
profiling (1.481 ms) : 1456, 1506
.   : milestone, 1481,
tracing (1.451 ms) : 1426, 1476
.   : milestone, 1451,
section candidate
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.717 ms) : 1692, 1742
.   : milestone, 1717,
appsec_no_iast (1.723 ms) : 1699, 1747
.   : milestone, 1723,
iast (1.476 ms) : 1453, 1498
.   : milestone, 1476,
profiling (1.477 ms) : 1453, 1502
.   : milestone, 1477,
tracing (1.462 ms) : 1438, 1486
.   : milestone, 1462,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.368 ms [1.348 ms, 1.387 ms] -
appsec 1.729 ms [1.706 ms, 1.753 ms] 361.918 µs (26.5%)
appsec_no_iast 1.727 ms [1.703 ms, 1.75 ms] 359.347 µs (26.3%)
iast 1.484 ms [1.461 ms, 1.507 ms] 116.622 µs (8.5%)
profiling 1.481 ms [1.456 ms, 1.506 ms] 113.184 µs (8.3%)
tracing 1.451 ms [1.426 ms, 1.476 ms] 83.449 µs (6.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.717 ms [1.692 ms, 1.742 ms] 373.956 µs (27.8%)
appsec_no_iast 1.723 ms [1.699 ms, 1.747 ms] 380.253 µs (28.3%)
iast 1.476 ms [1.453 ms, 1.498 ms] 132.789 µs (9.9%)
profiling 1.477 ms [1.453 ms, 1.502 ms] 134.368 µs (10.0%)
tracing 1.462 ms [1.438 ms, 1.486 ms] 119.054 µs (8.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/bootstrap-logging
git_commit_date 1723631065 1723632804
git_commit_sha a56a624 ca005cd
release_version 1.39.0-SNAPSHOT~a56a624469 1.39.0-SNAPSHOT~ca005cd40f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723634814 1723634814
ci_job_id 604729236 604729236
ci_pipeline_id 41744438 41744438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.94 s) : 14940000, 14940000
.   : milestone, 14940000,
appsec (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
iast (18.731 s) : 18731000, 18731000
.   : milestone, 18731000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
.   : milestone, 17937000,
profiling (15.169 s) : 15169000, 15169000
.   : milestone, 15169000,
tracing (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
section candidate
no_agent (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,
appsec (14.854 s) : 14854000, 14854000
.   : milestone, 14854000,
iast (18.684 s) : 18684000, 18684000
.   : milestone, 18684000,
iast_GLOBAL (17.933 s) : 17933000, 17933000
.   : milestone, 17933000,
profiling (15.281 s) : 15281000, 15281000
.   : milestone, 15281000,
tracing (15.024 s) : 15024000, 15024000
.   : milestone, 15024000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.94 s [14.94 s, 14.94 s] -
appsec 15.027 s [15.027 s, 15.027 s] 87.0 ms (0.6%)
iast 18.731 s [18.731 s, 18.731 s] 3.791 s (25.4%)
iast_GLOBAL 17.937 s [17.937 s, 17.937 s] 2.997 s (20.1%)
profiling 15.169 s [15.169 s, 15.169 s] 229.0 ms (1.5%)
tracing 14.922 s [14.922 s, 14.922 s] -18.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.004 s [15.004 s, 15.004 s] -
appsec 14.854 s [14.854 s, 14.854 s] -150.0 ms (-1.0%)
iast 18.684 s [18.684 s, 18.684 s] 3.68 s (24.5%)
iast_GLOBAL 17.933 s [17.933 s, 17.933 s] 2.929 s (19.5%)
profiling 15.281 s [15.281 s, 15.281 s] 277.0 ms (1.8%)
tracing 15.024 s [15.024 s, 15.024 s] 20.0 ms (0.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~ca005cd40f, baseline=1.39.0-SNAPSHOT~a56a624469
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.224 ms) : 2188, 2260
.   : milestone, 2224,
iast (1.948 ms) : 1907, 1989
.   : milestone, 1948,
iast_GLOBAL (2.02 ms) : 1977, 2064
.   : milestone, 2020,
profiling (1.856 ms) : 1821, 1892
.   : milestone, 1856,
tracing (1.823 ms) : 1791, 1856
.   : milestone, 1823,
section candidate
no_agent (1.459 ms) : 1448, 1470
.   : milestone, 1459,
appsec (2.214 ms) : 2179, 2248
.   : milestone, 2214,
iast (1.968 ms) : 1925, 2010
.   : milestone, 1968,
iast_GLOBAL (2.011 ms) : 1969, 2054
.   : milestone, 2011,
profiling (1.846 ms) : 1811, 1881
.   : milestone, 1846,
tracing (1.836 ms) : 1803, 1869
.   : milestone, 1836,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.224 ms [2.188 ms, 2.26 ms] 760.516 µs (52.0%)
iast 1.948 ms [1.907 ms, 1.989 ms] 484.658 µs (33.1%)
iast_GLOBAL 2.02 ms [1.977 ms, 2.064 ms] 557.068 µs (38.1%)
profiling 1.856 ms [1.821 ms, 1.892 ms] 392.735 µs (26.8%)
tracing 1.823 ms [1.791 ms, 1.856 ms] 360.133 µs (24.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.47 ms] -
appsec 2.214 ms [2.179 ms, 2.248 ms] 754.701 µs (51.7%)
iast 1.968 ms [1.925 ms, 2.01 ms] 508.626 µs (34.9%)
iast_GLOBAL 2.011 ms [1.969 ms, 2.054 ms] 552.22 µs (37.8%)
profiling 1.846 ms [1.811 ms, 1.881 ms] 386.821 µs (26.5%)
tracing 1.836 ms [1.803 ms, 1.869 ms] 377.075 µs (25.8%)

@PerfectSlayer
fix(agent): Avoid using stdout to report error
ca005cd 
Using stdout instead of stderr breaks CLI tools used in shell sub-commands if anything goes wrong.
@PerfectSlayer PerfectSlayer force-pushed the bbujon/bootstrap-logging branch from 3904fec to ca005cd Compare August 14, 2024 10:54
@PerfectSlayer PerfectSlayer merged commit b4db634 into master Aug 14, 2024
80 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/bootstrap-logging branch August 14, 2024 14:54
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@mcculls mcculls mcculls approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core type: bug
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PerfectSlayer @mcculls @amarziali