Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍒 7448] Avoid NullPointerException when publishing SNS messages to phone numbers #7449

Merged
merged 2 commits into from
Aug 16, 2024
Merged

[🍒 7448] Avoid NullPointerException when publishing SNS messages to phone numbers #7449

merged 2 commits into from
Aug 16, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Aug 15, 2024 •
edited by jira bot
Loading

What Does This Do

Avoid NPE when only a phone number is provided in an SNS publish request

Motivation

Both topicArn and targetArn are optional for SNS publish requests: https://docs.aws.amazon.com/sns/latest/api/API_Publish.html

Additional Notes

topicARN is required for SNS publish batch requests: https://docs.aws.amazon.com/sns/latest/api/API_PublishBatch.html so we don't need to change that part of the code.

Jira ticket: APMS-13002

@mcculls mcculls added the inst: aws sdk AWS SDK instrumentation label Aug 15, 2024
@mcculls mcculls marked this pull request as ready for review August 15, 2024 18:48
@mcculls mcculls requested a review from a team as a code owner August 15, 2024 18:48
@pr-commenter
Copy link

pr-commenter bot commented Aug 15, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1723748074 1723748453
end_time 2024-08-15T18:55:48 2024-08-15T19:02:08
git_branch master mcculls/sns-npe-fix-backport
git_commit_sha fcd4bc4 b2cc6e8
start_time 2024-08-15T18:54:35 2024-08-15T19:00:54
See matching parameters
Baseline Candidate
ci_job_id 606426106 606426106
ci_pipeline_id 41901075 41901075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1723747380 1723747380

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 9 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-10.174µs; +30.278µs] or [-4.034%; +12.006%]		 unstable
[-16.739µs; +47.388µs] or [-5.817%; +16.468%]		 unstable
[-25.630µs; +60.589µs] or [-8.553%; +20.221%]		 unstable
[-92.871µs; +79.068µs] or [-14.401%; +12.260%]		 same
scenario:basic unstable
[-55.723µs; +17.760µs] or [-19.343%; +6.165%]		 unstable
[-66.315µs; +20.720µs] or [-20.818%; +6.504%]		 unstable
[-68.649µs; +22.861µs] or [-20.947%; +6.975%]		 unstable
[-1140.168µs; +413.914µs] or [-117.216%; +42.553%]		 unstable
[-109.551op/s; +244.504op/s] or [-4.272%; +9.536%]
scenario:loop unsure
[-163.929µs; -2.044µs] or [-1.574%; -0.020%]		 same unsure
[-199.079µs; -2.373µs] or [-1.865%; -0.022%]		 same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (287.766 µs) : 266, 309
.   : milestone, 288,
basic (318.544 µs) : 259, 378
.   : milestone, 319,
loop (10.581 ms) : 10472, 10690
.   : milestone, 10581,
section candidate
noprobe (303.091 µs) : 265, 341
.   : milestone, 303,
basic (295.746 µs) : 286, 306
.   : milestone, 296,
loop (10.499 ms) : 10463, 10535
.   : milestone, 10499,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 287.766 µs [266.424 µs, 309.108 µs]
basic 318.544 µs [259.144 µs, 377.943 µs]
loop 10.581 ms [10.472 ms, 10.69 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 303.091 µs [265.465 µs, 340.716 µs]
basic 295.746 µs [285.914 µs, 305.578 µs]
loop 10.499 ms [10.463 ms, 10.535 ms]

@pr-commenter
Copy link

pr-commenter bot commented Aug 15, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/sns-npe-fix-backport
git_commit_date 1723739593 1723747380
git_commit_sha fcd4bc4 b2cc6e8
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~b2cc6e8aac
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723749885 1723749885
ci_job_id 606426100 606426100
ci_pipeline_id 41901075 41901075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047976
Total [baseline] (8.51 s) : 0, 8509892
Agent [candidate] (1.048 s) : 0, 1047946
Total [candidate] (8.495 s) : 0, 8495188
section iast
Agent [baseline] (1.175 s) : 0, 1175290
Total [baseline] (8.977 s) : 0, 8977278
Agent [candidate] (1.171 s) : 0, 1171278
Total [candidate] (8.964 s) : 0, 8964288
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183434
Total [baseline] (8.959 s) : 0, 8958574
Agent [candidate] (1.169 s) : 0, 1168715
Total [candidate] (8.924 s) : 0, 8924211
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176284
Total [baseline] (9.004 s) : 0, 9004006
Agent [candidate] (1.169 s) : 0, 1169047
Total [candidate] (8.937 s) : 0, 8937145
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.175 s 127.314 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 135.458 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.176 s 128.307 ms (12.2%)
Total tracing 8.51 s -
Total iast 8.977 s 467.387 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.959 s 448.682 ms (5.3%)
Total iast_TELEMETRY_OFF 9.004 s 494.115 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.171 s 123.332 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 120.769 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.169 s 121.101 ms (11.6%)
Total tracing 8.495 s -
Total iast 8.964 s 469.1 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.924 s 429.023 ms (5.1%)
Total iast_TELEMETRY_OFF 8.937 s 441.957 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.595 ms) : 0, 667595
BytebuddyAgent [candidate] (670.127 ms) : 0, 670127
GlobalTracer [baseline] (307.38 ms) : 0, 307380
GlobalTracer [candidate] (306.042 ms) : 0, 306042
AppSec [baseline] (51.254 ms) : 0, 51254
AppSec [candidate] (50.235 ms) : 0, 50235
Remote Config [baseline] (693.843 µs) : 0, 694
Remote Config [candidate] (690.631 µs) : 0, 691
Telemetry [baseline] (7.586 ms) : 0, 7586
Telemetry [candidate] (7.358 ms) : 0, 7358
section iast
BytebuddyAgent [baseline] (782.201 ms) : 0, 782201
BytebuddyAgent [candidate] (781.199 ms) : 0, 781199
GlobalTracer [baseline] (295.886 ms) : 0, 295886
GlobalTracer [candidate] (294.115 ms) : 0, 294115
AppSec [baseline] (52.169 ms) : 0, 52169
AppSec [candidate] (52.704 ms) : 0, 52704
IAST [baseline] (23.846 ms) : 0, 23846
IAST [candidate] (22.308 ms) : 0, 22308
Remote Config [baseline] (610.619 µs) : 0, 611
Remote Config [candidate] (567.247 µs) : 0, 567
Telemetry [baseline] (7.095 ms) : 0, 7095
Telemetry [candidate] (6.914 ms) : 0, 6914
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.744 ms) : 0, 786744
BytebuddyAgent [candidate] (778.578 ms) : 0, 778578
GlobalTracer [baseline] (298.428 ms) : 0, 298428
GlobalTracer [candidate] (294.517 ms) : 0, 294517
AppSec [baseline] (49.326 ms) : 0, 49326
AppSec [candidate] (52.018 ms) : 0, 52018
IAST [baseline] (25.233 ms) : 0, 25233
IAST [candidate] (22.545 ms) : 0, 22545
Remote Config [baseline] (579.346 µs) : 0, 579
Remote Config [candidate] (571.193 µs) : 0, 571
Telemetry [baseline] (9.522 ms) : 0, 9522
Telemetry [candidate] (6.985 ms) : 0, 6985
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.068 ms) : 0, 781068
BytebuddyAgent [candidate] (778.283 ms) : 0, 778283
GlobalTracer [baseline] (298.662 ms) : 0, 298662
GlobalTracer [candidate] (295.31 ms) : 0, 295310
AppSec [baseline] (51.414 ms) : 0, 51414
AppSec [candidate] (46.509 ms) : 0, 46509
IAST [baseline] (23.053 ms) : 0, 23053
IAST [candidate] (28.103 ms) : 0, 28103
Remote Config [baseline] (625.395 µs) : 0, 625
Remote Config [candidate] (592.44 µs) : 0, 592
Telemetry [baseline] (7.887 ms) : 0, 7887
Telemetry [candidate] (6.747 ms) : 0, 6747
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053239
Total [baseline] (10.366 s) : 0, 10365986
Agent [candidate] (1.045 s) : 0, 1045299
Total [candidate] (10.342 s) : 0, 10341664
section appsec
Agent [baseline] (1.167 s) : 0, 1167453
Total [baseline] (10.474 s) : 0, 10474276
Agent [candidate] (1.165 s) : 0, 1164714
Total [candidate] (10.464 s) : 0, 10463744
section iast
Agent [baseline] (1.177 s) : 0, 1177375
Total [baseline] (10.816 s) : 0, 10816290
Agent [candidate] (1.182 s) : 0, 1181871
Total [candidate] (10.872 s) : 0, 10872456
section profiling
Agent [baseline] (1.248 s) : 0, 1248203
Total [baseline] (10.593 s) : 0, 10592875
Agent [candidate] (1.242 s) : 0, 1241661
Total [candidate] (10.624 s) : 0, 10624332
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.167 s 114.215 ms (10.8%)
Agent iast 1.177 s 124.137 ms (11.8%)
Agent profiling 1.248 s 194.964 ms (18.5%)
Total tracing 10.366 s -
Total appsec 10.474 s 108.29 ms (1.0%)
Total iast 10.816 s 450.304 ms (4.3%)
Total profiling 10.593 s 226.888 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.165 s 119.415 ms (11.4%)
Agent iast 1.182 s 136.572 ms (13.1%)
Agent profiling 1.242 s 196.362 ms (18.8%)
Total tracing 10.342 s -
Total appsec 10.464 s 122.081 ms (1.2%)
Total iast 10.872 s 530.792 ms (5.1%)
Total profiling 10.624 s 282.668 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.556 ms) : 0, 672556
BytebuddyAgent [candidate] (667.94 ms) : 0, 667940
GlobalTracer [baseline] (307.664 ms) : 0, 307664
GlobalTracer [candidate] (305.56 ms) : 0, 305560
AppSec [baseline] (51.306 ms) : 0, 51306
AppSec [candidate] (50.331 ms) : 0, 50331
Remote Config [baseline] (699.134 µs) : 0, 699
Remote Config [candidate] (689.005 µs) : 0, 689
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (7.328 ms) : 0, 7328
section appsec
BytebuddyAgent [baseline] (677.616 ms) : 0, 677616
BytebuddyAgent [candidate] (677.517 ms) : 0, 677517
GlobalTracer [baseline] (299.439 ms) : 0, 299439
GlobalTracer [candidate] (298.601 ms) : 0, 298601
AppSec [baseline] (157.277 ms) : 0, 157277
AppSec [candidate] (154.981 ms) : 0, 154981
IAST [baseline] (22.605 ms) : 0, 22605
IAST [candidate] (22.668 ms) : 0, 22668
Remote Config [baseline] (598.011 µs) : 0, 598
Remote Config [candidate] (598.134 µs) : 0, 598
Telemetry [baseline] (7.737 ms) : 0, 7737
Telemetry [candidate] (8.176 ms) : 0, 8176
section iast
BytebuddyAgent [baseline] (783.012 ms) : 0, 783012
BytebuddyAgent [candidate] (788.119 ms) : 0, 788119
GlobalTracer [baseline] (296.646 ms) : 0, 296646
GlobalTracer [candidate] (297.192 ms) : 0, 297192
AppSec [baseline] (51.565 ms) : 0, 51565
AppSec [candidate] (51.668 ms) : 0, 51668
IAST [baseline] (24.246 ms) : 0, 24246
IAST [candidate] (23.594 ms) : 0, 23594
Remote Config [baseline] (571.981 µs) : 0, 572
Remote Config [candidate] (591.793 µs) : 0, 592
Telemetry [baseline] (7.833 ms) : 0, 7833
Telemetry [candidate] (7.078 ms) : 0, 7078
section profiling
BytebuddyAgent [baseline] (666.547 ms) : 0, 666547
BytebuddyAgent [candidate] (662.11 ms) : 0, 662110
GlobalTracer [baseline] (390.269 ms) : 0, 390269
GlobalTracer [candidate] (388.076 ms) : 0, 388076
AppSec [baseline] (51.799 ms) : 0, 51799
AppSec [candidate] (51.495 ms) : 0, 51495
Remote Config [baseline] (688.086 µs) : 0, 688
Remote Config [candidate] (695.355 µs) : 0, 695
Telemetry [baseline] (7.39 ms) : 0, 7390
Telemetry [candidate] (7.254 ms) : 0, 7254
ProfilingAgent [baseline] (94.149 ms) : 0, 94149
ProfilingAgent [candidate] (94.929 ms) : 0, 94929
Profiling [baseline] (94.173 ms) : 0, 94173
Profiling [candidate] (94.953 ms) : 0, 94953
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-15T18:55:11 2024-08-15T19:01:58
git_branch master mcculls/sns-npe-fix-backport
git_commit_date 1723739593 1723747380
git_commit_sha fcd4bc4 b2cc6e8
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~b2cc6e8aac
start_time 2024-08-15T18:54:58 2024-08-15T19:01:45
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723748861 1723748861
ci_job_id 606426101 606426101
ci_pipeline_id 41901075 41901075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.916 µs) : 344, 384
.   : milestone, 364,
iast (481.085 µs) : 460, 503
.   : milestone, 481,
iast_FULL (546.758 µs) : 524, 569
.   : milestone, 547,
iast_GLOBAL (511.502 µs) : 489, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (479.94 µs) : 458, 502
.   : milestone, 480,
iast_INACTIVE (453.376 µs) : 431, 476
.   : milestone, 453,
iast_TELEMETRY_OFF (467.339 µs) : 446, 488
.   : milestone, 467,
tracing (443.33 µs) : 423, 464
.   : milestone, 443,
section candidate
no_agent (362.94 µs) : 343, 383
.   : milestone, 363,
iast (481.735 µs) : 460, 503
.   : milestone, 482,
iast_FULL (543.575 µs) : 523, 565
.   : milestone, 544,
iast_GLOBAL (506.007 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (478.938 µs) : 458, 500
.   : milestone, 479,
iast_INACTIVE (457.622 µs) : 435, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (467.205 µs) : 446, 489
.   : milestone, 467,
tracing (440.769 µs) : 420, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.916 µs [343.705 µs, 384.127 µs] -
iast 481.085 µs [459.515 µs, 502.654 µs] 117.169 µs (32.2%)
iast_FULL 546.758 µs [524.34 µs, 569.175 µs] 182.842 µs (50.2%)
iast_GLOBAL 511.502 µs [489.239 µs, 533.765 µs] 147.586 µs (40.6%)
iast_HARDCODED_SECRET_DISABLED 479.94 µs [458.341 µs, 501.54 µs] 116.025 µs (31.9%)
iast_INACTIVE 453.376 µs [430.576 µs, 476.177 µs] 89.461 µs (24.6%)
iast_TELEMETRY_OFF 467.339 µs [446.262 µs, 488.416 µs] 103.423 µs (28.4%)
tracing 443.33 µs [422.658 µs, 464.002 µs] 79.414 µs (21.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 362.94 µs [342.538 µs, 383.342 µs] -
iast 481.735 µs [460.137 µs, 503.334 µs] 118.796 µs (32.7%)
iast_FULL 543.575 µs [522.535 µs, 564.614 µs] 180.635 µs (49.8%)
iast_GLOBAL 506.007 µs [484.71 µs, 527.304 µs] 143.067 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 478.938 µs [457.786 µs, 500.091 µs] 115.999 µs (32.0%)
iast_INACTIVE 457.622 µs [435.034 µs, 480.21 µs] 94.682 µs (26.1%)
iast_TELEMETRY_OFF 467.205 µs [445.812 µs, 488.599 µs] 104.266 µs (28.7%)
tracing 440.769 µs [419.721 µs, 461.817 µs] 77.829 µs (21.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.335 ms) : 1316, 1354
.   : milestone, 1335,
appsec (1.705 ms) : 1683, 1728
.   : milestone, 1705,
appsec_no_iast (1.723 ms) : 1698, 1748
.   : milestone, 1723,
iast (1.484 ms) : 1462, 1506
.   : milestone, 1484,
profiling (1.468 ms) : 1443, 1493
.   : milestone, 1468,
tracing (1.47 ms) : 1446, 1494
.   : milestone, 1470,
section candidate
no_agent (1.336 ms) : 1317, 1355
.   : milestone, 1336,
appsec (1.709 ms) : 1684, 1733
.   : milestone, 1709,
appsec_no_iast (1.733 ms) : 1710, 1757
.   : milestone, 1733,
iast (1.473 ms) : 1450, 1496
.   : milestone, 1473,
profiling (1.486 ms) : 1462, 1511
.   : milestone, 1486,
tracing (1.447 ms) : 1422, 1473
.   : milestone, 1447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.316 ms, 1.354 ms] -
appsec 1.705 ms [1.683 ms, 1.728 ms] 370.639 µs (27.8%)
appsec_no_iast 1.723 ms [1.698 ms, 1.748 ms] 388.201 µs (29.1%)
iast 1.484 ms [1.462 ms, 1.506 ms] 149.155 µs (11.2%)
profiling 1.468 ms [1.443 ms, 1.493 ms] 133.513 µs (10.0%)
tracing 1.47 ms [1.446 ms, 1.494 ms] 134.869 µs (10.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.336 ms [1.317 ms, 1.355 ms] -
appsec 1.709 ms [1.684 ms, 1.733 ms] 373.021 µs (27.9%)
appsec_no_iast 1.733 ms [1.71 ms, 1.757 ms] 397.539 µs (29.8%)
iast 1.473 ms [1.45 ms, 1.496 ms] 137.425 µs (10.3%)
profiling 1.486 ms [1.462 ms, 1.511 ms] 150.363 µs (11.3%)
tracing 1.447 ms [1.422 ms, 1.473 ms] 111.4 µs (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/sns-npe-fix-backport
git_commit_date 1723739593 1723747380
git_commit_sha fcd4bc4 b2cc6e8
release_version 1.39.0-SNAPSHOT~fcd4bc4862 1.39.0-SNAPSHOT~b2cc6e8aac
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723749366 1723749366
ci_job_id 606426102 606426102
ci_pipeline_id 41901075 41901075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.227 ms) : 2192, 2262
.   : milestone, 2227,
iast (1.968 ms) : 1926, 2011
.   : milestone, 1968,
iast_GLOBAL (2.019 ms) : 1976, 2063
.   : milestone, 2019,
profiling (1.858 ms) : 1823, 1892
.   : milestone, 1858,
tracing (1.822 ms) : 1789, 1854
.   : milestone, 1822,
section candidate
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.225 ms) : 2190, 2260
.   : milestone, 2225,
iast (1.961 ms) : 1920, 2003
.   : milestone, 1961,
iast_GLOBAL (2.001 ms) : 1959, 2043
.   : milestone, 2001,
profiling (1.855 ms) : 1821, 1890
.   : milestone, 1855,
tracing (1.839 ms) : 1807, 1872
.   : milestone, 1839,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.227 ms [2.192 ms, 2.262 ms] 768.789 µs (52.7%)
iast 1.968 ms [1.926 ms, 2.011 ms] 510.136 µs (35.0%)
iast_GLOBAL 2.019 ms [1.976 ms, 2.063 ms] 560.903 µs (38.5%)
profiling 1.858 ms [1.823 ms, 1.892 ms] 399.417 µs (27.4%)
tracing 1.822 ms [1.789 ms, 1.854 ms] 363.552 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.225 ms [2.19 ms, 2.26 ms] 766.504 µs (52.6%)
iast 1.961 ms [1.92 ms, 2.003 ms] 502.95 µs (34.5%)
iast_GLOBAL 2.001 ms [1.959 ms, 2.043 ms] 542.43 µs (37.2%)
profiling 1.855 ms [1.821 ms, 1.89 ms] 396.758 µs (27.2%)
tracing 1.839 ms [1.807 ms, 1.872 ms] 380.852 µs (26.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b2cc6e8aac, baseline=1.39.0-SNAPSHOT~fcd4bc4862
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.492 s) : 15492000, 15492000
.   : milestone, 15492000,
appsec (15.173 s) : 15173000, 15173000
.   : milestone, 15173000,
iast (18.923 s) : 18923000, 18923000
.   : milestone, 18923000,
iast_GLOBAL (17.916 s) : 17916000, 17916000
.   : milestone, 17916000,
profiling (15.694 s) : 15694000, 15694000
.   : milestone, 15694000,
tracing (14.799 s) : 14799000, 14799000
.   : milestone, 14799000,
section candidate
no_agent (15.378 s) : 15378000, 15378000
.   : milestone, 15378000,
appsec (15.211 s) : 15211000, 15211000
.   : milestone, 15211000,
iast (18.881 s) : 18881000, 18881000
.   : milestone, 18881000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
.   : milestone, 18067000,
profiling (15.128 s) : 15128000, 15128000
.   : milestone, 15128000,
tracing (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.492 s [15.492 s, 15.492 s] -
appsec 15.173 s [15.173 s, 15.173 s] -319.0 ms (-2.1%)
iast 18.923 s [18.923 s, 18.923 s] 3.431 s (22.1%)
iast_GLOBAL 17.916 s [17.916 s, 17.916 s] 2.424 s (15.6%)
profiling 15.694 s [15.694 s, 15.694 s] 202.0 ms (1.3%)
tracing 14.799 s [14.799 s, 14.799 s] -693.0 ms (-4.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.378 s [15.378 s, 15.378 s] -
appsec 15.211 s [15.211 s, 15.211 s] -167.0 ms (-1.1%)
iast 18.881 s [18.881 s, 18.881 s] 3.503 s (22.8%)
iast_GLOBAL 18.067 s [18.067 s, 18.067 s] 2.689 s (17.5%)
profiling 15.128 s [15.128 s, 15.128 s] -250.0 ms (-1.6%)
tracing 15.137 s [15.137 s, 15.137 s] -241.0 ms (-1.6%)

@mcculls mcculls enabled auto-merge (squash) August 15, 2024 19:33
@mcculls mcculls requested a review from nayeem-kamal August 15, 2024 19:41
@mcculls mcculls added this to the 1.38.1 milestone Aug 15, 2024
PerfectSlayer
PerfectSlayer approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Report approval of #7448

@mcculls mcculls merged commit e4d2a06 into release/v1.38.x Aug 16, 2024
80 checks passed
@mcculls mcculls deleted the mcculls/sns-npe-fix-backport branch August 16, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal

@dougqh dougqh Awaiting requested review from dougqh

@amarziali amarziali Awaiting requested review from amarziali

Assignees
No one assigned
Labels
inst: aws sdk AWS SDK instrumentation type: bug
Projects
None yet
Milestone
1.38.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @PerfectSlayer @smola