-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BUILDING.md #7797
Open
sarahchen6
wants to merge
1
commit into
master
Choose a base branch
from
sarahchen6/clarify-export-command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update BUILDING.md #7797
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
added
type: documentation
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Oct 17, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078609
Total [baseline] (10.407 s) : 0, 10406969
Agent [candidate] (1.074 s) : 0, 1074475
Total [candidate] (10.358 s) : 0, 10358000
section appsec
Agent [baseline] (1.213 s) : 0, 1213452
Total [baseline] (10.581 s) : 0, 10580556
Agent [candidate] (1.218 s) : 0, 1217745
Total [candidate] (10.55 s) : 0, 10549894
section iast
Agent [baseline] (1.223 s) : 0, 1222648
Total [baseline] (10.931 s) : 0, 10930572
Agent [candidate] (1.199 s) : 0, 1198582
Total [candidate] (10.778 s) : 0, 10778178
section profiling
Agent [baseline] (1.27 s) : 0, 1269826
Total [baseline] (10.644 s) : 0, 10643859
Agent [candidate] (1.268 s) : 0, 1267513
Total [candidate] (10.67 s) : 0, 10669992
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.268 ms) : 0, 688268
BytebuddyAgent [candidate] (684.404 ms) : 0, 684404
GlobalTracer [baseline] (313.179 ms) : 0, 313179
GlobalTracer [candidate] (311.268 ms) : 0, 311268
AppSec [baseline] (53.993 ms) : 0, 53993
AppSec [candidate] (53.576 ms) : 0, 53576
Remote Config [baseline] (666.713 µs) : 0, 667
Remote Config [candidate] (669.289 µs) : 0, 669
Telemetry [baseline] (8.874 ms) : 0, 8874
Telemetry [candidate] (10.983 ms) : 0, 10983
section appsec
BytebuddyAgent [baseline] (705.781 ms) : 0, 705781
BytebuddyAgent [candidate] (708.012 ms) : 0, 708012
GlobalTracer [baseline] (310.291 ms) : 0, 310291
GlobalTracer [candidate] (311.93 ms) : 0, 311930
AppSec [baseline] (165.529 ms) : 0, 165529
AppSec [candidate] (165.464 ms) : 0, 165464
IAST [baseline] (19.445 ms) : 0, 19445
IAST [candidate] (19.876 ms) : 0, 19876
Remote Config [baseline] (642.122 µs) : 0, 642
Remote Config [candidate] (628.466 µs) : 0, 628
Telemetry [baseline] (7.818 ms) : 0, 7818
Telemetry [candidate] (8.048 ms) : 0, 8048
section iast
BytebuddyAgent [baseline] (816.427 ms) : 0, 816427
BytebuddyAgent [candidate] (799.298 ms) : 0, 799298
GlobalTracer [baseline] (305.698 ms) : 0, 305698
GlobalTracer [candidate] (300.363 ms) : 0, 300363
AppSec [baseline] (57.512 ms) : 0, 57512
AppSec [candidate] (56.359 ms) : 0, 56359
IAST [baseline] (21.403 ms) : 0, 21403
IAST [candidate] (21.314 ms) : 0, 21314
Remote Config [baseline] (618.941 µs) : 0, 619
Remote Config [candidate] (614.467 µs) : 0, 614
Telemetry [baseline] (7.114 ms) : 0, 7114
Telemetry [candidate] (7.031 ms) : 0, 7031
section profiling
BytebuddyAgent [baseline] (677.94 ms) : 0, 677940
BytebuddyAgent [candidate] (677.464 ms) : 0, 677464
GlobalTracer [baseline] (394.095 ms) : 0, 394095
GlobalTracer [candidate] (393.598 ms) : 0, 393598
AppSec [baseline] (54.469 ms) : 0, 54469
AppSec [candidate] (54.082 ms) : 0, 54082
Remote Config [baseline] (653.231 µs) : 0, 653
Remote Config [candidate] (653.468 µs) : 0, 653
Telemetry [baseline] (13.786 ms) : 0, 13786
Telemetry [candidate] (13.677 ms) : 0, 13677
ProfilingAgent [baseline] (90.362 ms) : 0, 90362
ProfilingAgent [candidate] (89.479 ms) : 0, 89479
Profiling [baseline] (90.387 ms) : 0, 90387
Profiling [candidate] (89.503 ms) : 0, 89503
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071978
Total [baseline] (8.541 s) : 0, 8541435
Agent [candidate] (1.072 s) : 0, 1071941
Total [candidate] (8.542 s) : 0, 8541704
section iast
Agent [baseline] (1.198 s) : 0, 1198420
Total [baseline] (9.097 s) : 0, 9096977
Agent [candidate] (1.204 s) : 0, 1203624
Total [candidate] (9.131 s) : 0, 9130672
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.197 s) : 0, 1197146
Total [baseline] (9.05 s) : 0, 9049787
Agent [candidate] (1.199 s) : 0, 1198788
Total [candidate] (9.068 s) : 0, 9067510
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1197824
Total [baseline] (9.089 s) : 0, 9088761
Agent [candidate] (1.195 s) : 0, 1195002
Total [candidate] (9.079 s) : 0, 9078857
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.565 ms) : 0, 683565
BytebuddyAgent [candidate] (682.098 ms) : 0, 682098
GlobalTracer [baseline] (310.741 ms) : 0, 310741
GlobalTracer [candidate] (310.226 ms) : 0, 310226
AppSec [baseline] (53.872 ms) : 0, 53872
AppSec [candidate] (53.645 ms) : 0, 53645
Remote Config [baseline] (662.622 µs) : 0, 663
Remote Config [candidate] (658.248 µs) : 0, 658
Telemetry [baseline] (9.558 ms) : 0, 9558
Telemetry [candidate] (11.786 ms) : 0, 11786
section iast
BytebuddyAgent [baseline] (798.951 ms) : 0, 798951
BytebuddyAgent [candidate] (802.622 ms) : 0, 802622
GlobalTracer [baseline] (300.552 ms) : 0, 300552
GlobalTracer [candidate] (301.677 ms) : 0, 301677
AppSec [baseline] (57.456 ms) : 0, 57456
AppSec [candidate] (56.859 ms) : 0, 56859
IAST [baseline] (20.237 ms) : 0, 20237
IAST [candidate] (21.107 ms) : 0, 21107
Remote Config [baseline] (605.805 µs) : 0, 606
Remote Config [candidate] (609.934 µs) : 0, 610
Telemetry [baseline] (7.029 ms) : 0, 7029
Telemetry [candidate] (7.041 ms) : 0, 7041
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.795 ms) : 0, 797795
BytebuddyAgent [candidate] (799.068 ms) : 0, 799068
GlobalTracer [baseline] (300.639 ms) : 0, 300639
GlobalTracer [candidate] (301.045 ms) : 0, 301045
AppSec [baseline] (57.279 ms) : 0, 57279
AppSec [candidate] (56.533 ms) : 0, 56533
IAST [baseline] (20.249 ms) : 0, 20249
IAST [candidate] (20.986 ms) : 0, 20986
Remote Config [baseline] (588.006 µs) : 0, 588
Remote Config [candidate] (583.235 µs) : 0, 583
Telemetry [baseline] (7.016 ms) : 0, 7016
Telemetry [candidate] (6.977 ms) : 0, 6977
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.605 ms) : 0, 798605
BytebuddyAgent [candidate] (795.671 ms) : 0, 795671
GlobalTracer [baseline] (300.946 ms) : 0, 300946
GlobalTracer [candidate] (300.727 ms) : 0, 300727
AppSec [baseline] (57.102 ms) : 0, 57102
AppSec [candidate] (56.339 ms) : 0, 56339
IAST [baseline] (20.022 ms) : 0, 20022
IAST [candidate] (21.064 ms) : 0, 21064
Remote Config [baseline] (599.287 µs) : 0, 599
Remote Config [candidate] (608.005 µs) : 0, 608
Telemetry [baseline] (6.98 ms) : 0, 6980
Telemetry [candidate] (6.996 ms) : 0, 6996
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section baseline
no_agent (374.043 µs) : 355, 394
. : milestone, 374,
iast (487.385 µs) : 466, 509
. : milestone, 487,
iast_FULL (557.722 µs) : 536, 579
. : milestone, 558,
iast_GLOBAL (518.585 µs) : 495, 542
. : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (480.832 µs) : 460, 502
. : milestone, 481,
iast_INACTIVE (452.125 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (480.837 µs) : 459, 502
. : milestone, 481,
tracing (449.379 µs) : 429, 470
. : milestone, 449,
section candidate
no_agent (375.558 µs) : 355, 396
. : milestone, 376,
iast (488.246 µs) : 467, 510
. : milestone, 488,
iast_FULL (553.432 µs) : 532, 575
. : milestone, 553,
iast_GLOBAL (515.056 µs) : 492, 538
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (490.168 µs) : 469, 511
. : milestone, 490,
iast_INACTIVE (445.468 µs) : 425, 466
. : milestone, 445,
iast_TELEMETRY_OFF (483.147 µs) : 462, 505
. : milestone, 483,
tracing (446.275 µs) : 426, 467
. : milestone, 446,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1351
. : milestone, 1332,
appsec (1.718 ms) : 1693, 1742
. : milestone, 1718,
appsec_no_iast (1.739 ms) : 1715, 1763
. : milestone, 1739,
iast (1.499 ms) : 1477, 1521
. : milestone, 1499,
profiling (1.544 ms) : 1520, 1568
. : milestone, 1544,
tracing (1.468 ms) : 1443, 1492
. : milestone, 1468,
section candidate
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.718 ms) : 1695, 1740
. : milestone, 1718,
appsec_no_iast (1.742 ms) : 1718, 1766
. : milestone, 1742,
iast (1.467 ms) : 1445, 1490
. : milestone, 1467,
profiling (1.547 ms) : 1523, 1572
. : milestone, 1547,
tracing (1.466 ms) : 1441, 1490
. : milestone, 1466,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.33 ms) : 2289, 2372
. : milestone, 2330,
iast (2.056 ms) : 2004, 2107
. : milestone, 2056,
iast_GLOBAL (2.115 ms) : 2063, 2167
. : milestone, 2115,
profiling (1.936 ms) : 1895, 1978
. : milestone, 1936,
tracing (1.919 ms) : 1879, 1959
. : milestone, 1919,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.323 ms) : 2282, 2364
. : milestone, 2323,
iast (2.073 ms) : 2022, 2125
. : milestone, 2073,
iast_GLOBAL (2.126 ms) : 2073, 2178
. : milestone, 2126,
profiling (1.931 ms) : 1889, 1973
. : milestone, 1931,
tracing (1.924 ms) : 1884, 1964
. : milestone, 1924,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~054553e251, baseline=1.42.0-SNAPSHOT~9320a05d02
dateFormat X
axisFormat %s
section baseline
no_agent (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
appsec (14.879 s) : 14879000, 14879000
. : milestone, 14879000,
iast (19.052 s) : 19052000, 19052000
. : milestone, 19052000,
iast_GLOBAL (17.69 s) : 17690000, 17690000
. : milestone, 17690000,
profiling (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
tracing (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
section candidate
no_agent (15.622 s) : 15622000, 15622000
. : milestone, 15622000,
appsec (15.418 s) : 15418000, 15418000
. : milestone, 15418000,
iast (19.02 s) : 19020000, 19020000
. : milestone, 19020000,
iast_GLOBAL (17.992 s) : 17992000, 17992000
. : milestone, 17992000,
profiling (15.642 s) : 15642000, 15642000
. : milestone, 15642000,
tracing (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR rewords a section of the BUILDING.md file. Specifically, it moves a suggestion to append the
export
commands to your shell configuration file from being a Note to being directly in the instruction.Motivation
Notes are often overlooked. By mentioning this recommendation directly in the instruction, more people will see it.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]