Skip to content

Commit

Permalink
Update/fix settings in .vscode directory (#4722)
Browse files Browse the repository at this point in the history
Two files have been modified, which was added to the repo 5 years ago
and never touched again:

The `.vscode/launch.json` file was outdated and didn't actually work, as
it expected `tdd` to exist in the path.

Read more about `launch.json` attributes here:
https://code.visualstudio.com/Docs/editor/debugging#_launchjson-attributes

The `.vscode/settings.json` file was outdated and used a config property
no longer supported. The proper equivalent setting would have been:

    "debug.javascript.autoAttachFilter": "always"

But I don't think we want that as it will auto-attach a debugger to
every script you run in the console. I've opted for removing this
altogether.

Read more about auto-attaching here:
https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_auto-attach
  • Loading branch information
watson authored and juan-fernandez committed Sep 30, 2024
1 parent d418dd6 commit 361a680
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
14 changes: 5 additions & 9 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,11 @@
"type": "node",
"request": "launch",
"name": "Test Current File",
"runtimeExecutable": "yarn",
"runtimeArgs": [
"tdd",
"${file}",
"--inspect-brk=9229"
"skipFiles": [
"<node_internals>/**"
],
"port": 9229,
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen"
},
"program": "${file}",
"console": "integratedTerminal"
}
]
}
3 changes: 0 additions & 3 deletions .vscode/settings.json

This file was deleted.

0 comments on commit 361a680

Please sign in to comment.