-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate lib injection images even if other steps fail #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.11 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4109 +/- ##
=======================================
Coverage 84.99% 84.99%
=======================================
Files 247 247
Lines 10736 10736
Branches 33 33
=======================================
Hits 9125 9125
Misses 1611 1611 ☔ View full report in Codecov by Sentry. |
randomanderson
changed the title
Replicate images even if other steps fail
Replicate lib injection images even if other steps fail
Feb 26, 2024
Qard
approved these changes
Feb 26, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 4, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 5, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 5, 2024
This was referenced Mar 5, 2024
Merged
Merged
Merged
uurien
pushed a commit
that referenced
this pull request
Mar 6, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 6, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 7, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 7, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Image replication for kubernetes injection is not run if package building for host/docker injection fails. This is because the package stage is before the deploy stage. This PR allows image replication to run regardless.
Motivation
Kubernetes injection images are currently missing because of this failure
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!