Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Fix negative duration in playwright steps #4113

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Feb 27, 2024

What does this PR do?

  • A playwright's step can have a negative duration (step.duration) if it's not executed, as a result of a failing hook. This results in our intake rejecting the whole payload.
  • In addition to fixing this, I've improved the way we report test errors in suites and sessions in playwright:
    • If a test suite fails as a result of a beforeAll or afterAll test, it will report an error.
    • If a test suite fails as a result of any of its tests failing, it'll report the test errors.
    • Sessions will include an error message with the number of failed suites and errors if they fail.

Motivation

Fixes #4103

Plugin Checklist

  • Unit tests.

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Copy link

github-actions bot commented Feb 27, 2024

Overall package size

Self size: 6.13 MB
Deduped: 62.01 MB
No deduping: 62.76 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (727b93d) to head (7d04ef2).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4113      +/-   ##
==========================================
+ Coverage   84.99%   85.25%   +0.25%     
==========================================
  Files         247      247              
  Lines       10736    10848     +112     
  Branches       33       33              
==========================================
+ Hits         9125     9248     +123     
+ Misses       1611     1600      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2024

Benchmarks

Benchmark execution time: 2024-02-28 17:23:04

Comparing candidate commit 7d04ef2 in PR branch juan-fernandez/fix-empty-duration with baseline commit 727b93d in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 4 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-144.043MB; -84.665MB] or [-15.129%; -8.893%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-144.269MB; -103.299MB] or [-15.013%; -10.750%]

@juan-fernandez juan-fernandez marked this pull request as ready for review February 28, 2024 13:24
@juan-fernandez juan-fernandez requested review from a team as code owners February 28, 2024 13:24
packages/datadog-instrumentations/src/playwright.js Outdated Show resolved Hide resolved
packages/datadog-instrumentations/src/playwright.js Outdated Show resolved Hide resolved
juan-fernandez and others added 2 commits February 28, 2024 18:14
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
@juan-fernandez juan-fernandez merged commit f26730b into master Feb 29, 2024
110 of 111 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-empty-duration branch February 29, 2024 07:48
uurien pushed a commit that referenced this pull request Mar 4, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
uurien pushed a commit that referenced this pull request Mar 5, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
uurien pushed a commit that referenced this pull request Mar 5, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
This was referenced Mar 5, 2024
uurien pushed a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
uurien pushed a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
uurien pushed a commit that referenced this pull request Mar 7, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
uurien pushed a commit that referenced this pull request Mar 7, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
uurien pushed a commit that referenced this pull request Mar 7, 2024
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout Errors not Displayed in Datadog Dashboard Despite Successful Reporting with DD_TRACE_DEBUG
3 participants