-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Fix negative duration in playwright steps #4113
Conversation
Overall package sizeSelf size: 6.13 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4113 +/- ##
==========================================
+ Coverage 84.99% 85.25% +0.25%
==========================================
Files 247 247
Lines 10736 10848 +112
Branches 33 33
==========================================
+ Hits 9125 9248 +123
+ Misses 1611 1600 -11 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-28 17:23:04 Comparing candidate commit 7d04ef2 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 4 unstable metrics. scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
Co-authored-by: Romain Komorn <136473744+romainkomorndatadog@users.noreply.github.com>
What does this PR do?
step.duration
) if it's not executed, as a result of a failing hook. This results in our intake rejecting the whole payload.beforeAll
orafterAll
test, it will report an error.Motivation
Fixes #4103
Plugin Checklist
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!