-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w3c phase 2: add last parent_id to tracestate #4118
Conversation
Overall package sizeSelf size: 6.22 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4118 +/- ##
==========================================
+ Coverage 85.00% 85.06% +0.06%
==========================================
Files 247 247
Lines 10914 10947 +33
Branches 33 33
==========================================
+ Hits 9277 9312 +35
+ Misses 1637 1635 -2 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-29 19:10:22 Comparing candidate commit c075798 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 8 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I will have to defer the approval of this PR to @rochdev since he might have some opinions on changes to tracestate
TODO: address the case where a span is not active and |
Blocked by: #4153 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can a test for this be added?
30b87b6
to
14a7122
Compare
What does this PR do?
With this change span_id will be encoded in both the tracestate and traceparent headers. This will allow us to re-connect datadog traces that contain non-datadog spans.
Ex: Host A: Datadog Spans ->tracecontext-> Host B: Otel Dynatrace Spans -->tracecontext-> Host C: Otel Datadog Spans
By adding span_id to the tracestate Host C will be able to detect upstream Datadog spans from Host A. This span_id will then be sent to Datadog intake services (via
_dd.parent_id
tag). The Datadog internal services will use this tag to reconnect Datadog Spans.Tests will be added in this PR: DataDog/system-tests#2181
Motivation
Plugin Checklist
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!