-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular dependencies in waf calls #4125
Conversation
Overall package sizeSelf size: 6.15 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4125 +/- ##
=======================================
Coverage 85.25% 85.25%
=======================================
Files 247 247
Lines 10848 10848
Branches 33 33
=======================================
Hits 9248 9248
Misses 1600 1600 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-03-01 16:22:04 Comparing candidate commit dfa1bb2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics. |
What does this PR do?
Updates
@datadog/native-appsec
library to version v7.1.0. This version updates the libddwaf to 1.16.0 and fixes errors with circular dependencies.Adds test with sequelize to be sure that the error is fixed, and prevent the same error in the future.
Plugin Checklist
Additional Notes
Test failure with
@datadog/native-appsec
v7.0.0: https://github.com/DataDog/dd-trace-js/actions/runs/8109230968/job/22163995098Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!