Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if prepareStackTrace has been wrapped before restore it #4138

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Mar 5, 2024

What does this PR do?

Check if Error.prepareStackTrace has been wrapped before restore it

Motivation

Disabling IAST without having been enabled before can reset a possible Error.prepareStackTrace set by the app

Plugin Checklist

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Copy link

github-actions bot commented Mar 5, 2024

Overall package size

Self size: 6.17 MB
Deduped: 61.16 MB
No deduping: 61.91 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.0 14.37 MB 14.38 MB
@datadog/pprof 5.1.0 8.83 MB 9.68 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.20%. Comparing base (2c9aef4) to head (0afdcb5).
Report is 4 commits behind head on master.

Files Patch % Lines
...d-trace/src/appsec/iast/taint-tracking/rewriter.js 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4138      +/-   ##
==========================================
- Coverage   85.25%   85.20%   -0.05%     
==========================================
  Files         247      247              
  Lines       10849    10857       +8     
  Branches       33       33              
==========================================
+ Hits         9249     9251       +2     
- Misses       1600     1606       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Mar 5, 2024

Benchmarks

Benchmark execution time: 2024-03-05 16:50:46

Comparing candidate commit 0afdcb5 in PR branch igor/fix-prepare-stack-trace with baseline commit 2c9aef4 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-132.917MB; -127.895MB] or [-13.735%; -13.216%]

@iunanua iunanua force-pushed the igor/fix-prepare-stack-trace branch from 1421011 to c869b12 Compare March 5, 2024 16:29
@iunanua iunanua marked this pull request as ready for review March 5, 2024 16:51
@iunanua iunanua requested a review from a team as a code owner March 5, 2024 16:51
@iunanua iunanua enabled auto-merge (squash) March 5, 2024 17:07
@iunanua iunanua merged commit 4f4a22b into master Mar 5, 2024
110 of 111 checks passed
@iunanua iunanua deleted the igor/fix-prepare-stack-trace branch March 5, 2024 17:18
uurien pushed a commit that referenced this pull request Mar 5, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
uurien pushed a commit that referenced this pull request Mar 5, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
uurien pushed a commit that referenced this pull request Mar 5, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
This was referenced Mar 5, 2024
uurien pushed a commit that referenced this pull request Mar 6, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
uurien pushed a commit that referenced this pull request Mar 6, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
uurien pushed a commit that referenced this pull request Mar 7, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
uurien pushed a commit that referenced this pull request Mar 7, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
uurien pushed a commit that referenced this pull request Mar 7, 2024
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants