-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if prepareStackTrace has been wrapped before restore it #4138
Conversation
Overall package sizeSelf size: 6.17 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4138 +/- ##
==========================================
- Coverage 85.25% 85.20% -0.05%
==========================================
Files 247 247
Lines 10849 10857 +8
Branches 33 33
==========================================
+ Hits 9249 9251 +2
- Misses 1600 1606 +6 ☔ View full report in Codecov by Sentry. |
e9df608
to
1421011
Compare
BenchmarksBenchmark execution time: 2024-03-05 16:50:46 Comparing candidate commit 0afdcb5 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
1421011
to
c869b12
Compare
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
* Check if prepareStackTrace has been wrapped before restore it * Use an IAST general flag
What does this PR do?
Check if
Error.prepareStackTrace
has been wrapped before restore itMotivation
Disabling IAST without having been enabled before can reset a possible
Error.prepareStackTrace
set by the appPlugin Checklist
Additional Notes
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!