Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken plugin links #4156

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix broken plugin links #4156

merged 2 commits into from
Mar 13, 2024

Conversation

khanayan123
Copy link
Collaborator

What does this PR do?

fixes broken plugin links on api.md doc

Motivation

broken api docs

@khanayan123 khanayan123 requested a review from a team as a code owner March 12, 2024 14:27
Copy link

github-actions bot commented Mar 12, 2024

Overall package size

Self size: 6.22 MB
Deduped: 61.21 MB
No deduping: 61.97 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.0 14.37 MB 14.38 MB
@datadog/pprof 5.1.0 8.83 MB 9.68 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (f0f6020) to head (95182cc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4156      +/-   ##
==========================================
+ Coverage   85.00%   85.05%   +0.05%     
==========================================
  Files         247      247              
  Lines       10914    10939      +25     
  Branches       33       33              
==========================================
+ Hits         9277     9304      +27     
+ Misses       1637     1635       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rochdev rochdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this make any existing links continue to break?

@khanayan123
Copy link
Collaborator Author

Wouldn't this make any existing links continue to break?

existing links are already broken:

current broken link:

https://datadoghq.dev/dd-trace-js/interfaces/plugins.amqp10.html

proposed change:

https://datadoghq.dev/dd-trace-js/interfaces/export_.plugins.amqp10.html

@tlhunter
Copy link
Member

Wouldn't this make any existing links continue to break?

Are you referring to links on third party sites like github issues?

@tlhunter tlhunter force-pushed the khanayan123/fix-api-docs branch from 02cb7ce to 95182cc Compare March 12, 2024 21:28
@khanayan123 khanayan123 merged commit 33c1d55 into master Mar 13, 2024
110 of 111 checks passed
@khanayan123 khanayan123 deleted the khanayan123/fix-api-docs branch March 13, 2024 17:21
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
juan-fernandez pushed a commit that referenced this pull request Mar 20, 2024
* fix broken plugin links

* redirect old URLs

---------

Co-authored-by: Thomas Hunter II <tlhunter@datadog.com>
@mjperrone
Copy link

It appears that the links are still broken on master. I just clicked the express link here, which lead me to a 404 here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants