Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trace sampling rate limit applying to individual rules #4169

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Mar 19, 2024

What does this PR do?

Fix trace sampling rate limit applying to individual rules instead of globally.

Motivation

The rate limit has always applied globally and not per rule. This was recently changed for span sampling, but it shouldn't also have been changed for trace sampling.

Additional Notes

Regression introduced in #3904

Copy link

Overall package size

Self size: 6.23 MB
Deduped: 61.17 MB
No deduping: 61.93 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.0 14.37 MB 14.38 MB
@datadog/pprof 5.1.0 8.83 MB 9.68 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (a99e5ea) to head (038279c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4169      +/-   ##
==========================================
- Coverage   85.07%   85.06%   -0.01%     
==========================================
  Files         247      247              
  Lines       10952    10953       +1     
  Branches       33       33              
==========================================
  Hits         9317     9317              
- Misses       1635     1636       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rochdev rochdev marked this pull request as ready for review March 19, 2024 23:37
@rochdev rochdev requested a review from a team as a code owner March 19, 2024 23:37
@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2024

Benchmarks

Benchmark execution time: 2024-03-19 23:38:33

Comparing candidate commit 038279c in PR branch sampling-global-rate-limit with baseline commit a99e5ea in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-144.476MB; -83.080MB] or [-15.187%; -8.733%]

@rochdev rochdev merged commit 6227fa4 into master Mar 20, 2024
113 checks passed
@rochdev rochdev deleted the sampling-global-rate-limit branch March 20, 2024 03:41
@rochdev rochdev restored the sampling-global-rate-limit branch March 20, 2024 03:41
@rochdev rochdev deleted the sampling-global-rate-limit branch March 20, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants