-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROF-9395: More async encoding of profiles #4190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.25 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4190 +/- ##
==========================================
+ Coverage 85.02% 85.23% +0.20%
==========================================
Files 244 247 +3
Lines 10784 10956 +172
Branches 33 33
==========================================
+ Hits 9169 9338 +169
- Misses 1615 1618 +3 ☔ View full report in Codecov by Sentry. |
nsavoire
approved these changes
Mar 26, 2024
uurien
pushed a commit
that referenced
this pull request
Mar 26, 2024
Uses a version of `@datadog/pprof` and `@datadog/pprof-format` that add extra async stages for profile encoding, reducing worst-case latency impact of it.
uurien
pushed a commit
that referenced
this pull request
Mar 26, 2024
Uses a version of `@datadog/pprof` and `@datadog/pprof-format` that add extra async stages for profile encoding, reducing worst-case latency impact of it.
uurien
pushed a commit
that referenced
this pull request
Mar 26, 2024
Uses a version of `@datadog/pprof` and `@datadog/pprof-format` that add extra async stages for profile encoding, reducing worst-case latency impact of it.
uurien
pushed a commit
that referenced
this pull request
Mar 26, 2024
Uses a version of `@datadog/pprof` and `@datadog/pprof-format` that add extra async stages for profile encoding, reducing worst-case latency impact of it.
uurien
pushed a commit
that referenced
this pull request
Mar 26, 2024
Uses a version of `@datadog/pprof` and `@datadog/pprof-format` that add extra async stages for profile encoding, reducing worst-case latency impact of it.
uurien
pushed a commit
that referenced
this pull request
Mar 26, 2024
Uses a version of `@datadog/pprof` and `@datadog/pprof-format` that add extra async stages for profile encoding, reducing worst-case latency impact of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
@datadog/pprof
to 5.2.0. The relevant change in it is an update to@datadog/pprof-format
which introduces asynchronous stages into encoding of profiles, which should help attenuating the latency spikes on profile submission. The update alone is sufficient to enable the new functionality.Motivation
We want to reduce the latency spikes.
Additional Notes
Propagates changes from DataDog/pprof-nodejs#165 and DataDog/pprof-format#19
Security
Datadog employees:
@DataDog/security-design-and-guidance
.