-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent object key tainting #4251
Conversation
Overall package sizeSelf size: 6.39 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4251 +/- ##
==========================================
- Coverage 73.16% 69.19% -3.98%
==========================================
Files 245 1 -244
Lines 10442 198 -10244
Branches 33 33
==========================================
- Hits 7640 137 -7503
+ Misses 2802 61 -2741 ☔ View full report in Codecov by Sentry. |
packages/dd-trace/src/appsec/iast/taint-tracking/operations-taint-object.js
Outdated
Show resolved
Hide resolved
BenchmarksBenchmark execution time: 2024-04-22 09:29:54 Comparing candidate commit b1ff946 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 4 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
|
packages/dd-trace/src/appsec/iast/taint-tracking/operations-taint-object.js
Outdated
Show resolved
Hide resolved
* Prevent tainting object keys - header and cookie names * Add test to check literal tainting on matching object key tainting * Remove taint object keys logic * Remove taint header names test
* Prevent tainting object keys - header and cookie names * Add test to check literal tainting on matching object key tainting * Remove taint object keys logic * Remove taint header names test
* Prevent tainting object keys - header and cookie names * Add test to check literal tainting on matching object key tainting * Remove taint object keys logic * Remove taint header names test
* Prevent tainting object keys - header and cookie names * Add test to check literal tainting on matching object key tainting * Remove taint object keys logic * Remove taint header names test
* Prevent tainting object keys - header and cookie names * Add test to check literal tainting on matching object key tainting * Remove taint object keys logic * Remove taint header names test
* Prevent tainting object keys - header and cookie names * Add test to check literal tainting on matching object key tainting * Remove taint object keys logic * Remove taint header names test
What does this PR do?
Prevent tainting object keys such as cookie and header names.
Motivation
It has been found that when object keys are tainted, matching literals are tainted as well, leading to a potentially false positives in vulnerability detection.
Plugin Checklist