Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child_process plugin to typings #4306

Merged
merged 3 commits into from
May 16, 2024

Conversation

CarlesDD
Copy link
Contributor

Recreates #4299

What does this PR do?

Add child_process plugin to typings

Motivation

Being able to disable this plugin.

Additional Notes

This seems to have been omitted in #3608

Copy link

Overall package size

Self size: 6.47 MB
Deduped: 59.18 MB
No deduping: 59.46 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented May 15, 2024

Benchmarks

Benchmark execution time: 2024-05-15 13:59:49

Comparing candidate commit 37eedb2 in PR branch ccapell/add-child_process-plugin-to-typings with baseline commit 79f0d64 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics.

@CarlesDD CarlesDD marked this pull request as ready for review May 15, 2024 14:08
@CarlesDD CarlesDD requested a review from a team as a code owner May 15, 2024 14:09
@simon-id
Copy link
Member

LGTM but i've never added a plugin before, I think it's worth asking APM for a pair of eyes.

@CarlesDD CarlesDD merged commit 5d29b40 into master May 16, 2024
111 of 113 checks passed
@CarlesDD CarlesDD deleted the ccapell/add-child_process-plugin-to-typings branch May 16, 2024 06:25
khanayan123 pushed a commit that referenced this pull request May 16, 2024
* index.d.ts: add child_process

* Add missing definition

* Add child_process to type test

---------

Co-authored-by: Ilya Priven <ilya.konstantinov@gmail.com>
khanayan123 pushed a commit that referenced this pull request May 16, 2024
* index.d.ts: add child_process

* Add missing definition

* Add child_process to type test

---------

Co-authored-by: Ilya Priven <ilya.konstantinov@gmail.com>
This was referenced May 16, 2024
khanayan123 pushed a commit that referenced this pull request May 17, 2024
* index.d.ts: add child_process

* Add missing definition

* Add child_process to type test

---------

Co-authored-by: Ilya Priven <ilya.konstantinov@gmail.com>
khanayan123 pushed a commit that referenced this pull request May 17, 2024
* index.d.ts: add child_process

* Add missing definition

* Add child_process to type test

---------

Co-authored-by: Ilya Priven <ilya.konstantinov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants