-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiler support for node 22 #4312
Add profiler support for node 22 #4312
Conversation
pprof-nodejs 5.3.0 adds support for node 22. Reenable profiling and tracing tests on node latest.
Overall package sizeSelf size: 6.47 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-05-16 09:53:52 Comparing candidate commit 74cabc0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 264 metrics, 2 unstable metrics. |
@@ -34,7 +34,7 @@ jobs: | |||
- uses: ./.github/actions/node/20 | |||
- run: yarn test:profiler:ci | |||
- run: yarn test:integration:profiler | |||
- uses: ./.github/actions/node/21 | |||
- uses: ./.github/actions/node/latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have something for 21 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd numbered versions are not LTS, and we do not test them except when they are latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd numbers go EOL to moment the next even numbered release happens, so we don't consider them supported at all, but we test against them because it can, to some extent, warn us ahead of time when an issue is coming. Generally more significant breaking changes are saved for odd releases so there's time to test them in userland and revert in the next even release. While even releases tend to only take more conservative breaking changes due to being harder to undo before it becomes LTS.
pprof-nodejs 5.3.0 adds support for node 22. Reenable profiling and tracing tests on node latest.
pprof-nodejs 5.3.0 adds support for node 22. Reenable profiling and tracing tests on node latest.
pprof-nodejs 5.3.0 adds support for node 22. Reenable profiling and tracing tests on node latest.
pprof-nodejs 5.3.0 adds support for node 22. Reenable profiling and tracing tests on node latest.
What does this PR do?
Update pprof-nodejs to 5.3.0 and run profiling and tracing tests on latest nodejs.
Motivation
Add support for profiling on node 22.