Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test visibility] Use new metadata field in citestcycle #4649

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Sep 4, 2024

What does this PR do?

Make use of new fields in the metadata dictionary in the agentless encoding:

{
  version: ENCODING_VERSION,
  metadata: {
    '*': {
      language: 'javascript',
      library_version: ddTraceVersion
    },
    test: {
       // fields applied to tests
    },
    test_suite_end: {
       // fields applied to test suites
    },
    test_module_end: {
       // fields applied to test modules
    },
    test_session_end: {
       // fields applied to test sessions
    },
  },
  events: []
}

This allows saving a bunch of tags in different events.

Motivation

Follow up from #4621, now that the backend accepts these fields in the citestcycle endpoint.

Plugin Checklist

  • Unit tests.

@pr-commenter
Copy link

pr-commenter bot commented Sep 4, 2024

Benchmarks

Benchmark execution time: 2024-09-04 12:49:58

Comparing candidate commit d416082 in PR branch juan-fernandez/use-new-metadata-field with baseline commit 9949796 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (c8e6070) to head (d416082).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4649       +/-   ##
===========================================
+ Coverage   69.19%   81.26%   +12.07%     
===========================================
  Files           1      143      +142     
  Lines         198     5269     +5071     
  Branches       33       33               
===========================================
+ Hits          137     4282     +4145     
- Misses         61      987      +926     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 4, 2024

Overall package size

Self size: 7.04 MB
Deduped: 62.41 MB
No deduping: 62.69 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@juan-fernandez juan-fernandez marked this pull request as ready for review September 5, 2024 08:35
@juan-fernandez juan-fernandez requested review from a team as code owners September 5, 2024 08:35
@juan-fernandez juan-fernandez merged commit 421f3d4 into master Sep 6, 2024
168 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/use-new-metadata-field branch September 6, 2024 08:29
juan-fernandez added a commit that referenced this pull request Sep 9, 2024
juan-fernandez added a commit that referenced this pull request Sep 10, 2024
juan-fernandez added a commit that referenced this pull request Sep 30, 2024
juan-fernandez added a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants