Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test visibility] Add test source file to test suites #4677

Merged
merged 15 commits into from
Sep 16, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Sep 12, 2024

What does this PR do?

Add test.source.file, test.source.start and test.codeowners to test suites, in addition to tests, which already had those tags.

Motivation

Test suites are test files and it's useful for users to be able to look at test files in Datadog UI. This allows customer to do this.

Plugin Checklist

  • Unit tests.

Copy link

github-actions bot commented Sep 12, 2024

Overall package size

Self size: 7.1 MB
Deduped: 62.47 MB
No deduping: 62.75 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Sep 12, 2024

Benchmarks

Benchmark execution time: 2024-09-13 10:55:05

Comparing candidate commit 896b0fb in PR branch juan-fernandez/add-test-source-to-suites with baseline commit 8b5b271 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@juan-fernandez juan-fernandez force-pushed the juan-fernandez/add-test-source-to-suites branch from c76cbeb to 896b0fb Compare September 13, 2024 10:46
@juan-fernandez juan-fernandez marked this pull request as ready for review September 13, 2024 10:49
@juan-fernandez juan-fernandez requested a review from a team as a code owner September 13, 2024 10:49
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.19%. Comparing base (bd2f8b2) to head (043a1f9).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4677      +/-   ##
==========================================
+ Coverage   62.59%   69.19%   +6.59%     
==========================================
  Files          58        1      -57     
  Lines        2267      198    -2069     
  Branches       33       33              
==========================================
- Hits         1419      137    -1282     
+ Misses        848       61     -787     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@romainkomorndatadog romainkomorndatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I feel like we have an implicit "suite maps to whole file" assumption and I wonder if we should have something more explicit.

Maybe specifying the file without listing a start line? 🤔

@juan-fernandez
Copy link
Collaborator Author

LGTM but I feel like we have an implicit "suite maps to whole file" assumption and I wonder if we should have something more explicit.

Maybe specifying the file without listing a start line? 🤔

if the suite maps to part of a file, wouldn't it work to pass the start line? If a suite maps to multiple files, this won't work, but we mentioned that source files in test suites would be best effort and the libraries would take the decision whether to include the tag or not, right?

@juan-fernandez juan-fernandez merged commit a4b588a into master Sep 16, 2024
154 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/add-test-source-to-suites branch September 16, 2024 09:15
@juan-fernandez juan-fernandez mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants