-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crashtracking with libdatadog native binding #4692
Open
rochdev
wants to merge
9
commits into
master
Choose a base branch
from
crashtracker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+413
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
force-pushed
the
crashtracker
branch
from
September 17, 2024 15:01
24dfa4c
to
4672fe8
Compare
Overall package sizeSelf size: 7.17 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
rochdev
force-pushed
the
crashtracker
branch
from
September 20, 2024 15:02
f2df62c
to
d2bf904
Compare
rochdev
changed the title
Add crashtracker
Add crashtracking with libdatadog native binding
Sep 20, 2024
Notes: Disabled by default, adds 20MB, sidecar process, excluded from lambda layer |
tlhunter
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add crashtracking with libdatadog native binding.
Motivation
We already report in-app errors using Error Tracking, but this doesn't cover cases when the process dies from a cause outside of a JavaScript error, for example a segmentation fault or an OOM exception. This PR adds support for those cases.
Additional Notes
This PR mostly just adds a thin wrapper on top of the native extension. The actual tracking happens in the crashtracker receiver, which is a side-process started by the native extension to monitor the current process externally.