Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test visibility] Read pull_request and pull_request_target event info from GHA #4745

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Oct 1, 2024

What does this PR do?

Detect if we're in a pull_request or pull_request_target event by checking GITHUB_BASE_REF, and if we are, attempt to read the event.json payload made available by GitHub in GITHUB_EVENT_PATH.

Motivation

GitHub does not run workflows in the head of the branch about to be merged whenever the workflow is triggered through pull_request or pull_request_target events. It runs them in a merge commit. This is the one that we add to git.commit.sha. This is sometimes confusing because this commit does not exist in the history of the branch. What we did:

  • Notice when this happens
  • When it does, add a new set of tags:
    • git.commit.head_sha, which is the head SHA of the feature branch (branch to be merged).
    • git.pull_request.base_branch_sha, which is the head SHA of the base branch (branch you're merging into)
    • git.pull_request.base_branch, which is the name of the base branch

Plugin Checklist

  • Unit tests.

Copy link

github-actions bot commented Oct 1, 2024

Overall package size

Self size: 7.21 MB
Deduped: 62.62 MB
No deduping: 62.9 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024

Benchmarks

Benchmark execution time: 2024-10-02 09:58:06

Comparing candidate commit cd30a5d in PR branch juan-fernandez/read-extra-env-info-from-gha with baseline commit fcd3ab8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@juan-fernandez juan-fernandez marked this pull request as ready for review October 2, 2024 09:46
@juan-fernandez juan-fernandez requested a review from a team as a code owner October 2, 2024 09:46
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/read-extra-env-info-from-gha branch from f8e2129 to cd30a5d Compare October 2, 2024 09:48
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.80%. Comparing base (bb0bbcc) to head (cd30a5d).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4745       +/-   ##
===========================================
- Coverage   91.42%   57.80%   -33.62%     
===========================================
  Files         112      157       +45     
  Lines        3475     6058     +2583     
  Branches       33       33               
===========================================
+ Hits         3177     3502      +325     
- Misses        298     2556     +2258     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juan-fernandez juan-fernandez requested a review from uurien October 2, 2024 10:25
@juan-fernandez juan-fernandez merged commit 70d5591 into master Oct 2, 2024
194 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/read-extra-env-info-from-gha branch October 2, 2024 10:29
bengl pushed a commit that referenced this pull request Oct 16, 2024
bengl pushed a commit that referenced this pull request Oct 16, 2024
This was referenced Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants