Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Overriding GRPC Error Statuses #4800

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

khanayan123
Copy link
Collaborator

@khanayan123 khanayan123 commented Oct 17, 2024

What does this PR do?

adds support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_STATUSES

Environment Variable: DD_GRPC_CLIENT_ERROR_STATUSES

  • Default: 1-16
  • A range of errors can be accepted. By default, gRPC status codes 1 to 16 are reported as errors for gRPC clients. This configuration overrides that. Ex. DD_GRPC_CLIENT_ERROR_STATUSES=1-4,7-10

Environment Variable: DD_GRPC_SERVER_ERROR_STATUSES

  • Default: 2-16
  • A range of errors can be accepted. By default, gRPC status codes 2 to 16 are reported as errors for gRPC servers. This configuration overrides that. Ex. DD_GRPC_SERVER_ERROR_STATUSES=2-4,7-10

Motivation

#4364

Copy link

github-actions bot commented Oct 17, 2024

Overall package size

Self size: 7.58 MB
Deduped: 62.89 MB
No deduping: 63.23 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@khanayan123 khanayan123 changed the title add support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_… Add Support For GRPC Error Statuses Oct 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2024

Benchmarks

Benchmark execution time: 2024-10-22 19:14:49

Comparing candidate commit 74e89b6 in PR branch khanayan123/add-grpc-error-statuses with baseline commit c4e3979 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (fd0f570) to head (34d255f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4800       +/-   ##
===========================================
+ Coverage   68.58%   83.97%   +15.39%     
===========================================
  Files          12      142      +130     
  Lines         818     5299     +4481     
===========================================
+ Hits          561     4450     +3889     
- Misses        257      849      +592     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanayan123 khanayan123 marked this pull request as ready for review October 17, 2024 22:08
@khanayan123 khanayan123 requested review from a team as code owners October 17, 2024 22:08
@khanayan123 khanayan123 changed the title Add Support For GRPC Error Statuses Add Support For Overriding GRPC Error Statuses Oct 17, 2024
RohitK89
RohitK89 previously approved these changes Oct 18, 2024
Copy link

@RohitK89 RohitK89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but defer to language experts.

wconti27
wconti27 previously approved these changes Oct 22, 2024
Copy link
Contributor

@wconti27 wconti27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khanayan123 khanayan123 dismissed stale reviews from wconti27 and RohitK89 via 74e89b6 October 22, 2024 19:06
@khanayan123 khanayan123 force-pushed the khanayan123/add-grpc-error-statuses branch from 5ce420c to 74e89b6 Compare October 22, 2024 19:06
@khanayan123 khanayan123 merged commit 15ab272 into master Oct 22, 2024
202 checks passed
@khanayan123 khanayan123 deleted the khanayan123/add-grpc-error-statuses branch October 22, 2024 19:25
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* add support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_STATUSES
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* add support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_STATUSES
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* add support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_STATUSES
rochdev pushed a commit that referenced this pull request Nov 6, 2024
* add support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_STATUSES
rochdev pushed a commit that referenced this pull request Nov 6, 2024
* add support for DD_GRPC_CLIENT_ERROR_STATUSES & DD_GRPC_SERVER_ERROR_STATUSES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants