Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors in Express 5.x applications #4872

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Conversation

wantsui
Copy link
Contributor

@wantsui wantsui commented Nov 11, 2024

Motivation

**UPDATE: Fixed the unsafe access to a property, we will not be capping the instrumentation version **

When you try to spin up an Express 5.x application with the tracer, there's an error about fast_star:

TypeError: Cannot read properties of undefined (reading 'fast_star')
It looks like Express 5.x uses Router 2.x which the instrumentation isn't ready to handle at the moment.

Note: With this fix, the app will stop throwing errors when running Express 5.x, but in debug mode this message will be logged:

Error during ddtrace instrumentation of application, aborting.
Error: No original method process_params.

A later PR will need to be made to fix this.

Related to AIDM-438

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Nov 11, 2024

Overall package size

Self size: 7.95 MB
Deduped: 64.97 MB
No deduping: 65.31 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Benchmark execution time: 2024-11-12 17:02:45

Comparing candidate commit fa59d74 in PR branch wantsui/router-fix-attempt with baseline commit 0a44e6e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@wantsui wantsui requested a review from wconti27 November 12, 2024 16:08
@wconti27 wconti27 marked this pull request as ready for review November 12, 2024 16:51
@wconti27 wconti27 requested review from a team as code owners November 12, 2024 16:51
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (0b4dab7) to head (fa59d74).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4872       +/-   ##
===========================================
- Coverage   93.86%   83.30%   -10.56%     
===========================================
  Files         107       12       -95     
  Lines        3373      629     -2744     
===========================================
- Hits         3166      524     -2642     
+ Misses        207      105      -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wconti27 wconti27 merged commit b81d9d8 into master Nov 12, 2024
208 checks passed
@wconti27 wconti27 deleted the wantsui/router-fix-attempt branch November 12, 2024 17:09
rochdev pushed a commit that referenced this pull request Nov 13, 2024
* Fix integration by preventing unsafe access to properties.

---------

Co-authored-by: William Conti <william.conti@datadoghq.com>
Co-authored-by: William Conti <58711692+wconti27@users.noreply.github.com>
@rochdev rochdev mentioned this pull request Nov 13, 2024
rochdev pushed a commit that referenced this pull request Nov 13, 2024
* Fix integration by preventing unsafe access to properties.

---------

Co-authored-by: William Conti <william.conti@datadoghq.com>
Co-authored-by: William Conti <58711692+wconti27@users.noreply.github.com>
@rochdev rochdev mentioned this pull request Nov 13, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
* Fix integration by preventing unsafe access to properties.

---------

Co-authored-by: William Conti <william.conti@datadoghq.com>
Co-authored-by: William Conti <58711692+wconti27@users.noreply.github.com>
rochdev pushed a commit that referenced this pull request Nov 19, 2024
* Fix integration by preventing unsafe access to properties.

---------

Co-authored-by: William Conti <william.conti@datadoghq.com>
Co-authored-by: William Conti <58711692+wconti27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants