Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new ST scenarios for rasp #4883

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Adding new ST scenarios for rasp #4883

merged 7 commits into from
Nov 18, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Nov 13, 2024

What does this PR do?

Adds new System tests scenarios testing new rasp features.

Motivation

Exploit prevention product stability

APPSEC-55562

Copy link

github-actions bot commented Nov 13, 2024

Overall package size

Self size: 7.99 MB
Deduped: 94.28 MB
No deduping: 94.62 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-15 14:46:35

Comparing candidate commit 9be3065 in PR branch ugaitz/run-rasp-scenarios with baseline commit 25ae8e7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@uurien uurien force-pushed the ugaitz/run-rasp-scenarios branch from 7e6af6d to e166008 Compare November 13, 2024 19:55
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@9794630). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4883   +/-   ##
=========================================
  Coverage          ?   72.42%           
=========================================
  Files             ?      322           
  Lines             ?    15347           
  Branches          ?        0           
=========================================
  Hits              ?    11115           
  Misses            ?     4232           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uurien uurien marked this pull request as ready for review November 14, 2024 08:20
@uurien uurien requested review from a team as code owners November 14, 2024 08:20
Copy link
Contributor

@CarlesDD CarlesDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't a new scenario_group have been created for RASP in ST? This way it would be more explicit and we would know at a glance why those scenarios are run.

simon-id
simon-id previously approved these changes Nov 14, 2024
@uurien uurien marked this pull request as draft November 14, 2024 14:04
@uurien uurien force-pushed the ugaitz/run-rasp-scenarios branch from 8866822 to 25bd2de Compare November 14, 2024 14:36
@@ -26,21 +26,21 @@ jobs:
name: system_tests_binaries
path: ./binaries/**/*

get-essential-scenarios:
get-scenarios:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed because we are not getting only essential scenarios now.

@uurien uurien marked this pull request as ready for review November 15, 2024 12:55
@uurien uurien merged commit 1670ef9 into master Nov 18, 2024
231 checks passed
@uurien uurien deleted the ugaitz/run-rasp-scenarios branch November 18, 2024 08:03
rochdev pushed a commit that referenced this pull request Nov 19, 2024
@rochdev rochdev mentioned this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
@rochdev rochdev mentioned this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
rochdev pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants