Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract the passing of extracted header span links to startSpan #4918

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Nov 21, 2024

What does this PR do?

This PR abstracts the process of passing extracted header span links to startSpan from individual plugins to the base level plugin startSpan functions. Furthermore, a quick fix is made to fix a bug with the call to startSpan from web.js

Motivation

Currently, all plugins that extract headers must pass in the extracted span links to its respective call to startSpan. This PR removes the need to do that by checking for extracted span links in the base level plugin startSpan functions. Additionally, this PR makes a quick fix to the web.js call to startSpan, as it was previously incorrectly passing in span links.

Plugin Checklist

Additional Notes

@mhlidd mhlidd requested review from a team as code owners November 21, 2024 00:07
Copy link

github-actions bot commented Nov 21, 2024

Overall package size

Self size: 8.09 MB
Deduped: 94.59 MB
No deduping: 94.93 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (c8ab3e4) to head (f85d7cb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4918       +/-   ##
===========================================
+ Coverage   66.51%   93.72%   +27.20%     
===========================================
  Files         143      132       -11     
  Lines        4784     4158      -626     
===========================================
+ Hits         3182     3897      +715     
+ Misses       1602      261     -1341     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mhlidd mhlidd changed the title Updating where extracted header span links get passed to startSpan Abstract passing of extracted header span links to startSpan Nov 21, 2024
@mhlidd mhlidd changed the title Abstract passing of extracted header span links to startSpan Abstract the passing of extracted header span links to startSpan Nov 21, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Benchmark execution time: 2024-11-21 00:23:24

Comparing candidate commit f85d7cb in PR branch mhlidd/fix_span_links with baseline commit c8ab3e4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 264 metrics, 2 unstable metrics.

@mhlidd mhlidd merged commit 6080dfa into master Nov 21, 2024
236 checks passed
@mhlidd mhlidd deleted the mhlidd/fix_span_links branch November 21, 2024 16:39
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* updating span links

* correcting field name

* fixing links to _links
@rochdev rochdev mentioned this pull request Nov 21, 2024
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* updating span links

* correcting field name

* fixing links to _links
@rochdev rochdev mentioned this pull request Nov 21, 2024
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* updating span links

* correcting field name

* fixing links to _links
rochdev pushed a commit that referenced this pull request Nov 21, 2024
* updating span links

* correcting field name

* fixing links to _links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants