Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(aioredis): handle all BaseException, not Exception in _finish_span (
#4193) (#4198) ## Description This fixes the aioredis integration from raising `CancelledError`. As of Python 3.8 ([Docs link](https://docs.python.org/3/library/asyncio-exceptions.html#asyncio.CancelledError)), `CancelledError` now extends from `BaseException` and not `Exception`, and is currently being raised by the aioredis integration instead of being handled. The aioredis integration now catches all errors extending from `BaseException` in aioredis futures (i.e. the `_finish_span()` callback added to each future). This should resolve #3253. (cherry picked from commit 313a938) Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
- Loading branch information