Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pymongo latest version to 4.9.1 #10804

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 25, 2024

  • update pymongo lockfiles
  • small update to test to account for module import change in pymongo 4.9

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot requested a review from a team as a code owner September 25, 2024 15:42
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 25, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2024

Benchmarks

Benchmark execution time: 2024-09-27 19:21:35

Comparing candidate commit a40347b in PR branch upgrade-latest-pymongo-version with baseline commit 10a31be in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 351 metrics, 53 unstable metrics.

@taegyunkim
Copy link
Contributor

@quinna-h this one didn't update pymongo

@quinna-h
Copy link
Contributor

quinna-h commented Sep 25, 2024

@quinna-h this one didn't update pymongo

What this does is run the scripts/compile-and-prune-test-requirements for all of the riot hashes associated with pymongo. The scripts/compile-and-prune-test-requirements updates the riot requirements for all those hashes, not only the ones that use pymongo latest

For the hashes that didn't update pymongo to 4.9.1, they are testing 3.8.x, 3.9.x, 3.11.x, etc.

Screenshot 2024-09-25 at 1 24 17 PM

But other riot lockfiles that are using latest, are updated to 4.9.1. in this commit, for example .riot/requirements/19aba18.txt

With these auto-generated PRs, we are basically automating this workflow for updating latest (https://github.com/DataDog/dd-trace-py/blob/main/docs/contributing-testing.rst#how-do-i-update-a-riot-environment-to-use-the-latest-version-of-a-package). But if we wanted to only update the lockfiles that are using latest and not just all lockfiles for all riot hashes of the VENV, I can update our scripts/compile-and-prune-test-requirements.

Copy link
Contributor Author

github-actions bot commented Sep 25, 2024

CODEOWNERS have been resolved as:

.riot/requirements/12616cb.txt                                          @DataDog/apm-python
.riot/requirements/13015fd.txt                                          @DataDog/apm-python
.riot/requirements/13fe884.txt                                          @DataDog/apm-python
.riot/requirements/14b37e6.txt                                          @DataDog/apm-python
.riot/requirements/167d6de.txt                                          @DataDog/apm-python
.riot/requirements/185fc1c.txt                                          @DataDog/apm-python
.riot/requirements/19aba18.txt                                          @DataDog/apm-python
.riot/requirements/1ba8c21.txt                                          @DataDog/apm-python
.riot/requirements/1dbb110.txt                                          @DataDog/apm-python
.riot/requirements/1e60db0.txt                                          @DataDog/apm-python
.riot/requirements/1eb9abd.txt                                          @DataDog/apm-python
.riot/requirements/1fd0884.txt                                          @DataDog/apm-python
.riot/requirements/3343686.txt                                          @DataDog/apm-python
.riot/requirements/3390a6b.txt                                          @DataDog/apm-python
.riot/requirements/5a48bdf.txt                                          @DataDog/apm-python
.riot/requirements/6cb445e.txt                                          @DataDog/apm-python
.riot/requirements/8f46789.txt                                          @DataDog/apm-python
.riot/requirements/a0454b7.txt                                          @DataDog/apm-python
.riot/requirements/a98b986.txt                                          @DataDog/apm-python
.riot/requirements/b0a5cc3.txt                                          @DataDog/apm-python
.riot/requirements/b1f6b59.txt                                          @DataDog/apm-python
.riot/requirements/d0fc014.txt                                          @DataDog/apm-python
.riot/requirements/d66afaf.txt                                          @DataDog/apm-python
.riot/requirements/de7d3ce.txt                                          @DataDog/apm-python
tests/contrib/pymongo/test.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python

@quinna-h
Copy link
Contributor

Failing tests should be resolved by #10810

@quinna-h quinna-h enabled auto-merge (squash) September 27, 2024 18:55
@quinna-h quinna-h merged commit b973953 into main Sep 27, 2024
563 checks passed
@quinna-h quinna-h deleted the upgrade-latest-pymongo-version branch September 27, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants